Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Feat (Advanced Settings): Make new "Appearance" category #4902

Merged
merged 1 commit into from
Sep 1, 2023

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 3e1ef80 from #4845.

* Feat (Advanced Settings): Make new "Appearance" category

And remove "Accessibility".
Give category panels IDs so they can be deep linked

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* updated changelog

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* Update theme description

add link to forum

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* Update snapshots

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* update forum link

Signed-off-by: Josh Romero <rmerqg@amazon.com>

* Update src/core/server/ui_settings/settings/theme.ts

Co-authored-by: Miki <amoo_miki@yahoo.com>
Signed-off-by: Josh Romero <rmerqg@amazon.com>

---------

Signed-off-by: Josh Romero <rmerqg@amazon.com>
Co-authored-by: Miki <miki@amazon.com>
Co-authored-by: Miki <amoo_miki@yahoo.com>
(cherry picked from commit 3e1ef80)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #4902 (05fe5e8) into 2.x (993ebc0) will not change coverage.
Report is 2 commits behind head on 2.x.
The diff coverage is n/a.

@@           Coverage Diff           @@
##              2.x    #4902   +/-   ##
=======================================
  Coverage   66.44%   66.44%           
=======================================
  Files        3398     3398           
  Lines       64870    64870           
  Branches    10358    10358           
=======================================
  Hits        43100    43100           
  Misses      19212    19212           
  Partials     2558     2558           
Flag Coverage Δ
Linux_1 34.91% <ø> (ø)
Linux_2 55.18% <ø> (ø)
Linux_3 44.19% <ø> (ø)
Linux_4 35.09% <ø> (ø)
Windows_1 34.93% <ø> (ø)
Windows_2 55.15% <ø> (ø)
Windows_3 44.20% <ø> (ø)
Windows_4 35.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
.../core/server/ui_settings/settings/accessibility.ts 100.00% <ø> (ø)
src/core/server/ui_settings/settings/navigation.ts 100.00% <ø> (ø)
src/core/server/ui_settings/settings/theme.ts 100.00% <ø> (ø)
...ngs/public/management_app/components/form/form.tsx 69.69% <ø> (ø)
...ngs/public/management_app/lib/get_category_name.ts 66.66% <ø> (ø)

@joshuarrrr joshuarrrr merged commit 15350bd into 2.x Sep 1, 2023
72 of 73 checks passed
@joshuarrrr joshuarrrr deleted the backport/backport-4845-to-2.x branch September 1, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports distinguished-contributor v2.10.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants