[Backport 2.x] [OSCI][FIX] Discover: Fix the Subfields Display Issue #5477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* set flattenHit() deep param as true to allow iterate on nested object Signed-off-by: Qiwen Li <qiwen_li@brown.edu> --------- Signed-off-by: qiwen li <qiwen_li@brown.edu> Signed-off-by: Qiwen Li <qiwen_li@brown.edu> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> (cherry picked from commit 40ba1f5) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh and
kavilla
as code owners
opensearch-trigger-bot
bot
requested a review
from seanneumann
as a code owner
opensearch-trigger-bot
bot
added
the
autocut
opensearch-trigger-bot
bot
requested a review
from AMoo-Miki
as a code owner
opensearch-trigger-bot
bot
requested a review
from ashwin-pc
as a code owner
opensearch-trigger-bot
bot
requested review from
joshuarrrr,
abbyhu2000,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #5477 +/- ##
===========================================
+ Coverage 35.26% 67.06% +31.79%
===========================================
Files 1922 3292 +1370
Lines 37905 63347 +25442
Branches 5454 10063 +4609
===========================================
+ Hits 13368 42485 +29117
+ Misses 23922 18421 -5501
- Partials 615 2441 +1826
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
AMoo-Miki
approved these changes
Nov 15, 2023
ananzh
approved these changes
Dec 12, 2023
opensearch-trigger-bot
bot
requested review from
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 40ba1f5 from #5429.