Routing for surrounding doc link should work without a question mark appending to the end #5776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
abbyhu2000
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
zengyan-amazon,
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
BSFishy,
curq,
bandinib-amzn and
SuZhou-Joe
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feature/table-revert #5776 +/- ##
========================================================
+ Coverage 66.98% 67.02% +0.04%
========================================================
Files 3296 3296
Lines 63345 63354 +9
Branches 10089 10090 +1
========================================================
+ Hits 42434 42466 +32
+ Misses 18502 18433 -69
- Partials 2409 2455 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ashwin-pc
reviewed
Feb 2, 2024
| @@ -66,7 +66,7 @@ export function migrateUrlState(oldPath: string, newPath = '/'): string { | |||
| let path = newPath; | |||
| const pathPatterns = [ | |||
| { | |||
| pattern: '#/context/:indexPattern/:id\\?:appState?', | |||
| pattern: '#/context/:indexPattern/:id?:appState?', | |||
There was a problem hiding this comment.
This works because the a route like #/context/ip/abcd results in indexPattern = ip, id = a and appState = bcd
But it looks like we dont need the appState so lets just change the paths to
{
pattern: '#/context/:indexPattern/:id',
extraState: { docView: 'context' },
path: `context`,
},
{
pattern: '#/doc/:indexPattern/:index',
extraState: { docView: 'doc' },
path: `doc`,
},
Also you forgot to add the break statement after line 101
There was a problem hiding this comment.
I dont think we need to add the break statement on line 101? since it will return path anyway @ashwin-pc
There was a problem hiding this comment.
So the way a switch statement works is that once it matches a particular switch case, everything under that is executed until it hits a break or a default statement. So in this case, once the doc or context parts are matched, all commands under that are executed until it hits the final break statement, which means that everything inside the discover path is also executed. https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/switch
There was a problem hiding this comment.
Can you also remove the appstate from the doc route?
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com>
ashwin-pc
approved these changes
Feb 3, 2024
ashwin-pc
merged commit e2f48a2
into
opensearch-project:feature/table-revert
24 of 54 checks passed
ashwin-pc
added a commit
that referenced
this pull request
Feb 7, 2024
…5789) * basic table working Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * basic styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix header column style Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correctly display optional col header actions Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * sorting Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add toggling between legacy and new table According to #5739, add toggle using storage. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of the console log Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * optimize cell filter logics Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more refactoring Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove an used line Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * some more table cell optimization Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Initial UI fixes (#5758) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Table optimization with lazy loading (#5760) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <ananzh@amazon.com> * [Discover] Fix more UI (#5764) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * improved loader Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Change sort icon according to current sort conditions (#5772) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix breadcrumb navigation (#5773) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add pagination to discover embeddable (#5770) * Add pagination Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix an errir Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * small change Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Prevent wrapping of time series cells (#5779) Signed-off-by: Miki <miki@amazon.com> * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) Signed-off-by: Miki <miki@amazon.com> * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <miki@amazon.com> * [Discover] Display filter buttons at top right of the cell (#5784) Signed-off-by: Miki <miki@amazon.com> * [Discover] Vertically align the details toggle button (#5785) Signed-off-by: Miki <miki@amazon.com> * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <miki@amazon.com> * Fix overflow problem of detailed doc Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> * update feedback msg (#5787) Signed-off-by: Anan Z <ananzh@amazon.com> * Resolve sort, default sort and short dot (#5771) Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Discover] Fixes pagination style (#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * style-lint fix Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removed unnecessary div Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix table column error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix pagination edge case Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change path to not include appstate Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * type fixes (#5795) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update toggle to button (#5808) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds support for line count (#5814) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <ananzh@amazon.com> * fix ciGroup7 Signed-off-by: Anan Z <ananzh@amazon.com> * fix ciGroup6 Signed-off-by: Anan Z <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> * add missing snapshot (#5818) Signed-off-by: Anan Z <ananzh@amazon.com> * fix pluign ftr tests (#5821) Signed-off-by: Anan Z <ananzh@amazon.com> * update snapshot (#5824) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * dashboard expect Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Solve cigroup 7 flakiness (#5826) * test hover Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * comment out other ci to speed up Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * uncomment Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removes sub module from branch Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Persist line height (#5836) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * nit Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * update changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Feb 7, 2024
…5789) * basic table working Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * basic styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix header column style Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correctly display optional col header actions Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * sorting Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add toggling between legacy and new table According to #5739, add toggle using storage. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of the console log Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * optimize cell filter logics Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more refactoring Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove an used line Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * some more table cell optimization Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Initial UI fixes (#5758) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Table optimization with lazy loading (#5760) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <ananzh@amazon.com> * [Discover] Fix more UI (#5764) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * improved loader Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Change sort icon according to current sort conditions (#5772) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix breadcrumb navigation (#5773) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add pagination to discover embeddable (#5770) * Add pagination Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix an errir Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * small change Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Prevent wrapping of time series cells (#5779) Signed-off-by: Miki <miki@amazon.com> * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) Signed-off-by: Miki <miki@amazon.com> * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <miki@amazon.com> * [Discover] Display filter buttons at top right of the cell (#5784) Signed-off-by: Miki <miki@amazon.com> * [Discover] Vertically align the details toggle button (#5785) Signed-off-by: Miki <miki@amazon.com> * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <miki@amazon.com> * Fix overflow problem of detailed doc Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> * update feedback msg (#5787) Signed-off-by: Anan Z <ananzh@amazon.com> * Resolve sort, default sort and short dot (#5771) Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Discover] Fixes pagination style (#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * style-lint fix Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removed unnecessary div Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix table column error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix pagination edge case Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change path to not include appstate Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * type fixes (#5795) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update toggle to button (#5808) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds support for line count (#5814) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <ananzh@amazon.com> * fix ciGroup7 Signed-off-by: Anan Z <ananzh@amazon.com> * fix ciGroup6 Signed-off-by: Anan Z <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> * add missing snapshot (#5818) Signed-off-by: Anan Z <ananzh@amazon.com> * fix pluign ftr tests (#5821) Signed-off-by: Anan Z <ananzh@amazon.com> * update snapshot (#5824) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * dashboard expect Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Solve cigroup 7 flakiness (#5826) * test hover Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * comment out other ci to speed up Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * uncomment Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removes sub module from branch Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Persist line height (#5836) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * nit Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * update changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com> (cherry picked from commit e13dbff) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ashwin-pc
pushed a commit
to ashwin-pc/OpenSearch-Dashboards
that referenced
this pull request
Feb 7, 2024
…pensearch-project#5789) * basic table working Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * basic styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix header column style Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correctly display optional col header actions Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * sorting Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add toggling between legacy and new table According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of the console log Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * optimize cell filter logics Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more refactoring Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove an used line Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * some more table cell optimization Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Initial UI fixes (opensearch-project#5758) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Table optimization with lazy loading (opensearch-project#5760) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (opensearch-project#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <ananzh@amazon.com> * [Discover] Fix more UI (opensearch-project#5764) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Discover] Fixes table optimization (opensearch-project#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * improved loader Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Change sort icon according to current sort conditions (opensearch-project#5772) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix breadcrumb navigation (opensearch-project#5773) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add pagination to discover embeddable (opensearch-project#5770) * Add pagination Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix an errir Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * small change Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Prevent wrapping of time series cells (opensearch-project#5779) Signed-off-by: Miki <miki@amazon.com> * Vertically align the text in QueryStringInputUI with other elements on the page (opensearch-project#5780) Signed-off-by: Miki <miki@amazon.com> * Use `ouiCodeFont` in Discover and reduce text size (opensearch-project#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <miki@amazon.com> * [Discover] Display filter buttons at top right of the cell (opensearch-project#5784) Signed-off-by: Miki <miki@amazon.com> * [Discover] Vertically align the details toggle button (opensearch-project#5785) Signed-off-by: Miki <miki@amazon.com> * [Discover] Fix overflow of the expanded document (opensearch-project#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <miki@amazon.com> * Fix overflow problem of detailed doc Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> * update feedback msg (opensearch-project#5787) Signed-off-by: Anan Z <ananzh@amazon.com> * Resolve sort, default sort and short dot (opensearch-project#5771) Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Discover] Fixes pagination style (opensearch-project#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * style-lint fix Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removed unnecessary div Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix table column error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix pagination edge case Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Routing for surrounding doc link should work without a question mark appending to the end (opensearch-project#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change path to not include appstate Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * type fixes (opensearch-project#5795) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update toggle to button (opensearch-project#5808) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds support for line count (opensearch-project#5814) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Add swith to datagrid table and fix ciGroup1 (opensearch-project#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <ananzh@amazon.com> * fix ciGroup7 Signed-off-by: Anan Z <ananzh@amazon.com> * fix ciGroup6 Signed-off-by: Anan Z <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> * add missing snapshot (opensearch-project#5818) Signed-off-by: Anan Z <ananzh@amazon.com> * fix pluign ftr tests (opensearch-project#5821) Signed-off-by: Anan Z <ananzh@amazon.com> * update snapshot (opensearch-project#5824) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional 3 and 4 for discover legacy (opensearch-project#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * dashboard expect Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Solve cigroup 7 flakiness (opensearch-project#5826) * test hover Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * comment out other ci to speed up Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * uncomment Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Simplify feedback modal (opensearch-project#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removes sub module from branch Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Persist line height (opensearch-project#5836) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update table revert changelog (opensearch-project#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes opensearch-project#1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * nit Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * update changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com> (cherry picked from commit e13dbff)
ashwin-pc
added a commit
that referenced
this pull request
Feb 8, 2024
…5789) (#5840) * basic table working Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * basic styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix header column style Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correctly display optional col header actions Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * sorting Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add toggling between legacy and new table According to #5739, add toggle using storage. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of the console log Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * optimize cell filter logics Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more refactoring Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove an used line Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * some more table cell optimization Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Initial UI fixes (#5758) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Table optimization with lazy loading (#5760) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <ananzh@amazon.com> * [Discover] Fix more UI (#5764) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * improved loader Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Change sort icon according to current sort conditions (#5772) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix breadcrumb navigation (#5773) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add pagination to discover embeddable (#5770) * Add pagination Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix an errir Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * small change Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Prevent wrapping of time series cells (#5779) Signed-off-by: Miki <miki@amazon.com> * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) Signed-off-by: Miki <miki@amazon.com> * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <miki@amazon.com> * [Discover] Display filter buttons at top right of the cell (#5784) Signed-off-by: Miki <miki@amazon.com> * [Discover] Vertically align the details toggle button (#5785) Signed-off-by: Miki <miki@amazon.com> * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <miki@amazon.com> * Fix overflow problem of detailed doc Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> * update feedback msg (#5787) Signed-off-by: Anan Z <ananzh@amazon.com> * Resolve sort, default sort and short dot (#5771) Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Discover] Fixes pagination style (#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * style-lint fix Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removed unnecessary div Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix table column error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix pagination edge case Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change path to not include appstate Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * type fixes (#5795) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update toggle to button (#5808) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds support for line count (#5814) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <ananzh@amazon.com> * fix ciGroup7 Signed-off-by: Anan Z <ananzh@amazon.com> * fix ciGroup6 Signed-off-by: Anan Z <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> * add missing snapshot (#5818) Signed-off-by: Anan Z <ananzh@amazon.com> * fix pluign ftr tests (#5821) Signed-off-by: Anan Z <ananzh@amazon.com> * update snapshot (#5824) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * dashboard expect Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Solve cigroup 7 flakiness (#5826) * test hover Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * comment out other ci to speed up Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * uncomment Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removes sub module from branch Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Persist line height (#5836) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * nit Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * update changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com> (cherry picked from commit e13dbff) Co-authored-by: Qingyang(Abby) Hu <abigailhu2000@gmail.com>
kavilla
pushed a commit
that referenced
this pull request
Feb 8, 2024
…5789) (#5839) * basic table working * basic styling * fix header column style * correctly display optional col header actions * move col to the right or left if applicable * add cell filter for and filter out buttons * add cell action on doc table, half working on toggle columns * sorting * Add toggling between legacy and new table According to #5739, add toggle using storage. * get rid of the console log * optimize cell filter logics * add more refactoring * remove an used line * some more table cell optimization * Initial UI fixes (#5758) * Table optimization with lazy loading (#5760) * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab * [Discover] Fix more UI (#5764) * [Discover] Fixes table optimization (#5763) * [Discover] Fixes table optimization * improved loader --------- * Change sort icon according to current sort conditions (#5772) * fix breadcrumb navigation (#5773) * Add pagination to discover embeddable (#5770) * Add pagination * fix an errir * small change * fix errors --------- * [Discover] Prevent wrapping of time series cells (#5779) * Vertically align the text in QueryStringInputUI with other elements on the page (#5780) * Use `ouiCodeFont` in Discover and reduce text size (#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows * [Discover] Display filter buttons at top right of the cell (#5784) * [Discover] Vertically align the details toggle button (#5785) * [Discover] Fix overflow of the expanded document (#5788) * Fix vertical alignment of expand details button Fix colspan of details cells * Fix overflow problem of detailed doc --------- * update feedback msg (#5787) * Resolve sort, default sort and short dot (#5771) * [Discover] Fixes pagination style (#5778) * fixes pagination style * style-lint fix * fix react warning for unnecessary prop * Show total hit count and pass services in embeddable * removed unnecessary div --------- * add changelog * fix table column error * Fix pagination edge case * Routing for surrounding doc link should work without a question mark appending to the end (#5776) * routing for surrounding doc should work without ? * change path to not include appstate * delete optional app state for single doc link too --------- * type fixes (#5795) * Update toggle to button (#5808) * Adds support for line count (#5814) * Add swith to datagrid table and fix ciGroup1 (#5816) * add swith to datagrid table and fix ciGroup1 * fix ciGroup7 * fix ciGroup6 --------- * add missing snapshot (#5818) * fix pluign ftr tests (#5821) * update snapshot (#5824) * Fix functional 3 and 4 for discover legacy (#5822) * fix 3 and 4 * fix functional 3 and 4 * dashboard expect --------- * Solve cigroup 7 flakiness (#5826) * test hover * comment out other ci to speed up * uncomment --------- * [Discover] Simplify feedback modal (#5837) * Simplify feedback modal * renames datagrid settng to newDiscover setting * removes sub module from branch --------- * Persist line height (#5836) * Update table revert changelog (#5835) * Update table revert changelog ### Description updates changelog ### Issues Resolved <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes #1234 or fixes <Issue_URL> --> ## Screenshot <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> ## Testing the changes <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> ### Check List - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change * nit * update changelog --------- * fix table height persist on context page --------- (cherry picked from commit e13dbff) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Feb 21, 2024
…pensearch-project#5789) * basic table working Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * basic styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix header column style Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correctly display optional col header actions Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * sorting Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add toggling between legacy and new table According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of the console log Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * optimize cell filter logics Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more refactoring Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove an used line Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * some more table cell optimization Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Initial UI fixes (opensearch-project#5758) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Table optimization with lazy loading (opensearch-project#5760) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (opensearch-project#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <ananzh@amazon.com> * [Discover] Fix more UI (opensearch-project#5764) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Discover] Fixes table optimization (opensearch-project#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * improved loader Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Change sort icon according to current sort conditions (opensearch-project#5772) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix breadcrumb navigation (opensearch-project#5773) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add pagination to discover embeddable (opensearch-project#5770) * Add pagination Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix an errir Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * small change Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Prevent wrapping of time series cells (opensearch-project#5779) Signed-off-by: Miki <miki@amazon.com> * Vertically align the text in QueryStringInputUI with other elements on the page (opensearch-project#5780) Signed-off-by: Miki <miki@amazon.com> * Use `ouiCodeFont` in Discover and reduce text size (opensearch-project#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <miki@amazon.com> * [Discover] Display filter buttons at top right of the cell (opensearch-project#5784) Signed-off-by: Miki <miki@amazon.com> * [Discover] Vertically align the details toggle button (opensearch-project#5785) Signed-off-by: Miki <miki@amazon.com> * [Discover] Fix overflow of the expanded document (opensearch-project#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <miki@amazon.com> * Fix overflow problem of detailed doc Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> * update feedback msg (opensearch-project#5787) Signed-off-by: Anan Z <ananzh@amazon.com> * Resolve sort, default sort and short dot (opensearch-project#5771) Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Discover] Fixes pagination style (opensearch-project#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * style-lint fix Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removed unnecessary div Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix table column error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix pagination edge case Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Routing for surrounding doc link should work without a question mark appending to the end (opensearch-project#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change path to not include appstate Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * type fixes (opensearch-project#5795) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update toggle to button (opensearch-project#5808) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds support for line count (opensearch-project#5814) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Add swith to datagrid table and fix ciGroup1 (opensearch-project#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <ananzh@amazon.com> * fix ciGroup7 Signed-off-by: Anan Z <ananzh@amazon.com> * fix ciGroup6 Signed-off-by: Anan Z <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> * add missing snapshot (opensearch-project#5818) Signed-off-by: Anan Z <ananzh@amazon.com> * fix pluign ftr tests (opensearch-project#5821) Signed-off-by: Anan Z <ananzh@amazon.com> * update snapshot (opensearch-project#5824) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional 3 and 4 for discover legacy (opensearch-project#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * dashboard expect Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Solve cigroup 7 flakiness (opensearch-project#5826) * test hover Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * comment out other ci to speed up Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * uncomment Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Simplify feedback modal (opensearch-project#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removes sub module from branch Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Persist line height (opensearch-project#5836) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update table revert changelog (opensearch-project#5835) * Update table revert changelog updates changelog <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes opensearch-project#1234 or fixes <Issue_URL> --> <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * nit Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * update changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com>
ananzh
added a commit
to ananzh/OpenSearch-Dashboards
that referenced
this pull request
Feb 21, 2024
…pensearch-project#5789) * basic table working Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * basic styling Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix header column style Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * correctly display optional col header actions Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * move col to the right or left if applicable Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell filter for and filter out buttons Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add cell action on doc table, half working on toggle columns Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * sorting Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add toggling between legacy and new table According to opensearch-project#5739, add toggle using storage. Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * get rid of the console log Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * optimize cell filter logics Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * add more refactoring Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * remove an used line Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * some more table cell optimization Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Initial UI fixes (opensearch-project#5758) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Table optimization with lazy loading (opensearch-project#5760) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover with Legacy Table] fix copy issue and open feedbacks in a new tab (opensearch-project#5761) * add a colon (:) after the key * ensure there's a space between each key-value pair * allow feedback url to open in a new tab Signed-off-by: Anan Z <ananzh@amazon.com> * [Discover] Fix more UI (opensearch-project#5764) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * [Discover] Fixes table optimization (opensearch-project#5763) * [Discover] Fixes table optimization Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * improved loader Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Change sort icon according to current sort conditions (opensearch-project#5772) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix breadcrumb navigation (opensearch-project#5773) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Add pagination to discover embeddable (opensearch-project#5770) * Add pagination Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix an errir Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * small change Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix errors Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Prevent wrapping of time series cells (opensearch-project#5779) Signed-off-by: Miki <miki@amazon.com> * Vertically align the text in QueryStringInputUI with other elements on the page (opensearch-project#5780) Signed-off-by: Miki <miki@amazon.com> * Use `ouiCodeFont` in Discover and reduce text size (opensearch-project#5783) Also: * Fix react `key` errors * vertically align source cells * Clamp the height of the cells * Make sure time-series column never grows Signed-off-by: Miki <miki@amazon.com> * [Discover] Display filter buttons at top right of the cell (opensearch-project#5784) Signed-off-by: Miki <miki@amazon.com> * [Discover] Vertically align the details toggle button (opensearch-project#5785) Signed-off-by: Miki <miki@amazon.com> * [Discover] Fix overflow of the expanded document (opensearch-project#5788) * Fix vertical alignment of expand details button Fix colspan of details cells Signed-off-by: Miki <miki@amazon.com> * Fix overflow problem of detailed doc Signed-off-by: Miki <miki@amazon.com> --------- Signed-off-by: Miki <miki@amazon.com> * update feedback msg (opensearch-project#5787) Signed-off-by: Anan Z <ananzh@amazon.com> * Resolve sort, default sort and short dot (opensearch-project#5771) Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> * [Discover] Fixes pagination style (opensearch-project#5778) * fixes pagination style Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * style-lint fix Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix react warning for unnecessary prop Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Show total hit count and pass services in embeddable Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removed unnecessary div Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> * add changelog Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix table column error Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix pagination edge case Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Routing for surrounding doc link should work without a question mark appending to the end (opensearch-project#5776) * routing for surrounding doc should work without ? Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * change path to not include appstate Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * delete optional app state for single doc link too Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * type fixes (opensearch-project#5795) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update toggle to button (opensearch-project#5808) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Adds support for line count (opensearch-project#5814) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Add swith to datagrid table and fix ciGroup1 (opensearch-project#5816) * add swith to datagrid table and fix ciGroup1 Signed-off-by: Anan <ananzh@amazon.com> * fix ciGroup7 Signed-off-by: Anan Z <ananzh@amazon.com> * fix ciGroup6 Signed-off-by: Anan Z <ananzh@amazon.com> --------- Signed-off-by: Anan <ananzh@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> * add missing snapshot (opensearch-project#5818) Signed-off-by: Anan Z <ananzh@amazon.com> * fix pluign ftr tests (opensearch-project#5821) Signed-off-by: Anan Z <ananzh@amazon.com> * update snapshot (opensearch-project#5824) Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Fix functional 3 and 4 for discover legacy (opensearch-project#5822) * fix 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * fix functional 3 and 4 Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * dashboard expect Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * Solve cigroup 7 flakiness (opensearch-project#5826) * test hover Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * comment out other ci to speed up Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * uncomment Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> * [Discover] Simplify feedback modal (opensearch-project#5837) * Simplify feedback modal Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * renames datagrid settng to newDiscover setting Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * removes sub module from branch Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Persist line height (opensearch-project#5836) Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * Update table revert changelog (opensearch-project#5835) * Update table revert changelog updates changelog <!-- List any issues this PR will resolve. Prefix the issue with the keyword closes, fixes, fix --> <!-- Example: closes opensearch-project#1234 or fixes <Issue_URL> --> <!-- Attach any relevant screenshots. Any change to the UI requires an attached screenshot in the PR Description --> <!-- Please provide detailed steps for validating your changes. This could involve specific commands to run, pages to visit, scenarios to try or any other information that would help reviewers verify the functionality of your change --> - [ ] All tests pass - [ ] `yarn test:jest` - [ ] `yarn test:jest_integration` - [ ] New functionality includes testing. - [ ] New functionality has been documented. - [ ] Update [CHANGELOG.md](./../CHANGELOG.md) - [ ] Commits are signed per the DCO using --signoff * revert dependency change Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * nit Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * update changelog Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> * fix table height persist on context page Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> --------- Signed-off-by: abbyhu2000 <abigailhu2000@gmail.com> Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com> Signed-off-by: Anan Z <ananzh@amazon.com> Signed-off-by: Miki <miki@amazon.com> Signed-off-by: Anan Zhuang <ananzh@amazon.com> Signed-off-by: Anan <ananzh@amazon.com> Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com> Co-authored-by: Anan Zhuang <ananzh@amazon.com> Co-authored-by: Miki <miki@amazon.com> Co-authored-by: Ganesh0107 <ganesh.gopal@freshworks.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
URLs such as /app/discover#/context// which is a valid URL for the context page should work.
Previously the link will only work if there is a question mark append to it.
Issues Resolved
closes #5774
Screenshot
Screen.Recording.2024-02-01.at.4.28.34.PM.mov
Testing the changes
Check List
yarn test:jestyarn test:jest_integration