Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump oui to 1.5.1 #5862

Merged
merged 2 commits into from
Feb 10, 2024
Merged

Conversation

ashwin-pc
Copy link
Member

@ashwin-pc ashwin-pc commented Feb 10, 2024

Description

Updates OUI to 1.5.1

Issues Resolved

Screenshot

Testing the changes

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
@@ -92,7 +92,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
- Replace `node-sass` with `sass-embedded` ([#5338](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5338))
- Bump `chromedriver` from `107.0.3` to `119.0.1` ([#5465](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5465))
- Bump `typescript` resolution from `4.0.2` to `4.6.4` ([#5470](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5470))
- Bump `OUI` to `1.4.0` ([#5637](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5637))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why update this? Should we add a new item in Maintenance?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a change mid release

@@ -60,7 +60,7 @@
- [Data Explorer] Add Readme for Data Explorer ([#5273](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5273))
- Replace `node-sass` with `sass-embedded` ([#5338](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5338))
- Add documentation on files in util in addition to a README.md with an overview of each file and its exported functions ([#5540](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5540))
- Bump `OUI` to `1.4.0` ([#5637](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/5637))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same question

Copy link

codecov bot commented Feb 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba298c7) 66.91% compared to head (94737cc) 66.95%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5862      +/-   ##
==========================================
+ Coverage   66.91%   66.95%   +0.04%     
==========================================
  Files        3302     3302              
  Lines       63532    63532              
  Branches    10146    10146              
==========================================
+ Hits        42512    42538      +26     
+ Misses      18599    18529      -70     
- Partials     2421     2465      +44     
Flag Coverage Δ
Linux_1 35.21% <ø> (ø)
Linux_2 55.11% <ø> (?)
Linux_3 43.86% <ø> (?)
Linux_4 35.21% <ø> (ø)
Windows_1 35.24% <ø> (ø)
Windows_2 55.07% <ø> (ø)
Windows_3 43.87% <ø> (+<0.01%) ⬆️
Windows_4 35.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki merged commit bd75107 into opensearch-project:main Feb 10, 2024
76 of 77 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-5862-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd75107ef9612f155710fc7217a2d1c5c6713fdb
# Push it to GitHub
git push --set-upstream origin backport/backport-5862-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-5862-to-2.x.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.12 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.12 2.12
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.12
# Create a new branch
git switch --create backport/backport-5862-to-2.12
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 bd75107ef9612f155710fc7217a2d1c5c6713fdb
# Push it to GitHub
git push --set-upstream origin backport/backport-5862-to-2.12
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.12

Then, create a pull request where the base branch is 2.12 and the compare/head branch is backport/backport-5862-to-2.12.

AMoo-Miki pushed a commit that referenced this pull request Feb 12, 2024
* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit bd75107)
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 12, 2024
* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit bd75107)
ashwin-pc added a commit that referenced this pull request Feb 12, 2024
* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
(cherry picked from commit bd75107)

Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
ananzh pushed a commit to ananzh/OpenSearch-Dashboards that referenced this pull request Feb 21, 2024
* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 26, 2024
* bump oui to 1.5.1
* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Feb 26, 2024
* bump oui to 1.5.1
* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
abbyhu2000 pushed a commit that referenced this pull request Feb 27, 2024
* bump oui to 1.5.1
* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Mar 14, 2024
* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit bd75107)
Signed-off-by: Miki <miki@amazon.com>
AMoo-Miki pushed a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Mar 18, 2024
* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit bd75107)
Signed-off-by: Miki <miki@amazon.com>
ashwin-pc added a commit that referenced this pull request Mar 19, 2024
* Bump oui to 1.5.1 (#5862)

* bump oui to 1.5.1

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

* Updates changelog

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>

(cherry picked from commit bd75107)
Signed-off-by: Miki <miki@amazon.com>

* Bump axios to 0.28.0

Signed-off-by: Miki <miki@amazon.com>

---------

Signed-off-by: Ashwin P Chandran <ashwinpc@amazon.com>
Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: Ashwin P Chandran <ashwinpc@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants