[Workspace] Add base path when parsing url in http service

[SuZhou-Joe]

Description

Make basePath required in getWorkspaceIdFromUrl method.

Issues Resolved

fixes #6015

Screenshot

Testing the changes

• Using the branch to bootstrap
• Enable workspace by adding workspace.enabled to opensearch_dashboards.yml file
• Start OSD by using yarn start to enable basePath feature.
• Navigate to devTools
• Insert test workspaces by calling

PUT .kibana/_doc/workspace:foo
{
  "type": "workspace",
  "workspace": {
    "name": "foo"
  }
}

• Visit the OpenSearch Dashboards under foo workspace: http://localhost:5603/{random_basePath}/w/foo/app/dev_tools
• The page should be able to load.

Check List

• All tests pass
  • yarn test:jest
  • yarn test:jest_integration
• New functionality includes testing.
• New functionality has been documented.
• Update CHANGELOG.md
• Commits are signed per the DCO using --signoff

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.33%. Comparing base (4a8e3e8) to head (5f05b34).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6233      +/-   ##
==========================================
+ Coverage   67.28%   67.33%   +0.04%     
==========================================
  Files        3351     3351              
  Lines       65038    65037       -1     
  Branches    10475    10475              
==========================================
+ Hits        43763    43793      +30     
+ Misses      18704    18700       -4     
+ Partials     2571     2544      -27     

Flag	Coverage Δ
Linux_1	31.82% <66.66%> (-0.01%)	⬇️
Linux_2	55.57% <100.00%> (?)
Linux_3	44.68% <100.00%> (?)
Linux_4	35.03% <50.00%> (?)
Windows_1	31.84% <66.66%> (-0.01%)	⬇️
Windows_2	55.53% <100.00%> (ø)
Windows_3	44.68% <100.00%> (-0.02%)	⬇️
Windows_4	35.03% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[xinruiba]

LGTM, ship

[ruanyl]

Q: why it need to specify '' as the second parameter explicitly?

[ruanyl]

Maybe my question is more about why we need to change the getWorkspaceIdFromUrl function signature?

[SuZhou-Joe]

1. From the implementation perspective, the basePath parameter is required when constructing the regular expression to parse the workspace id from url.
2. The bug comes from the loose function signature, I change it to a more strict signature so that others won't step into similar bug.

[opensearch-trigger-bot]

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6233-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 0dce00a806bf8815ca84802541010767b6b3a8bd
# Push it to GitHub
git push --set-upstream origin backport/backport-6233-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6233-to-2.x.