Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace control characters in logs #6402

Merged
merged 2 commits into from
Apr 12, 2024

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Apr 11, 2024

Description

This change replaces certain control characters with their representation from the logs.

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link

codecov bot commented Apr 11, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 55.62%. Comparing base (85df662) to head (39a0367).
Report is 10 commits behind head on main.

Files Patch % Lines
packages/osd-std/src/index.ts 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6402      +/-   ##
==========================================
+ Coverage   55.58%   55.62%   +0.03%     
==========================================
  Files        1199     1200       +1     
  Lines       24259    24265       +6     
  Branches     4087     4088       +1     
==========================================
+ Hits        13485    13498      +13     
+ Misses      10133    10124       -9     
- Partials      641      643       +2     
Flag Coverage Δ
Linux_2 55.62% <85.71%> (?)
Windows_2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Apr 11, 2024
Copy link
Member

@ashwin-pc ashwin-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

kavilla
kavilla previously approved these changes Apr 11, 2024
@AMoo-Miki AMoo-Miki marked this pull request as draft April 11, 2024 16:36
Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki dismissed stale reviews from kavilla and ashwin-pc via 4a20b6f April 11, 2024 16:39
@AMoo-Miki AMoo-Miki marked this pull request as ready for review April 11, 2024 16:40
Copy link
Member

@SuZhou-Joe SuZhou-Joe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashwin-pc ashwin-pc merged commit c89d304 into opensearch-project:main Apr 12, 2024
68 checks passed
@opensearch-trigger-bot
Copy link
Contributor

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 128

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-1.3 1.3
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-1.3
# Create a new branch
git switch --create backport/backport-6402-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c89d3047d46ca809b6540c0fab8db33c6e736c09
# Push it to GitHub
git push --set-upstream origin backport/backport-6402-to-1.3
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-6402-to-1.3.

@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.x 2.x
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.x
# Create a new branch
git switch --create backport/backport-6402-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 c89d3047d46ca809b6540c0fab8db33c6e736c09
# Push it to GitHub
git push --set-upstream origin backport/backport-6402-to-2.x
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-6402-to-2.x.

AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Apr 22, 2024
Signed-off-by: Miki <miki@amazon.com>

(cherry picked from commit c89d304)
Signed-off-by: Miki <miki@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 22, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit c89d304)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md
AMoo-Miki added a commit to AMoo-Miki/OpenSearch-Dashboards that referenced this pull request Apr 22, 2024
Signed-off-by: Miki <miki@amazon.com>

(cherry picked from commit c89d304)
Signed-off-by: Miki <miki@amazon.com>
kavilla pushed a commit that referenced this pull request Apr 27, 2024
Signed-off-by: Miki <miki@amazon.com>
(cherry picked from commit c89d304)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

# Conflicts:
#	CHANGELOG.md

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
kavilla pushed a commit that referenced this pull request Apr 27, 2024
(cherry picked from commit c89d304)

Signed-off-by: Miki <miki@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants