-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[workspace] Fix not able to query legacy data when have at least 1 workspace #7254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hailong Cui <ihailong@amazon.com>
Hailong-am
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27 and
virajsanghvi
as code owners
July 16, 2024 04:03
github-actions
bot
added
seasoned-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
labels
Jul 16, 2024
SuZhou-Joe
changed the title
Fix not able to query legacy data when have at least 1 workspace
[workspace] Fix not able to query legacy data when have at least 1 workspace
Jul 16, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7254 +/- ##
==========================================
+ Coverage 67.52% 67.53% +0.01%
==========================================
Files 3504 3504
Lines 69410 69412 +2
Branches 11324 11324
==========================================
+ Hits 46868 46877 +9
+ Misses 19779 19775 -4
+ Partials 2763 2760 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
this is should able to fix by #7252 |
SuZhou-Joe
reviewed
Jul 17, 2024
src/plugins/saved_objects_management/server/routes/scroll_count.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Hailong Cui <ihailong@amazon.com>
ruanyl
approved these changes
Jul 19, 2024
SuZhou-Joe
approved these changes
Jul 19, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 19, 2024
…rkspace (#7254) * Fix not able to query legacy data when have at least 1 workspace Signed-off-by: Hailong Cui <ihailong@amazon.com> * fix typo Signed-off-by: Hailong Cui <ihailong@amazon.com> * update snapshot Signed-off-by: Hailong Cui <ihailong@amazon.com> --------- Signed-off-by: Hailong Cui <ihailong@amazon.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com> (cherry picked from commit 3bb4170) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
SuZhou-Joe
pushed a commit
that referenced
this pull request
Jul 20, 2024
…rkspace (#7254) (#7320) * Fix not able to query legacy data when have at least 1 workspace * fix typo * update snapshot --------- (cherry picked from commit 3bb4170) Signed-off-by: Hailong Cui <ihailong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Yulong Ruan <ruanyl@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport 2.x
seasoned-contributor
Skip-Changelog
PRs that are too trivial to warrant a changelog or release notes entry
v2.16.0
workspace
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Remove the workspace filter condition when user not in any workspace, the workspace query condition will automatically add when saved objects permission control is enabled.
If saved objects permission control is disabled, there is no need to filter by workspace when no workspace is selected, user should able to see all objects.
Issues Resolved
#7253
Screenshot
Screen.Recording.2024-07-17.at.11.40.35.mov
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration