-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use xs buttons for discover table cell filter buttons #7531
fix: use xs buttons for discover table cell filter buttons #7531
Conversation
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
❌ Invalid Additional Prefix With Skip Entry OptionIf your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again. |
❌ Invalid Additional Prefix With Skip Entry OptionIf your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7531 +/- ##
=======================================
Coverage 64.11% 64.11%
=======================================
Files 3615 3615
Lines 78761 78761
Branches 12456 12456
=======================================
Hits 50498 50498
Misses 25207 25207
Partials 3056 3056
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Viraj Sanghvi <virajs@amazon.com> (cherry picked from commit 8441667) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Viraj Sanghvi <virajs@amazon.com> (cherry picked from commit 8441667) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…7539) (cherry picked from commit 8441667) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
…7538) (cherry picked from commit 8441667) Signed-off-by: Viraj Sanghvi <virajs@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
…h-project#7531) Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Description
Discover table cell buttons got larger, this just makes them match previous size. See screenshots below.
The positioning difference wrt to border is likely due to padding change (although when I changed padding, I made sure these buttons showed up in the same place, so not sure if something else changed).
Issues Resolved
N/A
Screenshot
Change:
Playground:
Testing the changes
Validated in discover locally vs playground
Changelog
Check List
yarn test:jest
yarn test:jest_integration