Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use xs buttons for discover table cell filter buttons #7531

Merged

Conversation

virajsanghvi
Copy link
Collaborator

@virajsanghvi virajsanghvi commented Jul 26, 2024

Description

Discover table cell buttons got larger, this just makes them match previous size. See screenshots below.

The positioning difference wrt to border is likely due to padding change (although when I changed padding, I made sure these buttons showed up in the same place, so not sure if something else changed).

Issues Resolved

N/A

Screenshot

Change:
image
image

Playground:
image
image

Testing the changes

Validated in discover locally vs playground

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Copy link
Contributor

❌ Invalid Additional Prefix With Skip Entry Option

If your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again.

Copy link
Contributor

❌ Invalid Additional Prefix With Skip Entry Option

If your Changelog section includes the 'skip' entry option, it cannot also include other changelog entry prefixes. The option 'skip' must be alone when used. Please review your Changelog section again.

@github-actions github-actions bot added Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry and removed failed changeset labels Jul 26, 2024
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.11%. Comparing base (5a849b0) to head (2ba07f5).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7531   +/-   ##
=======================================
  Coverage   64.11%   64.11%           
=======================================
  Files        3615     3615           
  Lines       78761    78761           
  Branches    12456    12456           
=======================================
  Hits        50498    50498           
  Misses      25207    25207           
  Partials     3056     3056           
Flag Coverage Δ
Linux_1 30.90% <ø> (ø)
Linux_2 55.59% <ø> (ø)
Linux_3 40.63% <ø> (ø)
Linux_4 31.76% <ø> (ø)
Windows_1 30.92% <ø> (ø)
Windows_2 55.54% <ø> (ø)
Windows_3 40.64% <ø> (ø)
Windows_4 31.76% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@virajsanghvi virajsanghvi merged commit 8441667 into opensearch-project:main Jul 27, 2024
68 of 71 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 27, 2024
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 8441667)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 27, 2024
Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
(cherry picked from commit 8441667)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu pushed a commit that referenced this pull request Jul 29, 2024
…7539)

(cherry picked from commit 8441667)

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
zhongnansu pushed a commit that referenced this pull request Jul 29, 2024
…7538)

(cherry picked from commit 8441667)

Signed-off-by: Viraj Sanghvi <virajs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Viraj Sanghvi <virajs@amazon.com>
Qxisylolo pushed a commit to Qxisylolo/OpenSearch-Dashboards that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.16 look & feel Look and Feel Improvements repeat-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry v2.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants