Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual backport 2.13] Use JSON11 for handling long numerals (#6915) #7706

Closed
wants to merge 1 commit into from

Conversation

AMoo-Miki
Copy link
Collaborator

Cherry picked commit 6a20742 from #6915

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

…search-project#6970)

(cherry picked from commit 6a20742)

Signed-off-by: Miki <miki@amazon.com>
@AMoo-Miki AMoo-Miki changed the title Use JSON11 for handling long numerals (#6915) [Manual backport 2.13] Use JSON11 for handling long numerals (#6915) Aug 14, 2024
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 31.33%. Comparing base (1d3b040) to head (b38a0a9).

Files Patch % Lines
packages/osd-std/src/json.ts 20.00% 4 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (1d3b040) and HEAD (b38a0a9). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (1d3b040) HEAD (b38a0a9)
Windows_2 1 0
Additional details and impacted files
@@             Coverage Diff             @@
##             2.13    #7706       +/-   ##
===========================================
- Coverage   55.35%   31.33%   -24.03%     
===========================================
  Files        1194     2211     +1017     
  Lines       24037    44333    +20296     
  Branches     4009     6855     +2846     
===========================================
+ Hits        13306    13890      +584     
- Misses      10107    29823    +19716     
+ Partials      624      620        -4     
Flag Coverage Δ
Linux_1 31.33% <20.00%> (?)
Windows_2 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AMoo-Miki AMoo-Miki closed this Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant