[discover] pass connection title correctly and set session id #7997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated so the session ID gets correctly passed along to speed up subsequent queries. Also set the connection title to the datasource meta field to be used as originally interfaced. Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
kavilla
requested review from
ananzh,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli and
joshuali925
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
github-actions
bot
added
Skip-Changelog
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7997 +/- ##
==========================================
+ Coverage 61.09% 61.13% +0.04%
==========================================
Files 3691 3691
Lines 87310 87342 +32
Branches 13433 13435 +2
==========================================
+ Hits 53340 53398 +58
+ Misses 30722 30690 -32
- Partials 3248 3254 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
sejli
approved these changes
Sep 4, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
Updated so the session ID gets correctly passed along to speed up subsequent queries. Also set the connection title to the datasource meta field to be used as originally interfaced. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit de027c2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 4, 2024
…#8002) Updated so the session ID gets correctly passed along to speed up subsequent queries. Also set the connection title to the datasource meta field to be used as originally interfaced. (cherry picked from commit de027c2) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 5, 2024
Updated so the session ID gets correctly passed along to speed up subsequent queries. Also set the connection title to the datasource meta field to be used as originally interfaced. Signed-off-by: Kawika Avilla <kavilla414@gmail.com> (cherry picked from commit de027c2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
kavilla
pushed a commit
that referenced
this pull request
Sep 5, 2024
…#8007) Updated so the session ID gets correctly passed along to speed up subsequent queries. Also set the connection title to the datasource meta field to be used as originally interfaced. (cherry picked from commit de027c2) Signed-off-by: Kawika Avilla <kavilla414@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated so the session ID gets correctly passed along to speed up subsequent queries. Also set the connection title to the datasource meta field to be used as originally interfaced.
Issues Resolved
n/a
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration