Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MDS] Add MDS support for Integration #8008

Merged
merged 7 commits into from
Sep 10, 2024

Conversation

RyanL1997
Copy link
Contributor

@RyanL1997 RyanL1997 commented Sep 5, 2024

Signed-off-by: Ryan Liang jiallian@amazon.com### Description

Description

[MDS]Add MDS support for Integration

Issues Resolved

Screenshot

Screenshot 2024-09-09 at 2 19 37 PM

In the above screenshot, it shows successful integration of a remote cluster. The network tab shows the cluster id that matches the cluster id in search bar.

Testing the changes

Changelog

  • feat: [MDS]Add MDS support for Integration

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 53.57143% with 13 lines in your changes missing coverage. Please review.

Project coverage is 60.59%. Comparing base (7366ad6) to head (747738c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...nnection_detail/direct_query_connection_detail.tsx 71.42% 3 Missing and 3 partials ⚠️
...rces_components/integrations/setup_integration.tsx 0.00% 5 Missing ⚠️
...ponents/integrations/create_integration_helpers.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8008      +/-   ##
==========================================
- Coverage   60.60%   60.59%   -0.01%     
==========================================
  Files        3738     3738              
  Lines       88669    88686      +17     
  Branches    13782    13787       +5     
==========================================
+ Hits        53734    53738       +4     
- Misses      31650    31660      +10     
- Partials     3285     3288       +3     
Flag Coverage Δ
Linux_1 28.76% <ø> (ø)
Linux_2 56.27% <ø> (ø)
Linux_3 37.53% <53.57%> (+0.01%) ⬆️
Linux_4 29.60% <ø> (ø)
Windows_1 28.77% <ø> (-0.02%) ⬇️
Windows_2 56.22% <ø> (ø)
Windows_3 37.53% <53.57%> (+0.01%) ⬆️
Windows_4 29.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997 RyanL1997 added backport 2.17 enhancement New feature or request labels Sep 9, 2024
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

BionIT
BionIT previously approved these changes Sep 9, 2024
@BionIT
Copy link
Collaborator

BionIT commented Sep 9, 2024

Can we add some screenshots/videos about the change? Also looks like codecov failed for the changed diff and could you fix by adding more tests?

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@BionIT BionIT merged commit 2999fdf into opensearch-project:main Sep 10, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
* Add mds support for Integration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add mds support for Integration flyout only for creation

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the installed integration table content

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Update snapshot

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Update to fix the local cluster integration fetch and add more test case

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Update release notes

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #8008 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2999fdf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 10, 2024
* Add mds support for Integration

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Add mds support for Integration flyout only for creation

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the installed integration table content

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Update snapshot

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Update to fix the local cluster integration fetch and add more test case

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Update release notes

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #8008 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 2999fdf)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Flyingliuhub pushed a commit that referenced this pull request Sep 11, 2024
* Add mds support for Integration



* Add mds support for Integration flyout only for creation



* Fix the installed integration table content



* Update snapshot



* Update to fix the local cluster integration fetch and add more test case



* Update release notes



* Changeset file for PR #8008 created/updated

---------



(cherry picked from commit 2999fdf)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
BionIT pushed a commit that referenced this pull request Sep 11, 2024
* Add mds support for Integration



* Add mds support for Integration flyout only for creation



* Fix the installed integration table content



* Update snapshot



* Update to fix the local cluster integration fetch and add more test case



* Update release notes



* Changeset file for PR #8008 created/updated

---------



(cherry picked from commit 2999fdf)

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
@RyanL1997 RyanL1997 changed the title [MDS]Add MDS support for Integration [MDS] Add MDS support for Integration Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants