Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP][discover] PPL and SQL use default internal search route #8019

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Sep 5, 2024

Description

commit currently doesn't work.

likely because we need to parse the bare minimum required request for PPL endpoints as it seems to be sending too much an error.

After all the refactoring for 2.17. The default /internal/search with search strategy is now usable. Effectly ensuring we are using no new API routes.

also i think this should fix the issue where index patterns dont work with ppl and sql (could be a new issue)

Issues Resolved

n/a

Screenshot

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

❌ Empty Changelog Section

The Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

Attention: Patch coverage is 20.51282% with 31 lines in your changes missing coverage. Please review.

Project coverage is 60.54%. Comparing base (7366ad6) to head (8f5649a).

Files with missing lines Patch % Lines
.../data/common/search/search_source/search_source.ts 0.00% 10 Missing ⚠️
...c/plugins/query_enhancements/server/utils/facet.ts 11.11% 8 Missing ⚠️
src/plugins/query_enhancements/common/utils.ts 50.00% 4 Missing ⚠️
...gins/query_enhancements/public/datasets/s3_type.ts 25.00% 3 Missing ⚠️
..._enhancements/server/search/sql_search_strategy.ts 25.00% 3 Missing ⚠️
...ugins/data/server/search/routes/shim_hits_total.ts 33.33% 1 Missing and 1 partial ⚠️
...on/search/search_source/fetch/get_search_params.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8019      +/-   ##
==========================================
- Coverage   60.60%   60.54%   -0.06%     
==========================================
  Files        3738     3738              
  Lines       88669    88679      +10     
  Branches    13782    13783       +1     
==========================================
- Hits        53734    53692      -42     
- Misses      31650    31705      +55     
+ Partials     3285     3282       -3     
Flag Coverage Δ
Linux_1 28.76% <0.00%> (+<0.01%) ⬆️
Linux_2 56.27% <0.00%> (+<0.01%) ⬆️
Linux_3 ?
Linux_4 ?
Windows_1 28.77% <0.00%> (-0.02%) ⬇️
Windows_2 56.22% <0.00%> (+<0.01%) ⬆️
Windows_3 37.52% <7.14%> (+<0.01%) ⬆️
Windows_4 29.55% <17.94%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
@@ -37,6 +33,12 @@ export const getFields = (rawResponse: any) => {
}));
};

export const getQuery = (searchRequest: IOpenSearchDashboardsSearchRequest): Query => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

parses query

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants