-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
display direct query connections of local cluster in data sources page #8059
Conversation
LGTM! 🚀 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8059 +/- ##
==========================================
- Coverage 60.59% 60.58% -0.01%
==========================================
Files 3738 3738
Lines 88636 88662 +26
Branches 13763 13780 +17
==========================================
+ Hits 53711 53719 +8
- Misses 31649 31659 +10
- Partials 3276 3284 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Just checked with @RyanL1997 , we should not show local cluster when |
I think the similar implementation for doing that can be found here: #7497 |
Signed-off-by: Wei Wang <weiwsde@gmail.com>
Already updated the commit.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
e621422
into
opensearch-project:main
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8059-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 e62142256484ca56382ca46b6394ed874b5a10e9
# Push it to GitHub
git push --set-upstream origin backport/backport-8059-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17 Then, create a pull request where the |
opensearch-project#8059) Signed-off-by: Wei Wang <weiwsde@gmail.com> (cherry picked from commit e621422)
#8059) (#8065) (cherry picked from commit e621422) Signed-off-by: Wei Wang <weiwsde@gmail.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: ZilongX <99905560+ZilongX@users.noreply.github.com>
opensearch-project#8059) Signed-off-by: Wei Wang <weiwsde@gmail.com>
opensearch-project#8059) Signed-off-by: Wei Wang <weiwsde@gmail.com>
Manually backported to 2.17 with #8068 |
Description
This pr implement displaying direct query connections of local cluster in different scenarios:
Also solve a small bug when directing to direct query data source details page.
Issues Resolved
Screenshot
Data Source Enabled
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration