-
Notifications
You must be signed in to change notification settings - Fork 867
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.17 Release Notes #8061
2.17 Release Notes #8061
Conversation
Signed-off-by: Sean Li <lnse@amazon.com>
@AMoo-Miki @ananzh @abbyhu2000 Can you help to review this and get it merged? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how is changelog different from release notes? and i know we skip changelog for smaller PRs, do they need to be in release notes?
Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit c701b7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit c701b7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
good question. for the changelog it is the total list of all changes from all the versions. i believe technically it should be if they switch branches they can see the latest and greatest features/fixes/refactors. the release notes just need to be for the current version. for skipping changelog could apply to the release notes, my general rule of thumb is not necessarily related to length. if a PR brings in a new feature unreleased. and then the contributor releases there is a bug and immediately fixes it in a subsequent PR. in the release notes it wouldn't make sense to have a feature that nobody has used yet and have two rows one being the note for a bug fix for that new feature. the users only got the feature when it didn't include the bug |
(cherry picked from commit c701b7d) Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Sean Li <lnse@amazon.com>
* Adding 2.17 release notes (#8061) Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit c701b7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Adding 2.17 release notes (#8061) Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com>
Signed-off-by: Sean Li <lnse@amazon.com>
* Adding 2.17 release notes (opensearch-project#8061) Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit c701b7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Adding 2.17 release notes (opensearch-project#8061) Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com>
* Adding 2.17 release notes (opensearch-project#8061) Signed-off-by: Sean Li <lnse@amazon.com> (cherry picked from commit c701b7d) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> * Adding 2.17 release notes (opensearch-project#8061) Signed-off-by: Sean Li <lnse@amazon.com> --------- Signed-off-by: Sean Li <lnse@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Sean Li <lnse@amazon.com>
Description
Ran
yarn release_note:generate
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jest
yarn test:jest_integration