Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.17 Release Notes #8061

Merged
merged 1 commit into from
Sep 6, 2024
Merged

Conversation

sejli
Copy link
Member

@sejli sejli commented Sep 6, 2024

Description

Ran yarn release_note:generate

Issues Resolved

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Sean Li <lnse@amazon.com>
@gaiksaya
Copy link
Member

gaiksaya commented Sep 6, 2024

@AMoo-Miki @ananzh @abbyhu2000 Can you help to review this and get it merged?
Thanks!

Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how is changelog different from release notes? and i know we skip changelog for smaller PRs, do they need to be in release notes?

@sejli sejli merged commit c701b7d into opensearch-project:2.x Sep 6, 2024
5 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit c701b7d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit c701b7d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@kavilla
Copy link
Member

kavilla commented Sep 6, 2024

how is changelog different from release notes? and i know we skip changelog for smaller PRs, do they need to be in release notes?

good question.

for the changelog it is the total list of all changes from all the versions. i believe technically it should be if they switch branches they can see the latest and greatest features/fixes/refactors. the release notes just need to be for the current version.

for skipping changelog could apply to the release notes, my general rule of thumb is not necessarily related to length. if a PR brings in a new feature unreleased. and then the contributor releases there is a bug and immediately fixes it in a subsequent PR. in the release notes it wouldn't make sense to have a feature that nobody has used yet and have two rows one being the note for a bug fix for that new feature. the users only got the feature when it didn't include the bug

kavilla pushed a commit that referenced this pull request Sep 6, 2024
(cherry picked from commit c701b7d)

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
sejli added a commit that referenced this pull request Sep 6, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
sejli added a commit that referenced this pull request Sep 7, 2024
* Adding 2.17 release notes (#8061)

Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit c701b7d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Adding 2.17 release notes (#8061)

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
sejli added a commit to sejli/OpenSearch-Dashboards that referenced this pull request Sep 7, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 8, 2024
* Adding 2.17 release notes (opensearch-project#8061)

Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit c701b7d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Adding 2.17 release notes (opensearch-project#8061)

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
SuZhou-Joe pushed a commit to SuZhou-Joe/OpenSearch-Dashboards that referenced this pull request Sep 10, 2024
* Adding 2.17 release notes (opensearch-project#8061)

Signed-off-by: Sean Li <lnse@amazon.com>
(cherry picked from commit c701b7d)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Adding 2.17 release notes (opensearch-project#8061)

Signed-off-by: Sean Li <lnse@amazon.com>

---------

Signed-off-by: Sean Li <lnse@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Sean Li <lnse@amazon.com>
sejli added a commit that referenced this pull request Sep 10, 2024
Signed-off-by: Sean Li <lnse@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport main backport 2.17 Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants