Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark user personal settings as experimental #8080

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

Hailong-am
Copy link
Contributor

Description

This PR is a quick follow up on user settings PR comments

It includes

  1. mark user settings as experimental
  2. add i18n support for user settings page

Issues Resolved

#8072

Screenshot

Testing the changes

Changelog

  • skip

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Hailong Cui <ihailong@amazon.com>
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 60.58%. Comparing base (cedba8e) to head (3036993).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...rkspace/public/components/workspace_list/index.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8080      +/-   ##
==========================================
- Coverage   60.58%   60.58%   -0.01%     
==========================================
  Files        3738     3738              
  Lines       88674    88670       -4     
  Branches    13782    13782              
==========================================
- Hits        53727    53723       -4     
  Misses      31662    31662              
  Partials     3285     3285              
Flag Coverage Δ
Linux_1 28.76% <42.85%> (-0.01%) ⬇️
Linux_2 56.27% <100.00%> (-0.01%) ⬇️
Linux_3 37.51% <25.00%> (-0.01%) ⬇️
Linux_4 29.61% <25.00%> (+<0.01%) ⬆️
Windows_1 28.77% <42.85%> (-0.01%) ⬇️
Windows_2 56.22% <100.00%> (-0.01%) ⬇️
Windows_3 37.51% <25.00%> (-0.01%) ⬇️
Windows_4 29.61% <25.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Hailong-am
Copy link
Contributor Author

This is main only, backport to 2.x is not needed as it has been included.

@ruanyl ruanyl merged commit dfc7def into opensearch-project:main Sep 9, 2024
68 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
all-star-contributor Skip-Changelog PRs that are too trivial to warrant a changelog or release notes entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants