Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Fix workspace detail UI bugs #8188

Merged

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Sep 13, 2024

Description

This PR fix a bunch of UI bugs in workspace detail page, here are the list of changes:

  • Update toast message on remove association flow
  • Fix data source connection selected items not clear after canceled
  • Update "Remove data source(s)" to "Remove data association(s)"
  • Update collaborator form group title and description
  • Make input readOnly instead of disabled
  • Reduce the gap between associate button
  • Move form error banner inside tab content
  • Update hr margin in tab content
  • Update gap between tab header and content
  • Add copy tooltip for copy workspace id
  • Update "Owner" to "Owners"
  • Update use case icon in workspace detail page
  • Type workspace name in workspace delete workspace modal
  • Render — when description is empty

Issues Resolved

Screenshot

image
image
image

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version ignore
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Visiting a existing workspace settings page, all the listed UI bugs should be fixed

Changelog

  • fix: [Workspace]Fix workspace detail UI bugs

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

Attention: Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.

Project coverage is 64.03%. Comparing base (18875f7) to head (2e38a09).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
...ts/workspace_form/data_source_connection_table.tsx 94.28% 1 Missing and 1 partial ⚠️
...omponents/workspace_form/workspace_detail_form.tsx 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8188      +/-   ##
==========================================
- Coverage   64.04%   64.03%   -0.02%     
==========================================
  Files        3740     3740              
  Lines       88582    88588       +6     
  Branches    13791    13794       +3     
==========================================
- Hits        56731    56724       -7     
- Misses      31253    31266      +13     
  Partials      598      598              
Flag Coverage Δ
Linux_1 30.05% <94.33%> (+<0.01%) ⬆️
Linux_2 58.79% <ø> (ø)
Linux_3 40.38% <ø> (ø)
Linux_4 31.47% <ø> (ø)
Windows_1 30.06% <94.33%> (-0.02%) ⬇️
Windows_2 58.74% <ø> (ø)
Windows_3 40.39% <ø> (ø)
Windows_4 31.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great fixes and refactor!

@SuZhou-Joe SuZhou-Joe merged commit 096b568 into opensearch-project:main Sep 18, 2024
73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
* Render &mdash; when description is empty

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Type workspace name in workspace delete workspace modal

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update use case icon in workspace detail page

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update Owner to Owners

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Add copy tooltip for copy workspace id

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update gap between tab header and content

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update hr margin in tab content

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Move form error banner inside tab content

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Reduce the gap between associate button

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Make input readOnly instead of disabled

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update collaborator form group title and description

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8188 created/updated

* Reduce delete button size avoid line-height update

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update "Remove data source(s)" to "Remove data association(s)"

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Fix data source connection selected items not clear after canceled

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Update toast message on remove association flow

Signed-off-by: Lin Wang <wonglam@amazon.com>

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 096b568)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 20, 2024
* Render &mdash; when description is empty



* Type workspace name in workspace delete workspace modal



* Update use case icon in workspace detail page



* Update Owner to Owners



* Add copy tooltip for copy workspace id



* Update gap between tab header and content



* Update hr margin in tab content



* Move form error banner inside tab content



* Reduce the gap between associate button



* Make input readOnly instead of disabled



* Update collaborator form group title and description



* Changeset file for PR #8188 created/updated

* Reduce delete button size avoid line-height update



* Update "Remove data source(s)" to "Remove data association(s)"



* Fix data source connection selected items not clear after canceled



* Update toast message on remove association flow



---------



(cherry picked from commit 096b568)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants