Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Fix ppl commands #8199

Merged
merged 4 commits into from
Sep 19, 2024
Merged

[Bug] Fix ppl commands #8199

merged 4 commits into from
Sep 19, 2024

Conversation

sumukhswamy
Copy link
Contributor

Description

Piped functions in ppl were not running

Issues Resolved

https://app.asana.com/0/1208080319527398/1208216692717508/f

Screenshot

image

Testing the changes

Changelog

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@sumukhswamy
Fix ppl commands
c9eda6d 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

ℹ️ Manual Changeset Creation Reminder

Please ensure manual commit for changeset file 8199.yml under folder changelogs/fragments to complete this PR.

If you want to use the available OpenSearch Changeset Bot App to avoid manual creation of changeset file you can install it in your forked repository following this link.

For more information about formatting of changeset files, please visit OpenSearch Auto Changeset and Release Notes Tool.

@codecov Codecov
Copy link

codecov bot commented Sep 14, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.05%. Comparing base (cea39b8) to head (9389ba2).
Report is 17 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8199   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files        3741     3741           
  Lines       88635    88635           
  Branches    13804    13804           
=======================================
  Hits        56775    56775           
  Misses      31262    31262           
  Partials      598      598
Flag Coverage Δ
Linux_1 30.07% <ø> (ø)
Linux_2 58.83% <ø> (ø)
Linux_3 40.37% <ø> (ø)
Linux_4 31.46% <ø> (ø)
Windows_1 30.08% <ø> (ø)
Windows_2 58.78% <ø> (ø)
Windows_3 40.37% <ø> (ø)
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ashwin-pc
ashwin-pc previously approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry approved in haste

ashwin-pc
ashwin-pc reviewed Sep 17, 2024
View reviewed changes
Copy link
Member

@ashwin-pc ashwin-pc left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we doing this? We should not be modifying the query on the client side. Why do we need to do this?

@ashwin-pc ashwin-pc dismissed their stale review September 17, 2024 02:58

Approved in haste

@sumukhswamy
Copy link
Contributor Author

The way the backend is handling the queries are such where the timestamp appears first and then the pipe with the other half of the query.

joshuali925
joshuali925 approved these changes Sep 17, 2024
View reviewed changes
src/plugins/query_enhancements/public/search/ppl_search_interceptor.ts
const timeFilter = this.getTimeFilter(dataset.timeFieldName);
return { ...query, query: query.query + timeFilter };
return { ...query, query: baseQuery + timeFilter + afterPipe };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good if this logic has tests, maybe later as this class doesn't have unit tests yet

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sumukhswamy
Copy link
Contributor Author

Dont have permissions to merge this in

@ashwin-pc ashwin-pc merged commit 6ebc1e3 into opensearch-project:main Sep 19, 2024
66 of 67 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 19, 2024
@github-actions
Fix ppl commands (#8199)
db99919 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
(cherry picked from commit 6ebc1e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 19, 2024
Merged
sejli pushed a commit that referenced this pull request Sep 20, 2024
@opensearch-trigger-bot @github-actions
Fix ppl commands (#8199) (#8239)
9807a2c 
(cherry picked from commit 6ebc1e3)

Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 21, 2024
@github-actions
Fix ppl commands (#8199)
9452a8c 
Signed-off-by: sumukhswamy <sumukhhs@amazon.com>
(cherry picked from commit 6ebc1e3)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 21, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc left review comments

@kavilla kavilla kavilla approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.x backport 2.17 discover for discover reinvent failed changeset first-time-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sumukhswamy @kavilla @ashwin-pc @joshuali925 @sejli