Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix the tooltip display misalignment issue #8202

Closed

Conversation

yubonluo
Copy link
Contributor

@yubonluo yubonluo commented Sep 14, 2024

Description

There will be a display issue of content misalignming when showing tooltip on the page.
image
image

Before showing tooltip:
image
After showing tooltip:
image

Issues Resolved

Screenshot

After fixing the issue:
image
image
image

Testing the changes

Changelog

  • fix: [Bug] Fix the tooltip display misalignment issue

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: yubonluo <yubonluo@amazon.com>
@yubonluo
Copy link
Contributor Author

yubonluo commented Sep 14, 2024

Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.05%. Comparing base (b826df8) to head (6af6a46).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8202   +/-   ##
=======================================
  Coverage   64.05%   64.05%           
=======================================
  Files        3741     3741           
  Lines       88629    88629           
  Branches    13801    13801           
=======================================
  Hits        56771    56771           
  Misses      31260    31260           
  Partials      598      598           
Flag Coverage Δ
Linux_1 30.06% <ø> (ø)
Linux_2 58.83% <ø> (ø)
Linux_3 40.37% <ø> (ø)
Linux_4 31.46% <ø> (ø)
Windows_1 30.08% <ø> (ø)
Windows_2 58.78% <ø> (ø)
Windows_3 40.37% <ø> (ø)
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ruanyl ruanyl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@ruanyl
Copy link
Member

ruanyl commented Sep 18, 2024

@AMoo-Miki Would be nice if you could take a look at this PR :), the style change was introduced in your previous commit 0a3bcd8

@ruanyl
Copy link
Member

ruanyl commented Sep 19, 2024

The same fix was merged in https://github.com/opensearch-project/OpenSearch-Dashboards/pull/8223/files

@ruanyl
Copy link
Member

ruanyl commented Sep 19, 2024

Closing this one as fixed in #8223

@ruanyl ruanyl closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants