Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workspace]Add tooltip in workspace settings top delete button #8213

Conversation

wanglam
Copy link
Contributor

@wanglam wanglam commented Sep 18, 2024

Description

This PR is for adding "Delete workspace" tooltip for workspace settings top right delete button.

Issues Resolved

Screenshot

Screen.Recording.2024-09-18.at.11.48.31.mov

Testing the changes

  • Clone branch code and run yarn osd bootstrap --single-version ignore
  • Add below configs in config/opensearch_dashboards.yml
savedObjects.permission.enabled: true
workspace.enabled: true
uiSettings:
  overrides:
    'home:useNewHomePage': true
opensearchDashboards.dashboardAdmin.users: ['admin']
  • Run yarn start --no-base-path
  • Create a workspace and then will redirect to the workspace use case overview page
  • Open the left navigation, click "Workspace settings"
  • Hover on top right Delete button, the tooltip should be displayed

Changelog

  • feat: [Workspace]Add tooltip in workspace settings top delete button

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

Signed-off-by: Lin Wang <wonglam@amazon.com>
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.05%. Comparing base (b826df8) to head (ece3265).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8213      +/-   ##
==========================================
- Coverage   64.05%   64.05%   -0.01%     
==========================================
  Files        3741     3741              
  Lines       88629    88629              
  Branches    13801    13801              
==========================================
- Hits        56771    56770       -1     
- Misses      31260    31261       +1     
  Partials      598      598              
Flag Coverage Δ
Linux_1 30.06% <ø> (ø)
Linux_2 58.83% <ø> (ø)
Linux_3 40.37% <ø> (-0.01%) ⬇️
Linux_4 31.46% <ø> (ø)
Windows_1 30.08% <ø> (ø)
Windows_2 58.78% <ø> (ø)
Windows_3 40.37% <ø> (ø)
Windows_4 31.46% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SuZhou-Joe SuZhou-Joe merged commit cea39b8 into opensearch-project:main Sep 18, 2024
74 of 75 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 18, 2024
* Add tooltip in workspace detail top delete button

Signed-off-by: Lin Wang <wonglam@amazon.com>

* Changeset file for PR #8213 created/updated

---------

Signed-off-by: Lin Wang <wonglam@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit cea39b8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
ruanyl pushed a commit that referenced this pull request Sep 20, 2024
#8221)

* Add tooltip in workspace detail top delete button



* Changeset file for PR #8213 created/updated

---------



(cherry picked from commit cea39b8)

Signed-off-by: Lin Wang <wonglam@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants