Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Temporary fix for a bug with Chrome 129 when handling mask-image #8274

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Temporary fix for a bug with Chrome 129 when handling mask-image #8274

merged 2 commits into from
Sep 20, 2024
+30 −0

Conversation

AMoo-Miki
Copy link
Collaborator

@AMoo-Miki AMoo-Miki commented Sep 20, 2024 •
edited
Loading

Description

Temporary fix for Chrome's problem with rendering mask images.

OUI provides the mask-image which Chrome 129 fails to render correctly.
It is not known if or when Chrome will fix this. Since almost all of these classes
are applied to elements with scrollbars where their content contained, containing the
paint is a safe solution.

Pulled from opensearch-project/oui#1414

Issues Resolved

Fixes #8250

Testing the changes

Follow steps on #8250

Changelog

  • fix: Add a temporary fix for a bug with Chrome 129 when handling mask-image

Check List

  • All tests pass
    • yarn test:jest
    • yarn test:jest_integration
  • New functionality includes testing.
  • New functionality has been documented.
  • Update CHANGELOG.md
  • Commits are signed per the DCO using --signoff

@github-actions GitHub Actions
Copy link
Contributor

❌ Changelog Entry Missing Hyphen

Changelog entries must begin with a hyphen (-).

@codecov Codecov
Copy link

codecov bot commented Sep 20, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.12%. Comparing base (27ba36c) to head (d05b1eb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8274   +/-   ##
=======================================
  Coverage   64.11%   64.12%           
=======================================
  Files        3744     3744           
  Lines       88862    88862           
  Branches    13852    13852           
=======================================
+ Hits        56975    56979    +4     
+ Misses      31273    31269    -4     
  Partials      614      614
Flag Coverage Δ
Linux_1 30.07% <ø> (ø)
Linux_2 58.85% <ø> (ø)
Linux_3 40.36% <ø> (+<0.01%) ⬆️
Linux_4 31.56% <ø> (?)
Windows_1 30.08% <ø> (ø)
Windows_2 58.80% <ø> (ø)
Windows_3 40.36% <ø> (ø)
Windows_4 31.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

joshuali925
joshuali925 approved these changes Sep 20, 2024
View reviewed changes
Copy link
Member

@joshuali925 joshuali925 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting problem..

@ashwin-pc ashwin-pc merged commit cd6a909 into opensearch-project:main Sep 20, 2024
72 of 73 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2024
@github-actions @opensearch-changeset-bot
Temporary fix for a bug with Chrome 129 when handling mask-image (#8274)
cfdb019 
* Temporary fix for a bug with Chrome 129 when handling mask-image

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8274 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit cd6a909)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 20, 2024
Open
opensearch-trigger-bot bot pushed a commit that referenced this pull request Sep 20, 2024
@github-actions @opensearch-changeset-bot
Temporary fix for a bug with Chrome 129 when handling mask-image (#8274)
4279f05 
* Temporary fix for a bug with Chrome 129 when handling mask-image

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR #8274 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit cd6a909)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Sep 20, 2024
Merged
amsiglan pushed a commit to amsiglan/OpenSearch-Dashboards that referenced this pull request Sep 20, 2024
@AMoo-Miki @opensearch-changeset-bot @amsiglan
Temporary fix for a bug with Chrome 129 when handling mask-image (ope…
cfd00de 
…nsearch-project#8274)

* Temporary fix for a bug with Chrome 129 when handling mask-image

Signed-off-by: Miki <miki@amazon.com>

* Changeset file for PR opensearch-project#8274 created/updated

---------

Signed-off-by: Miki <miki@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
abbyhu2000 pushed a commit that referenced this pull request Sep 21, 2024
@opensearch-trigger-bot @github-actions @opensearch-changeset-bot
Temporary fix for a bug with Chrome 129 when handling mask-image (#8274…
cb366fa 
…) (#8278)

* Temporary fix for a bug with Chrome 129 when handling mask-image



* Changeset file for PR #8274 created/updated

---------



(cherry picked from commit cd6a909)

Signed-off-by: Miki <miki@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kavilla kavilla kavilla approved these changes

@joshuali925 joshuali925 joshuali925 approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@ashwin-pc ashwin-pc Awaiting requested review from ashwin-pc ashwin-pc is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@sejli sejli Awaiting requested review from sejli sejli is a code owner

@huyaboo huyaboo Awaiting requested review from huyaboo huyaboo is a code owner

Assignees
No one assigned
Labels
2.17.1 backport 2.x backport 2.17 distinguished-contributor
Projects
None yet
Milestone
No milestone
4 participants
@AMoo-Miki @kavilla @joshuali925 @ashwin-pc