Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.17] [discover] Clean up enhanced search API #8284

Merged
merged 1 commit into from
Sep 21, 2024
Merged

[Backport 2.17] [discover] Clean up enhanced search API #8284

merged 1 commit into from
Sep 21, 2024
+42 −226

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport 6296b4e from #8226.

@github-actions @opensearch-changeset-bot
[discover] Clean up enhanced search API (#8226)
ecdbb00 
* Clean up enhanced search API

* Deletes the connections service.
* Removes dataframe object being passed into request
* Deletes unused APIs

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>

* Changeset file for PR #8226 created/updated

---------

Signed-off-by: Kawika Avilla <kavilla414@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit 6296b4e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot added discover for discover reinvent autocut Skip the changelog verification check on backports failed backport distinguished-contributor discover-next 2.17.1 labels Sep 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

@codecov Codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 30.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 64.02%. Comparing base (a513a8c) to head (ecdbb00).
Report is 2 commits behind head on 2.17.

Files with missing lines Patch % Lines
...gins/query_enhancements/public/datasets/s3_type.ts 33.33% 5 Missing and 1 partial ⚠️
...on/search/search_source/fetch/get_search_params.ts 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             2.17    #8284      +/-   ##
==========================================
+ Coverage   64.00%   64.02%   +0.02%     
==========================================
  Files        3738     3737       -1     
  Lines       88796    88765      -31     
  Branches    13815    13815              
==========================================
  Hits        56832    56832              
+ Misses      31367    31335      -32     
- Partials      597      598       +1
Flag Coverage Δ
Linux_1 29.95% <0.00%> (+<0.01%) ⬆️
Linux_2 58.95% <0.00%> (+<0.01%) ⬆️
Linux_3 40.30% <0.00%> (+<0.01%) ⬆️
Linux_4 31.48% <30.00%> (+0.01%) ⬆️
Windows_1 29.97% <0.00%> (+<0.01%) ⬆️
Windows_2 58.90% <0.00%> (+<0.01%) ⬆️
Windows_3 40.30% <0.00%> (+<0.01%) ⬆️
Windows_4 31.48% <30.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ashwin-pc ashwin-pc merged commit fba9d40 into 2.17 Sep 21, 2024
69 of 72 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashwin-pc ashwin-pc ashwin-pc approved these changes

@sejli sejli sejli approved these changes

@ananzh ananzh Awaiting requested review from ananzh ananzh is a code owner

@kavilla kavilla Awaiting requested review from kavilla kavilla is a code owner

@AMoo-Miki AMoo-Miki Awaiting requested review from AMoo-Miki AMoo-Miki is a code owner

@joshuarrrr joshuarrrr Awaiting requested review from joshuarrrr joshuarrrr is a code owner

@abbyhu2000 abbyhu2000 Awaiting requested review from abbyhu2000 abbyhu2000 is a code owner

@zengyan-amazon zengyan-amazon Awaiting requested review from zengyan-amazon zengyan-amazon is a code owner

@zhongnansu zhongnansu Awaiting requested review from zhongnansu zhongnansu is a code owner

@manasvinibs manasvinibs Awaiting requested review from manasvinibs manasvinibs is a code owner

@ZilongX ZilongX Awaiting requested review from ZilongX ZilongX is a code owner

@Flyingliuhub Flyingliuhub Awaiting requested review from Flyingliuhub Flyingliuhub is a code owner

@curq curq Awaiting requested review from curq curq is a code owner

@bandinib-amzn bandinib-amzn Awaiting requested review from bandinib-amzn bandinib-amzn is a code owner

@SuZhou-Joe SuZhou-Joe Awaiting requested review from SuZhou-Joe SuZhou-Joe is a code owner

@ruanyl ruanyl Awaiting requested review from ruanyl ruanyl is a code owner

@BionIT BionIT Awaiting requested review from BionIT BionIT is a code owner

@xinruiba xinruiba Awaiting requested review from xinruiba xinruiba is a code owner

@zhyuanqi zhyuanqi Awaiting requested review from zhyuanqi zhyuanqi is a code owner

@mengweieric mengweieric Awaiting requested review from mengweieric mengweieric is a code owner

@LDrago27 LDrago27 Awaiting requested review from LDrago27 LDrago27 is a code owner

@virajsanghvi virajsanghvi Awaiting requested review from virajsanghvi virajsanghvi is a code owner

@joshuali925 joshuali925 Awaiting requested review from joshuali925 joshuali925 is a code owner

Assignees
No one assigned
Labels
2.17.1 autocut Skip the changelog verification check on backports discover for discover reinvent discover-next distinguished-contributor failed changeset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ashwin-pc @sejli