Addressing comments on PR.

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>
opensearch-project · Aug 5, 2022 · 20467b6 · 20467b6
1 parent 8b82ff6
commit 20467b6
Showing 1 changed file with 4 additions and 13 deletions.
diff --git a/server/src/test/java/org/opensearch/index/engine/ReadOnlyEngineTests.java b/server/src/test/java/org/opensearch/index/engine/ReadOnlyEngineTests.java
@@ -58,7 +58,7 @@ public class ReadOnlyEngineTests extends EngineTestCase {
 
     public void testReadOnlyEngine() throws Exception {
         IOUtils.close(engine, store);
-        Engine readOnlyEngine = null;
+        ReadOnlyEngine readOnlyEngine = null;
         final AtomicLong globalCheckpoint = new AtomicLong(SequenceNumbers.NO_OPS_PERFORMED);
         try (Store store = createStore()) {
             EngineConfig config = config(defaultSettings, store, createTempDir(), newMergePolicy(), null, null, globalCheckpoint::get);
@@ -107,10 +107,7 @@ public void testReadOnlyEngine() throws Exception {
                 lastSeqNoStats = engine.getSeqNoStats(globalCheckpoint.get());
                 lastDocIds = getDocIds(engine, true);
                 assertThat(readOnlyEngine.getPersistedLocalCheckpoint(), equalTo(lastSeqNoStats.getLocalCheckpoint()));
-                assertThat(
-                    ((ReadOnlyEngine) readOnlyEngine).getProcessedLocalCheckpoint(),
-                    equalTo(readOnlyEngine.getPersistedLocalCheckpoint())
-                );
+                assertThat((readOnlyEngine).getProcessedLocalCheckpoint(), equalTo(readOnlyEngine.getPersistedLocalCheckpoint()));
                 assertThat(readOnlyEngine.getSeqNoStats(globalCheckpoint.get()).getMaxSeqNo(), equalTo(lastSeqNoStats.getMaxSeqNo()));
                 assertThat(getDocIds(readOnlyEngine, false), equalTo(lastDocIds));
                 for (int i = 0; i < numDocs; i++) {
@@ -135,10 +132,7 @@ public void testReadOnlyEngine() throws Exception {
                 IOUtils.close(external, internal);
                 // the locked down engine should still point to the previous commit
                 assertThat(readOnlyEngine.getPersistedLocalCheckpoint(), equalTo(lastSeqNoStats.getLocalCheckpoint()));
-                assertThat(
-                    ((ReadOnlyEngine) readOnlyEngine).getProcessedLocalCheckpoint(),
-                    equalTo(readOnlyEngine.getPersistedLocalCheckpoint())
-                );
+                assertThat((readOnlyEngine).getProcessedLocalCheckpoint(), equalTo(readOnlyEngine.getPersistedLocalCheckpoint()));
                 assertThat(readOnlyEngine.getSeqNoStats(globalCheckpoint.get()).getMaxSeqNo(), equalTo(lastSeqNoStats.getMaxSeqNo()));
                 assertThat(getDocIds(readOnlyEngine, false), equalTo(lastDocIds));
                 try (Engine.GetResult getResult = readOnlyEngine.get(get, readOnlyEngine::acquireSearcher)) {
@@ -152,10 +146,7 @@ public void testReadOnlyEngine() throws Exception {
                     .recoverFromTranslog(translogHandler, recoveringEngine.getProcessedLocalCheckpoint(), Long.MAX_VALUE);
                 // the locked down engine should still point to the previous commit
                 assertThat(readOnlyEngine.getPersistedLocalCheckpoint(), equalTo(lastSeqNoStats.getLocalCheckpoint()));
-                assertThat(
-                    ((ReadOnlyEngine) readOnlyEngine).getProcessedLocalCheckpoint(),
-                    equalTo(readOnlyEngine.getPersistedLocalCheckpoint())
-                );
+                assertThat((readOnlyEngine).getProcessedLocalCheckpoint(), equalTo(readOnlyEngine.getPersistedLocalCheckpoint()));
                 assertThat(readOnlyEngine.getSeqNoStats(globalCheckpoint.get()).getMaxSeqNo(), equalTo(lastSeqNoStats.getMaxSeqNo()));
                 assertThat(getDocIds(readOnlyEngine, false), equalTo(lastDocIds));
             }