Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] org.opensearch.indices.IndicesRequestCacheIT.testStaleKeysCleanupWithLowThreshold {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}} is flaky #13540

Closed
reta opened this issue May 4, 2024 · 8 comments
Assignees
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search:Performance

Comments

@reta
Copy link
Collaborator

reta commented May 4, 2024

Describe the bug

The test case org.opensearch.indices.IndicesRequestCacheIT.testStaleKeysCleanupWithLowThreshold {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}} is flaky:

java.lang.AssertionError
	at __randomizedtesting.SeedInfo.seed([F5E7FF9737DAEC01:67C83A7F84D4002A]:0)
	at org.junit.Assert.fail(Assert.java:87)
	at org.junit.Assert.assertTrue(Assert.java:42)
	at org.junit.Assert.assertTrue(Assert.java:53)
	at org.opensearch.indices.IndicesRequestCacheIT.testStaleKeysCleanupWithLowThreshold(IndicesRequestCacheIT.java:782)
	at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103)
	at java.base/java.lang.reflect.Method.invoke(Method.java:580)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$9.evaluate(RandomizedRunner.java:974)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$10.evaluate(RandomizedRunner.java:988)
	at org.opensearch.test.OpenSearchTestClusterRule$1.evaluate(OpenSearchTestClusterRule.java:369)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at org.apache.lucene.tests.util.TestRuleSetupTeardownChained$1.evaluate(TestRuleSetupTeardownChained.java:48)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleThreadAndTestName$1.evaluate(TestRuleThreadAndTestName.java:45)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl.forkTimeoutingTask(ThreadLeakControl.java:817)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$3.evaluate(ThreadLeakControl.java:468)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.runSingleTest(RandomizedRunner.java:947)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$5.evaluate(RandomizedRunner.java:832)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$6.evaluate(RandomizedRunner.java:883)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$7.evaluate(RandomizedRunner.java:894)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleStoreClassName$1.evaluate(TestRuleStoreClassName.java:38)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.NoShadowingOrOverridesOnMethodsRule$1.evaluate(NoShadowingOrOverridesOnMethodsRule.java:40)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at org.apache.lucene.tests.util.TestRuleAssertionsRequired$1.evaluate(TestRuleAssertionsRequired.java:53)
	at org.apache.lucene.tests.util.AbstractBeforeAfterRule$1.evaluate(AbstractBeforeAfterRule.java:43)
	at org.apache.lucene.tests.util.TestRuleMarkFailure$1.evaluate(TestRuleMarkFailure.java:44)
	at org.apache.lucene.tests.util.TestRuleIgnoreAfterMaxFailures$1.evaluate(TestRuleIgnoreAfterMaxFailures.java:60)
	at org.apache.lucene.tests.util.TestRuleIgnoreTestSuites$1.evaluate(TestRuleIgnoreTestSuites.java:47)
	at org.junit.rules.RunRules.evaluate(RunRules.java:20)
	at com.carrotsearch.randomizedtesting.rules.StatementAdapter.evaluate(StatementAdapter.java:36)
	at com.carrotsearch.randomizedtesting.ThreadLeakControl$StatementRunner.run(ThreadLeakControl.java:368)
	at java.base/java.lang.Thread.run(Thread.java:1583)

Related component

Storage:Remote

To Reproduce

./gradlew ':server:internalClusterTest' --tests "org.opensearch.indices.IndicesRequestCacheIT" -Dtests.method="testStaleKeysCleanupWithLowThreshold {p0={"opensearch.experimental.feature.pluggable.caching.enabled":"true"}}" -Dtests.seed=F5E7FF9737DAEC01 -Dtests.security.manager=true

Expected behavior

The test must always pass

Additional Details

Plugins
Standard

Screenshots
If applicable, add screenshots to help explain your problem.

Host/Environment (please complete the following information):

  • CI

Additional context
Add any other context about the problem here.

@reta reta added bug Something isn't working untriaged flaky-test Random test failure that succeeds on second run labels May 4, 2024
@reta
Copy link
Collaborator Author

reta commented May 4, 2024

@sohami @sgup432 @kiranprakash154 it might be caused by #12941

@kiranprakash154
Copy link
Contributor

Thanks @reta, I will take a look.

@kiranprakash154
Copy link
Contributor

kiranprakash154 commented May 7, 2024

There might be another issue -
The suite also seems to be timing out as observed in this PR - #13553 on build

Test abandoned because suite timeout was reached.

@reta
Copy link
Collaborator Author

reta commented May 7, 2024

It might but not in this case (see please description)

@andrross andrross removed the untriaged label May 8, 2024
@andrross
Copy link
Member

andrross commented May 8, 2024

[Triage - attendees 1 2 3 4]
@reta Thanks for filing

@kiranprakash154
Copy link
Contributor

kiranprakash154 commented May 8, 2024

I agree this is a 2 fold problem, my comment was intended for that, but i'll make my previous comment more obvious.
Thanks for pointing out.

@kiranprakash154
Copy link
Contributor

I created a seperate issue to solve the problem of the test suite timing out - #13734

andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:
- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross added a commit to andrross/OpenSearch that referenced this issue Jun 7, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross added a commit that referenced this issue Jun 7, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600

Signed-off-by: Andrew Ross <andrross@amazon.com>
opensearch-trigger-bot bot pushed a commit that referenced this issue Jun 7, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600

Signed-off-by: Andrew Ross <andrross@amazon.com>
(cherry picked from commit fbe048f)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
andrross pushed a commit that referenced this issue Jun 10, 2024
These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- #11374
- #12308
- #13540
- #13503
- #13711
- #13949
- #13437
- #13600


(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
parv0201 pushed a commit to parv0201/OpenSearch that referenced this issue Jun 10, 2024
@reta
Copy link
Collaborator Author

reta commented Jun 19, 2024

Closing in favour of #14288

@reta reta closed this as completed Jun 19, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this issue Jul 24, 2024
…opensearch-project#14082)

These are very frequent offenders and are causing a lot of pain in CI.

Related issues:

- opensearch-project#11374
- opensearch-project#12308
- opensearch-project#13540
- opensearch-project#13503
- opensearch-project#13711
- opensearch-project#13949
- opensearch-project#13437
- opensearch-project#13600

(cherry picked from commit fbe048f)

Signed-off-by: Andrew Ross <andrross@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this issue Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flaky-test Random test failure that succeeds on second run Search:Performance
Projects
Status: Done
Status: ✅ Done
Development

No branches or pull requests

3 participants