Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Mute flaky concurrent segment search tests pending fixes (#10437) #11050

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

jed326
Copy link
Collaborator

@jed326 jed326 commented Nov 1, 2023

Description

Backport 9cb4f9d from #10437.

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Compatibility status:

Checks if related components are compatible with change 66260ae

Incompatible components

Incompatible components: [https://github.com/opensearch-project/performance-analyzer.git]

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/neural-search.git]

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Collaborator Author

jed326 commented Nov 1, 2023

Copy link
Contributor

github-actions bot commented Nov 1, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 2, 2023

Gradle Check (Jenkins) Run Completed with:

@peternied
Copy link
Member

Good news - PR for review to resolve it #11068 - want to take a look?

@peternied peternied changed the title Mute flaky concurrent segment search tests pending fixes (#10437) [Backport 2.x] Mute flaky concurrent segment search tests pending fixes (#10437) Nov 2, 2023
@peternied peternied self-assigned this Nov 2, 2023
@jed326 jed326 marked this pull request as ready for review November 2, 2023 23:34
Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

@peternied
Copy link
Member

@jed326 Can you merge or rebase from 2.x I'm seeing unrelated tests failures that were resolved such as #10955

…project#10437)

* DiversifiedSamplerIT.testNestedSamples
* QueryProfilePhaseTests.testMaxScore
* QueryProfilePhaseTests.testCollapseQuerySearchResults
* HighlighterSearchIT.testHighlightQueryRewriteDatesWithNow
* FieldCapabilitiesIT.testWithIndexFilter
* QueryProfilePhaseTests.testDisableTopScoreCollection

Signed-off-by: Jay Deng <jayd0104@gmail.com>
@jed326
Copy link
Collaborator Author

jed326 commented Nov 3, 2023

@peternied just rebased. Thanks!

Copy link

codecov bot commented Nov 3, 2023

Codecov Report

Merging #11050 (66260ae) into 2.x (e297b21) will increase coverage by 0.13%.
Report is 4 commits behind head on 2.x.
The diff coverage is 69.53%.

@@             Coverage Diff              @@
##                2.x   #11050      +/-   ##
============================================
+ Coverage     70.86%   71.00%   +0.13%     
- Complexity    58864    58903      +39     
============================================
  Files          4850     4851       +1     
  Lines        277900   278030     +130     
  Branches      40735    40766      +31     
============================================
+ Hits         196937   197417     +480     
+ Misses        64238    63822     -416     
- Partials      16725    16791      +66     
Files Coverage Δ
...g/opensearch/identity/shiro/ShiroTokenManager.java 93.33% <100.00%> (+28.21%) ⬆️
...a/org/opensearch/extensions/ExtensionsManager.java 52.14% <100.00%> (+1.20%) ⬆️
...g/opensearch/extensions/NoopExtensionsManager.java 42.85% <100.00%> (ø)
...rch/extensions/rest/RestActionsRequestHandler.java 100.00% <100.00%> (ø)
...org/opensearch/identity/noop/NoopTokenManager.java 100.00% <100.00%> (+33.33%) ⬆️
...rg/opensearch/identity/tokens/BearerAuthToken.java 100.00% <100.00%> (ø)
...g/opensearch/identity/tokens/OnBehalfOfClaims.java 87.50% <87.50%> (ø)
server/src/main/java/org/opensearch/node/Node.java 85.22% <0.00%> (ø)
...ensearch/extensions/rest/ExtensionRestRequest.java 71.59% <33.33%> (-1.67%) ⬇️
...org/opensearch/identity/tokens/BasicAuthToken.java 80.00% <60.00%> (-7.50%) ⬇️
... and 5 more

... and 452 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

@jed326
Copy link
Collaborator Author

jed326 commented Nov 3, 2023

Copy link
Contributor

github-actions bot commented Nov 3, 2023

Gradle Check (Jenkins) Run Completed with:

Copy link
Contributor

github-actions bot commented Nov 4, 2023

Gradle Check (Jenkins) Run Completed with:

@peternied peternied merged commit 74d1bb1 into opensearch-project:2.x Nov 6, 2023
15 of 16 checks passed
@jed326 jed326 deleted the backport-10437 branch August 7, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants