Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SuggestSearch.testSkipDuplicates by forceing refresh when indexing its test documents #11068

Merged
merged 3 commits into from
Nov 7, 2023
Merged

Fix SuggestSearch.testSkipDuplicates by forceing refresh when indexing its test documents #11068

merged 3 commits into from
Nov 7, 2023

Commits on Nov 2, 2023

  1. Fix SuggestionSearch skipDuplicates flaky test 

    During the testSkipDuplicates its possible that not all documents were
fully indexed by the time the search with suggestions was created,
updating the indexing operations to refresh the index before
returning.

As its possible that did not fix the issue, I've added logging around
the test case to capture the state when the error occurred that can
assist in future troubleshooting.
    @peternied
    peternied committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9f18436 View commit details
    Browse the repository at this point in the history

  2. Spotless + changelog entry 

    Signed-off-by: Peter Nied <petern@amazon.com>
    @peternied
    peternied committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    540b540 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Merge branch 'main' into duplication-suggestions-flak 

    Signed-off-by: Peter Nied <petern@amazon.com>
    @peternied
    peternied committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5d128ee View commit details
    Browse the repository at this point in the history