Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable concurrent search path for composite aggregations. #12375

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Disable concurrent search path for composite aggregations. #12375

merged 1 commit into from
Feb 20, 2024

Conversation

sohami
Copy link
Collaborator

@sohami sohami commented Feb 19, 2024 •
edited
Loading

Description

Disable concurrent segment search for requests containing composite aggregation.

Related Issues

#12331

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
      - [ ] Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
    - [X] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
    - [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@sohami sohami self-assigned this Feb 19, 2024
@sohami sohami added backport 2.x Backport to 2.x branch backport 2.12 Backport to 2.12 branch labels Feb 19, 2024
@sohami
Copy link
Collaborator Author

sohami commented Feb 20, 2024

❌ Gradle check result for b86c0ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Known issue: #9191

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b86c0ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Copy link
Collaborator Author

sohami commented Feb 20, 2024

❌ Gradle check result for b86c0ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Known issues:

[org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction](https://build.ci.opensearch.org/job/gradle-check/33941/testReport/junit/org.opensearch.cluster.coordination/AwarenessAttributeDecommissionIT/testConcurrentDecommissionAction/)
[org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction](https://build.ci.opensearch.org/job/gradle-check/33941/testReport/junit/org.opensearch.cluster.coordination/AwarenessAttributeDecommissionIT/testConcurrentDecommissionAction_2/)
[org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction](https://build.ci.opensearch.org/job/gradle-check/33941/testReport/junit/org.opensearch.cluster.coordination/AwarenessAttributeDecommissionIT/testConcurrentDecommissionAction_3/)
[org.opensearch.cluster.coordination.AwarenessAttributeDecommissionIT.testConcurrentDecommissionAction](https://build.ci.opensearch.org/job/gradle-check/33941/testReport/junit/org.opensearch.cluster.coordination/AwarenessAttributeDecommissionIT/testConcurrentDecommissionAction_4/)
[org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing](https://build.ci.opensearch.org/job/gradle-check/33941/testReport/junit/org.opensearch.remotestore/RemoteIndexPrimaryRelocationIT/testPrimaryRelocationWhileIndexing/)
[org.opensearch.snapshots.DeleteSnapshotIT.testDeleteMultipleShallowCopySnapshotsCase1](https://build.ci.opensearch.org/job/gradle-check/33941/testReport/junit/org.opensearch.snapshots/DeleteSnapshotIT/testDeleteMultipleShallowCopySnapshotsCase1/)

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b86c0ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@andrross
Copy link
Member

❌ Gradle check result for b86c0ad: FAILURE

#10755

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b86c0ad: TIMEOUT

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b86c0ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@sohami
Disable concurrent search path for composite aggregations. For more d…
f1a493f 
…etails see: opensearch-project#12331

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
@sohami
Copy link
Collaborator Author

sohami commented Feb 20, 2024

rebased to latest main

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b86c0ad: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for f1a493f: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9b7541f) 71.44% compared to head (f1a493f) 71.37%.
Report is 1 commits behind head on main.

Files Patch % Lines
.../bucket/composite/CompositeAggregationFactory.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #12375      +/-   ##
============================================
- Coverage     71.44%   71.37%   -0.07%     
+ Complexity    59839    59810      -29     
============================================
  Files          4960     4960              
  Lines        281166   281166              
  Branches      40861    40861              
============================================
- Hits         200875   200692     -183     
- Misses        63614    63758     +144     
- Partials      16677    16716      +39

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@reta reta self-requested a review February 20, 2024 22:40
@reta reta merged commit 74589ef into opensearch-project:main Feb 20, 2024
32 of 33 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 20, 2024
@github-actions
Disable concurrent search path for composite aggregations. For more d…
50abe8f 
…etails see: #12331 (#12375)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
(cherry picked from commit 74589ef)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Feb 20, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Feb 21, 2024
Merged
sohami pushed a commit that referenced this pull request Feb 21, 2024
@opensearch-trigger-bot @github-actions
Disable concurrent search path for composite aggregations. For more d…
fc18c3c 
…etails see: #12331 (#12375) (#12400)

(cherry picked from commit 74589ef)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
This was referenced Feb 29, 2024
Closed
Open
Closed
Closed
peteralfonsi pushed a commit to peteralfonsi/OpenSearch that referenced this pull request Mar 1, 2024
@sohami
Disable concurrent search path for composite aggregations. For more d…
1de6134 
…etails see: opensearch-project#12331 (opensearch-project#12375)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
amkhar pushed a commit to amkhar/OpenSearch that referenced this pull request Mar 12, 2024
@sohami
Disable concurrent search path for composite aggregations. For more d…
9d7274d 
…etails see: opensearch-project#12331 (opensearch-project#12375)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Signed-off-by: Aman Khare <amkhar@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@sohami @rayshrey
Disable concurrent search path for composite aggregations. For more d…
ef387b9 
…etails see: opensearch-project#12331 (opensearch-project#12375)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
This was referenced Mar 27, 2024
Closed
Closed
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@sohami @shiv0408
Disable concurrent search path for composite aggregations. For more d…
7bf0378 
…etails see: opensearch-project#12331 (opensearch-project#12375)

Signed-off-by: Sorabh Hamirwasia <sohami.apache@gmail.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reta reta reta approved these changes

@andrross andrross andrross approved these changes

@ticheng-aws ticheng-aws ticheng-aws approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@sohami sohami

Labels
backport 2.x Backport to 2.x branch Search:Performance Search:Query Capabilities skip-changelog
Projects
Concurrent Search
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sohami @andrross @reta @ticheng-aws