Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Fix] Fix issue where wrong shard blob files are picked up for del… #12701

Merged
merged 1 commit into from
Mar 16, 2024

Conversation

harishbhakuni
Copy link
Contributor

@harishbhakuni harishbhakuni commented Mar 16, 2024

…etion.

Description

We recently fixed a Avoid String out of bound error during snapshot delete in #12337, where another bug got introduced due to which it is picking wrong shard blobs during deletion.

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…etion.

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Copy link
Contributor

Compatibility status:

Checks if related components are compatible with change 49b13b0

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/performance-analyzer.git, https://github.com/opensearch-project/sql.git]

Copy link
Contributor

✅ Gradle check result for 49b13b0: SUCCESS

Copy link

codecov bot commented Mar 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 71.52%. Comparing base (b15cb0c) to head (49b13b0).
Report is 40 commits behind head on main.

Files Patch % Lines
...ch/repositories/blobstore/BlobStoreRepository.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main   #12701      +/-   ##
============================================
+ Coverage     71.42%   71.52%   +0.10%     
- Complexity    59978    60160     +182     
============================================
  Files          4985     4992       +7     
  Lines        282275   282725     +450     
  Branches      40946    41003      +57     
============================================
+ Hits         201603   202219     +616     
+ Misses        63999    63737     -262     
- Partials      16673    16769      +96     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gbbafna gbbafna merged commit 48004ee into opensearch-project:main Mar 16, 2024
99 of 143 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Mar 16, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 16, 2024
…p for shallow snapshot deletion. (#12701)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
(cherry picked from commit 48004ee)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
gbbafna pushed a commit that referenced this pull request Mar 18, 2024
…p for shallow snapshot deletion. (#12701) (#12703)

(cherry picked from commit 48004ee)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
…p for shallow snapshot deletion. (opensearch-project#12701)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
@yigithub yigithub added the v2.13.0 Issues and PRs related to version 2.13.0 label Mar 18, 2024
@yigithub yigithub assigned yigithub and harishbhakuni and unassigned yigithub Mar 18, 2024
ruai0511 pushed a commit to ruai0511/OpenSearch that referenced this pull request Mar 19, 2024
…p for shallow snapshot deletion. (opensearch-project#12701)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
…p for shallow snapshot deletion. (opensearch-project#12701)

Signed-off-by: Harish Bhakuni <hbhakuni@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch skip-changelog v2.13.0 Issues and PRs related to version 2.13.0
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants