Abstract AsyncShardFetch cache to allow restructuring for other cachi…

[amkhar]

…ng strategies (#12441)

• Abstract AsyncShardFetch cache to allow restructuring for batch mode

Signed-off-by: Aman Khare amkhar@amazon.com
(cherry picked from commit b15cb0c)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

• New functionality includes testing.
  • All tests pass
• New functionality has been documented.
  • New functionality has javadoc added
• Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
• Commits are signed per the DCO using --signoff
  - [ ] Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  - [ ] Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[github-actions]

Compatibility status:

Checks if related components are compatible with change 3e7b028

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/flow-framework.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/performance-analyzer.git]

[github-actions]

❕ Gradle check result for 3e7b028: UNSTABLE

• TEST FAILURES:

      1 org.opensearch.repositories.azure.AzureBlobStoreRepositoryTests.testSnapshotAndRestore
      1 org.opensearch.remotestore.RemoteStoreStatsIT.testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

[codecov]

Codecov Report

Attention: Patch coverage is 81.33333% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 71.07%. Comparing base (0dd892c) to head (3e7b028).
Report is 47 commits behind head on 2.x.

Files	Patch %	Lines
...a/org/opensearch/gateway/AsyncShardFetchCache.java	78.33%	10 Missing and 16 partials ⚠️
...n/java/org/opensearch/gateway/AsyncShardFetch.java	93.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                2.x   #12761      +/-   ##
============================================
- Coverage     71.28%   71.07%   -0.21%     
+ Complexity    60145    60127      -18     
============================================
  Files          4957     4968      +11     
  Lines        282799   283520     +721     
  Branches      41409    41489      +80     
============================================
- Hits         201591   201526      -65     
- Misses        64189    64958     +769     
- Partials      17019    17036      +17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[amkhar]

testSnapshotAndRestore

Flaky tests : #11493

testNonZeroPrimaryStatsOnNewlyCreatedIndexWithZeroDocs

#10983