[Backport 2.x] Fix flaky test SegmentReplicationTargetServiceTests#testShardAlreadyReplicating #13265
Conversation
…eplicating (opensearch-project#13248) This test is flaky because it is incorrectly passing a checkpoint with a higher primary term on the second invocation. This will cancel the first replication and start another. The test sometimes passes because it is only asserting on processLatestReceivedCheckpoint. If the cancellation quickly completes before attempting second replication event the test will fail, otherwise it will pass. Fixed this test by ensuring the pterm is the same, but the checkpoint is ahead. Also added assertion that replication is not started with the exact ahead checkpoint instead of only processLatestReivedCheckpoint. Tests already exist for ahead primary term "testShardAlreadyReplicating_HigherPrimaryTermReceived". Signed-off-by: Marc Handalian <marc.handalian@gmail.com> (cherry picked from commit 1fcb79d)
mch2
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
❌ Gradle check result for 15c5baf: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
504 Gateway Time-out |
|
❌ Gradle check result for 15c5baf: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #13265 +/- ##
============================================
- Coverage 71.28% 71.03% -0.26%
- Complexity 60145 60528 +383
============================================
Files 4957 5004 +47
Lines 282799 285354 +2555
Branches 41409 41716 +307
============================================
+ Hits 201591 202693 +1102
- Misses 64189 65526 +1337
- Partials 17019 17135 +116 ☔ View full report in Codecov by Sentry. |
Manual backport of #13248 to 2.x.
This PR includes two additional changes to bring this file in sync with main.
59a62e7 updated localNode definition on 2.x but not on main.
e942483 unmuted this test on main but was not backported.
The rest is the same.