Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add version details in remote index path file with code enhancements #13386

Merged
merged 4 commits into from
Apr 29, 2024
Merged

Add version details in remote index path file with code enhancements #13386

merged 4 commits into from
Apr 29, 2024

Conversation

ashking94
Copy link
Member

Description

This is a follow up PR after #13150. In this PR, we are doing the following things -

  1. Refactored the IndexMetadataUploadListener to support a more generic hook for index metadata upload.
  2. Add index metadata version and file version in the filename of the remote index path file.

Related Issues

Resolves #13302

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request Storage:Remote v2.14.0 labels Apr 25, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 522e527: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 1fb08f0: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Add version details in remote index path file with code enhancements
bd3ab77 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for bd3ab77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Copy link
Member Author

❌ Gradle check result for bd3ab77: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky tests - #10006 and #10152.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for cacc26d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Copy link
Member Author

❌ Gradle check result for cacc26d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - #12197

@ashking94
Merge remote-tracking branch 'upstream/main' into 13302
e92892c 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@rramachand21
Copy link
Member

Triage: Updated assignee and project board fields.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for e92892c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Copy link
Member Author

❌ Gradle check result for e92892c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky test - #12197

@ashking94 ashking94 mentioned this pull request Apr 27, 2024
Merged
6 tasks
@ashking94 ashking94 mentioned this pull request Apr 29, 2024
Closed
13 tasks
@ashking94
Incoporate PR review feedback
c0bcbb7 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@ashking94
Merge remote-tracking branch 'upstream/main' into 13302
de1f70f 
Signed-off-by: Ashish Singh <ssashish@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for de1f70f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@ashking94
Copy link
Member Author

❌ Gradle check result for de1f70f: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Flaky tests - #12651 and #13437.

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for de1f70f: SUCCESS

@gbbafna gbbafna merged commit 2dc3f74 into opensearch-project:main Apr 29, 2024
26 checks passed
@gbbafna gbbafna added the backport 2.x Backport to 2.x branch label Apr 29, 2024
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 29, 2024
@github-actions
Add version details in remote index path file with code enhancements (#…
64a095e 
…13386)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
(cherry picked from commit 2dc3f74)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 29, 2024
Merged
gbbafna pushed a commit that referenced this pull request Apr 29, 2024
@opensearch-trigger-bot @github-actions
Add version details in remote index path file with code enhancements (#…
dfcb120 
…13386) (#13444)

(cherry picked from commit 2dc3f74)

Signed-off-by: Ashish Singh <ssashish@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@BrewTestBot BrewTestBot mentioned this pull request May 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gbbafna gbbafna gbbafna approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees

@ashking94 ashking94

Labels
backport 2.x Backport to 2.x branch enhancement Enhancement or improvement to existing feature or request skip-changelog Storage:Remote v2.14.0
Projects
Storage Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Upload remote index path for migrating indexes from docrep to remote
3 participants
@ashking94 @rramachand21 @gbbafna