[Backport 2.14] Fix negative requestStats memory_size issue (#13553) #13591
Conversation
This solves the bug where RequestStats memory_size metric was going negative in certain scenarios as reported in the issue. It turns out that the issue occurs when an indexShard is deleted and then reallocated on the same node. So whenever stale entries from older shard are deleted, those are accounted for the new shard which has the same shardId. --------- Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
sgup432
requested review from
anasalkouz,
andrross,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
dreamer-89,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami,
tlfeng and
VachaShah
as code owners
|
Seems like all the changelog entries were removed recently. Maybe add a skip changelog tag in that case? |
The change log for a release branch is the release notes. You should add this to the 2.14 release notes instead. (Actually, it should be removed from the |
|
❌ Gradle check result for 8c74e4a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
@msfroh Added in the release notes. I thought it was already picked, my bad. |
|
❌ Gradle check result for 9d76468: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
sgup432
force-pushed
the
backport/backport-13553-to-2.14
branch
from
9d76468
to
b1a7551
Compare
|
❌ Gradle check result for b1a7551: null Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Signed-off-by: Sagar Upadhyaya <sagar.upadhyaya.121@gmail.com>
sgup432
force-pushed
the
backport/backport-13553-to-2.14
branch
from
b1a7551
to
67169b0
Compare
|
❕ Gradle check result for 67169b0: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.14 #13591 +/- ##
=======================================
Coverage ? 71.32%
Complexity ? 61212
=======================================
Files ? 5027
Lines ? 287733
Branches ? 42049
=======================================
Hits ? 205222
Misses ? 65196
Partials ? 17315 ☔ View full report in Codecov by Sentry. |
|
@sgup432 Can you fix up the changelog and release notes on the 2.x and main branches for this change now? |
Description
Backports #13553
Related Issues
Check List
[ ] Public documentation issue/PR createdBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.