Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency com.azure:azure-identity to 1.13.0, com.microsoft.azure:msal4j to 1.15.1, com.microsoft.azure:msal4j-persistence-extension to 1.3.0 #14506

Merged
merged 5 commits into from
Jun 22, 2024

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Jun 22, 2024

Description

Update dependency com.azure:azure-identity to 1.12.2

Update dependency com.microsoft.azure:msal4j to 1.15.1

Update dependency com.microsoft.azure:msal4j-persistence-extension to 1.13.0

Replacement for the mend PR which did not update SHAs or CHANGELOG: #14494

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
Copy link
Contributor

❌ Gradle check result for 34263cb: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

❌ Gradle check result for 918a49d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Update dependency com.azure:azure-identity to v1.12.2 Update dependency com.azure:azure-identity to 1.12.2, com.microsoft.azure:msal4j to 1.15.1 Jun 22, 2024
Copy link
Contributor

❌ Gradle check result for 918a49d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@reta
Copy link
Collaborator

reta commented Jun 22, 2024

Thanks @cwperks , for some reasons Mend completely wiped out my changes 4ed2b98 from its pull request

Copy link
Contributor

❕ Gradle check result for d458c68: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.75%. Comparing base (b15cb0c) to head (376043b).
Report is 471 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #14506      +/-   ##
============================================
+ Coverage     71.42%   71.75%   +0.33%     
- Complexity    59978    62164    +2186     
============================================
  Files          4985     5125     +140     
  Lines        282275   292343   +10068     
  Branches      40946    42242    +1296     
============================================
+ Hits         201603   209778    +8175     
- Misses        63999    65296    +1297     
- Partials      16673    17269     +596     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Craig Perkins <cwperx@amazon.com>
@cwperks cwperks changed the title Update dependency com.azure:azure-identity to 1.12.2, com.microsoft.azure:msal4j to 1.15.1 Update dependency com.azure:azure-identity to 1.13.0, com.microsoft.azure:msal4j to 1.15.1, com.microsoft.azure:msal4j-persistence-extension to 1.3.0 Jun 22, 2024
@cwperks
Copy link
Member Author

cwperks commented Jun 22, 2024

Thanks for the review @reta! Mend must have overridden your commit.

Copy link
Contributor

✅ Gradle check result for 376043b: SUCCESS

@reta reta merged commit 47feca7 into opensearch-project:main Jun 22, 2024
33 of 35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jun 22, 2024
…zure:msal4j to 1.15.1, com.microsoft.azure:msal4j-persistence-extension to 1.3.0 (#14506)

* Update dependency com.azure:azure-identity to v1.12.2

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Bump msal4j from 1.14.3 to 1.15.1

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Address review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
(cherry picked from commit 47feca7)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta pushed a commit that referenced this pull request Jun 22, 2024
…zure:msal4j to 1.15.1, com.microsoft.azure:msal4j-persistence-extension to 1.3.0 (#14506) (#14508)

* Update dependency com.azure:azure-identity to v1.12.2



* Add to CHANGELOG



* Bump msal4j from 1.14.3 to 1.15.1



* Add to CHANGELOG



* Address review feedback



---------


(cherry picked from commit 47feca7)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request Jul 12, 2024
…zure:msal4j to 1.15.1, com.microsoft.azure:msal4j-persistence-extension to 1.3.0 (opensearch-project#14506)

* Update dependency com.azure:azure-identity to v1.12.2

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Bump msal4j from 1.14.3 to 1.15.1

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Address review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
…zure:msal4j to 1.15.1, com.microsoft.azure:msal4j-persistence-extension to 1.3.0 (opensearch-project#14506) (opensearch-project#14508)

* Update dependency com.azure:azure-identity to v1.12.2

* Add to CHANGELOG

* Bump msal4j from 1.14.3 to 1.15.1

* Add to CHANGELOG

* Address review feedback

---------

(cherry picked from commit 47feca7)

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: kkewwei <kkewwei@163.com>
wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request Aug 22, 2024
…zure:msal4j to 1.15.1, com.microsoft.azure:msal4j-persistence-extension to 1.3.0 (opensearch-project#14506)

* Update dependency com.azure:azure-identity to v1.12.2

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Bump msal4j from 1.14.3 to 1.15.1

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Add to CHANGELOG

Signed-off-by: Craig Perkins <cwperx@amazon.com>

* Address review feedback

Signed-off-by: Craig Perkins <cwperx@amazon.com>

---------

Signed-off-by: Craig Perkins <cwperx@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants