Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Segment Replication stats throwing NPE when shards are unassigned or are in delayed allocation phase #14580

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Segment Replication stats throwing NPE when shards are unassigned or are in delayed allocation phase #14580

wants to merge 11 commits into from

Conversation

rampreeth
Copy link

@rampreeth rampreeth commented Jun 27, 2024 •
edited
Loading

Segment Replication stats throwing NPE when shards are unassigned or are in delayed allocation phase

Description

[Describe what this change achieves]

Related Issues

Resolves #11945

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added bug Something isn't working good first issue Good for newcomers low hanging fruit Storage Issues and PRs relating to data and metadata storage labels Jun 27, 2024
@rampreeth rampreeth mentioned this pull request Jun 27, 2024
Open
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for ec6091b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rampreeth-ethiraj @rampreeth
Segment Replication stats throwing NPE when shards are unassigned or …
0603be3 
…are in delayed allocation phase

Signed-off-by: Rampreeth Ethiraj <ethirajrampreeth@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for aca2198: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 0603be3: SUCCESS

@rampreeth
Copy link
Author

Looks like some other tests are failing, seems to be related to my change, will fix that

Are you able to repro this locally? isPrimaryRelocation is only invoked when fetching stats for segrep, i'd be surprised if this is related to those failures?

Yes, I'm able to repro it locally. The other tests are failing due to addition of an unassigned shard in the routing table.

@rampreeth
Fix tests
2677ac5 
Signed-off-by: Rampreeth Ethiraj <ethirajrampreeth@gmail.com>
@rampreeth
Merge branch 'main' into issue/11945
b7577d7 
Signed-off-by: Rampreeth Ethiraj <ethirajrampreeth@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 2677ac5: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b7577d7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rampreeth rampreeth closed this Jul 16, 2024
@rampreeth rampreeth reopened this Jul 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for b7577d7: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rampreeth
Fix formatting
070b695 
Signed-off-by: Rampreeth Ethiraj <ethirajrampreeth@gmail.com>
@rampreeth
Copy link
Author

Hi @mch2 , please review this again. Tests seem to be running fine now.

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 070b695: SUCCESS

@rampreeth
Merge branch 'main' into issue/11945
476e64d 
Signed-off-by: Rampreeth Ethiraj <ethirajrampreeth@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 476e64d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rampreeth
Merge branch 'main' into issue/11945
0db942d 
Signed-off-by: Rampreeth Ethiraj <ethirajrampreeth@gmail.com>
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 0db942d: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@rampreeth rampreeth requested a review from mch2 July 18, 2024 16:26
@rampreeth
Merge branch 'main' into issue/11945
a6bbe1a 
Signed-off-by: Rampreeth Ethiraj <ethirajrampreeth@gmail.com>
@rampreeth
Copy link
Author

Hi @mch2 , gentle reminder to review this

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for a6bbe1a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@rampreeth rampreeth closed this Jul 22, 2024
@rampreeth rampreeth reopened this Jul 22, 2024
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for a6bbe1a: SUCCESS

mch2
mch2 reviewed Jul 22, 2024
View reviewed changes
server/src/test/java/org/opensearch/index/seqno/ReplicationTrackerTestCase.java
@@ -104,13 +104,22 @@ static String nodeIdFromAllocationId(final AllocationId allocationId) {
}

static IndexShardRoutingTable routingTable(final Set<AllocationId> initializingIds, final AllocationId primaryId) {
return routingTable(initializingIds, Collections.singleton(primaryId), primaryId);
return routingTable(initializingIds, Collections.singleton(primaryId), primaryId, false);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should be able to test this without adding this flag and updating these base methods. We can have an individual test create the routing table and add the routing with null aId. That should avoid the need to change unrelated tests like PeerRecoveryRetentionLease as well. Please see

OpenSearch/server/src/test/java/org/opensearch/index/seqno/ReplicationTrackerTests.java

Line 1936 in 8def8cb

final IndexShardRoutingTable.Builder builder = new IndexShardRoutingTable.Builder(shardId);
from testSegmentReplicationCheckpointForRelocatingPrimary.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will make that change

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Aug 22, 2024
@shourya035
Copy link
Member

@rampreeth Let us know if you are blocked on this. I see that @mch2 has left some comments.

This was referenced Sep 11, 2024
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mch2 mch2 mch2 approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@peternied peternied Awaiting requested review from peternied

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch bug Something isn't working good first issue Good for newcomers low hanging fruit Storage Issues and PRs relating to data and metadata storage
Projects
Storage Project Board
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] Segment Replication stats throwing NPE when shards are unassigned or are in delayed allocation phase
5 participants
@rampreeth @peternied @mch2 @shourya035 @rampreeth-ethiraj