Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip zone awareness when auto-expand set to all #14619

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Skip zone awareness when auto-expand set to all #14619

wants to merge 2 commits into from
+110 −0

Conversation

amberzsy
Copy link

@amberzsy amberzsy commented Jul 2, 2024 •
edited
Loading

Description

Skip zone/host awareness when auto-expand set to "all"

Related Issues

Resolves #14603

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions github-actions bot added enhancement Enhancement or improvement to existing feature or request ShardManagement:Resiliency labels Jul 2, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

❌ Gradle check result for bf7bf9d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

✅ Gradle check result for 53500b4: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 2, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.01%. Comparing base (c709400) to head (ee1ac62).
Report is 6 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #14619      +/-   ##
============================================
+ Coverage     71.93%   72.01%   +0.07%     
- Complexity    64374    64401      +27     
============================================
  Files          5277     5278       +1     
  Lines        300828   300879      +51     
  Branches      43474    43479       +5     
============================================
+ Hits         216411   216682     +271     
+ Misses        66725    66410     -315     
- Partials      17692    17787      +95

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 3, 2024

❌ Gradle check result for bd2877b: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@amberzsy amberzsy force-pushed the skip_awareness_with_auto_expand_all branch from 6a8e7ce to bd2877b Compare July 14, 2024 05:17
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 7a9b36f: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 6a8e7ce: SUCCESS

@amberzsy amberzsy force-pushed the skip_awareness_with_auto_expand_all branch from bd2877b to 0eda973 Compare July 14, 2024 06:10
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 0eda973: SUCCESS

@opensearch-trigger-bot
Copy link
Contributor

This PR is stalled because it has been open for 30 days with no activity.

@opensearch-trigger-bot opensearch-trigger-bot bot added stalled Issues that have stalled and removed stalled Issues that have stalled labels Aug 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for 0999efa: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 9, 2024

❌ Gradle check result for fed1096: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

This was referenced Sep 9, 2024
Open
Open
@amberzsy amberzsy force-pushed the skip_awareness_with_auto_expand_all branch from fed1096 to 075ba07 Compare September 12, 2024 07:33
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 075ba07: SUCCESS

andrross
andrross approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@andrross andrross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @vikasvb90 can you take another look as well?

@andrross
Copy link
Member

@amberzsy Can you add a changelog entry? Also, I think the commit message and PR title should be fixed since this is only skipping zone awareness and not host.

@amberzsy amberzsy changed the title Skip zone/host awareness when auto-expand set to all Skip zone awareness when auto-expand set to all Sep 13, 2024
@amberzsy amberzsy force-pushed the skip_awareness_with_auto_expand_all branch from 075ba07 to d25ca2a Compare September 13, 2024 04:40
@zshuyi @amberzsy
Skip zone awareness when auto-expand set to all
a27c4e3 
Signed-off-by: amberzsy <xxamber998@gmail.com>
@amberzsy amberzsy force-pushed the skip_awareness_with_auto_expand_all branch 3 times, most recently from 74ae2bc to a27c4e3 Compare September 13, 2024 05:06
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for d25ca2a: SUCCESS

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 74ae2bc: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.indices.replication.SegmentReplicationIT.testReplicaAlreadyAtCheckpoint

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for a27c4e3: SUCCESS

@opensearch-ci-bot opensearch-ci-bot mentioned this pull request Sep 12, 2024
Open
@amberzsy amberzsy force-pushed the skip_awareness_with_auto_expand_all branch from d25ca2a to 1636d3c Compare September 13, 2024 06:43
Bukhtawar
Bukhtawar reviewed Sep 14, 2024
View reviewed changes
Copy link
Collaborator

@Bukhtawar Bukhtawar left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@amberzsy
Merge branch 'main' into skip_awareness_with_auto_expand_all
ee1ac62 
Signed-off-by: Shuyi Z <159193473+amberzsy@users.noreply.github.com>
@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for ee1ac62: SUCCESS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikasvb90 vikasvb90 vikasvb90 requested changes

@andrross andrross andrross approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

@jainankitk jainankitk Awaiting requested review from jainankitk jainankitk is a code owner

@linuxpi linuxpi Awaiting requested review from linuxpi linuxpi is a code owner

Assignees
No one assigned
Labels
enhancement Enhancement or improvement to existing feature or request ShardManagement:Resiliency
Projects
Shard Management Project Board
Status: 👀 In review
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request] Skip zone/host awareness when auto-expand set to "all"
5 participants
@amberzsy @andrross @Bukhtawar @vikasvb90 @zshuyi