Star Tree Min and Max Value Aggregators #14625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
sarthakaggarwal97
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14625 +/- ##
============================================
- Coverage 71.84% 71.83% -0.01%
+ Complexity 62911 62906 -5
============================================
Files 5176 5180 +4
Lines 295133 295150 +17
Branches 42676 42680 +4
============================================
- Hits 212029 212014 -15
+ Misses 65709 65677 -32
- Partials 17395 17459 +64 ☔ View full report in Codecov by Sentry. |
sarthakaggarwal97
force-pushed
the
onheap-impl-startree-minmax
branch
from
6af5104
to
f0738ba
Compare
sarthakaggarwal97
force-pushed
the
onheap-impl-startree-minmax
branch
from
f0738ba
to
2d8e244
Compare
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
sarthakaggarwal97
force-pushed
the
onheap-impl-startree-minmax
branch
from
406c6d6
to
03dc1e3
Compare
sarthakaggarwal97
force-pushed
the
onheap-impl-startree-minmax
branch
2 times, most recently
from
41697e6
to
ae84daa
Compare
|
❌ Gradle check result for 41697e6: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 03dc1e3: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Bukhtawar
reviewed
Aug 7, 2024
...va/org/opensearch/index/compositeindex/datacube/startree/aggregators/SumValueAggregator.java
Outdated
Show resolved
Hide resolved
sarthakaggarwal97
force-pushed
the
onheap-impl-startree-minmax
branch
from
ae84daa
to
8e6a232
Compare
|
❕ Gradle check result for 8e6a232: UNSTABLE
Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
ajaymovva
reviewed
Aug 12, 2024
.../org/opensearch/index/compositeindex/datacube/startree/aggregators/CountValueAggregator.java
Show resolved
Hide resolved
sachinpkale
approved these changes
Aug 12, 2024
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 24, 2024
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> (cherry picked from commit e21f6b8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
dbwiddis
pushed a commit
that referenced
this pull request
Aug 24, 2024
--------- (cherry picked from commit e21f6b8) Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
--------- Signed-off-by: Sarthak Aggarwal <sarthagg@amazon.com>
This was referenced Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR introduces the support for Min and Max Value Aggregators for Star Tree.
Built on top of: #14512
Related Issues
Resolves #14624
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.