Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 2.x] Refactor remote routing table service to implement remote objects #14862

Merged
merged 1 commit into from
Jul 22, 2024
Merged

[Backport 2.x] Refactor remote routing table service to implement remote objects #14862

merged 1 commit into from
Jul 22, 2024

Conversation

Arpit-Bandejiya
Copy link
Contributor

@Arpit-Bandejiya Arpit-Bandejiya commented Jul 22, 2024 •
edited
Loading

[Backport 2.x] Refactor remote routing table service to implement remote objects (#14668)

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 3fed8d4: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 314c182: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8e75472: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions GitHub Actions
Copy link
Contributor

❌ Gradle check result for 8e75472: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@Arpit-Bandejiya
[Backport 2.x] Refactor remote-routing-table service inline with remo…
880d71e 
…te state interfaces (opensearch-project#14668)

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@dbwiddis
Copy link
Member

@Arpit-Bandejiya does this need to be backported to 2.16? If so please add that label.

@github-actions GitHub Actions
Copy link
Contributor

✅ Gradle check result for 880d71e: SUCCESS

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2024

Codecov Report

Attention: Patch coverage is 90.90909% with 8 lines in your changes missing coverage. Please review.

Project coverage is 71.58%. Comparing base (feaa115) to head (880d71e).
Report is 2 commits behind head on 2.x.

Files Patch % Lines
...arch/gateway/remote/RemoteClusterStateService.java 73.33% 2 Missing and 2 partials ⚠️
...y/remote/routingtable/RemoteIndexRoutingTable.java 88.88% 1 Missing and 2 partials ⚠️
...eway/remote/model/RemoteRoutingTableBlobStore.java 95.83% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                2.x   #14862      +/-   ##
============================================
+ Coverage     71.45%   71.58%   +0.12%     
- Complexity    62465    62492      +27     
============================================
  Files          5107     5107              
  Lines        293633   293561      -72     
  Branches      42779    42775       -4     
============================================
+ Hits         209821   210132     +311     
+ Misses        66198    65792     -406     
- Partials      17614    17637      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dbwiddis dbwiddis merged commit 61ca56e into opensearch-project:2.x Jul 22, 2024
35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 22, 2024
@github-actions
[Backport 2.x] Refactor remote-routing-table service inline with remo…
08e20a1 
…te state interfaces (#14668) (#14862)

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
(cherry picked from commit 61ca56e)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 22, 2024
Closed
@Arpit-Bandejiya Arpit-Bandejiya mentioned this pull request Jul 23, 2024
Merged
3 tasks
@shailendra0811 shailendra0811 mentioned this pull request Jul 23, 2024
Merged
3 tasks
@dblock dblock mentioned this pull request Jul 23, 2024
Closed
@dblock dblock added the v2.16.0 Issues and PRs related to version 2.16.0 label Jul 23, 2024
kkewwei pushed a commit to kkewwei/OpenSearch that referenced this pull request Jul 24, 2024
@Arpit-Bandejiya @kkewwei
[Backport 2.x] Refactor remote-routing-table service inline with remo…
fa3dcfe 
…te state interfaces (opensearch-project#14668) (opensearch-project#14862)

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
Signed-off-by: kkewwei <kkewwei@163.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbwiddis dbwiddis dbwiddis approved these changes

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@ashking94 ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.16 v2.16.0 Issues and PRs related to version 2.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Arpit-Bandejiya @dbwiddis @dblock