[Backport 2.16] Create listener to refresh search thread resource usage (#14832) #14923
Conversation
deshsidd
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
deshsidd
changed the title
…roject#14832) Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * [bug fix] fix incorrect coordinator node search resource usages Signed-off-by: Chenyang Ji <cyji@amazon.com> * fix bug on serialization when passing task resource usage to coordinator Signed-off-by: Chenyang Ji <cyji@amazon.com> * add more unit tests Signed-off-by: Chenyang Ji <cyji@amazon.com> * remove query insights plugin related code Signed-off-by: Chenyang Ji <cyji@amazon.com> * create per request listener to refresh task resource usage Signed-off-by: Chenyang Ji <cyji@amazon.com> * Make new listener API public Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Add changelog Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Remove wrong files added Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Address review comments Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Build fix Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Make singleton Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Address review comments Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Make sure listener runs before plugin listeners Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Spotless Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> * Minor fix Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> --------- Signed-off-by: Chenyang Ji <cyji@amazon.com> Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com> Signed-off-by: Jay Deng <jayd0104@gmail.com> Co-authored-by: Chenyang Ji <cyji@amazon.com> Co-authored-by: Jay Deng <jayd0104@gmail.com> (cherry picked from commit 8ff3bcc)
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
deshsidd
force-pushed
the
backport/backport-14832-to-2.16-final
branch
from
698477c
to
47628d9
Compare
|
❌ Gradle check result for 698477c: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 4466c0f: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
Signed-off-by: Siddhant Deshmukh <deshsid@amazon.com>
|
❌ Gradle check result for 47628d9: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 20b4370: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 20b4370: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
|
❌ Gradle check result for 20b4370: Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❕ Gradle check result for 20b4370: UNSTABLE Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.16 #14923 +/- ##
============================================
+ Coverage 71.55% 71.65% +0.10%
- Complexity 62652 62724 +72
============================================
Files 5117 5118 +1
Lines 293928 294058 +130
Branches 42833 42848 +15
============================================
+ Hits 210319 210718 +399
+ Misses 65975 65701 -274
- Partials 17634 17639 +5 ☔ View full report in Codecov by Sentry. |
Backporting #14832 to 2.16
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Chenyang Ji cyji@amazon.com
Signed-off-by: Chenyang Ji cyji@amazon.com
Signed-off-by: Chenyang Ji cyji@amazon.com
Signed-off-by: Chenyang Ji cyji@amazon.com
Signed-off-by: Chenyang Ji cyji@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Chenyang Ji cyji@amazon.com
Signed-off-by: Siddhant Deshmukh deshsid@amazon.com
Signed-off-by: Jay Deng jayd0104@gmail.com
Co-authored-by: Chenyang Ji cyji@amazon.com
Co-authored-by: Jay Deng jayd0104@gmail.com
(cherry picked from commit 8ff3bcc)
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.