New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix delete index template failed when the index template matches a data stream but is unused #15080

Merged

reta merged 5 commits into opensearch-project:main from gaobinlong:data_stream

Aug 3, 2024

Collaborator

gaobinlong commented Aug 2, 2024 •

edited

Loading

Description

Index templates without a explicit data_stream attribute cannot be used by data stream actually, but when deleting an ordinary index template which is not used by any data stream, if the index patterns match a data stream, then the delete operation fails with an exception unable to remove composable templates [test] as they are in use by a data streams [test]. This PR fixes the bug and add some test code.

Related Issues

Resolves #9194

Check List

Functionality includes testing.
API changes companion pull request created, if applicable.
Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.


          Fix delete not-using index template failed when the index pattern mat…

7e47732

…ches a data stream

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

gaobinlong requested review from anasalkouz, andrross, ashking94, Bukhtawar, CEHENKLE, dblock, dbwiddis, gbbafna, kotwanikunal, mch2, msfroh, nknize, owaiskazi19, reta, Rishikesh1159, sachinpkale, saratvemulapalli, shwetathareja, sohami and VachaShah as code owners

August 2, 2024 10:27

github-actions bot added :Feature/Datastream bug labels


          modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

gaobinlong added the backport 2.x label

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 7e47732: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 1212877: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 1212877: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Collaborator Author

gaobinlong commented Aug 2, 2024

@reta @dblock @andrross could you help to review this PR, thank you!

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 1212877: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 1212877: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?


          Merge remote-tracking branch 'upstream/main' into data_stream

3dea93d

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 3dea93d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 3dea93d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 3dea93d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

reta reviewed

View reviewed changes

rest-api-spec/src/main/resources/rest-api-spec/test/indices.delete_index_template/10_basic.yml Outdated Show resolved Hide resolved

Contributor

github-actions bot commented Aug 2, 2024

❌ Gradle check result for 3dea93d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?


          Fix version check

1c0bd1c

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

Contributor

github-actions bot commented Aug 3, 2024

❌ Gradle check result for 1c0bd1c: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?


          Merge remote-tracking branch 'upstream/main' into data_stream

f092892

Contributor

github-actions bot commented Aug 3, 2024

❕ Gradle check result for f092892: UNSTABLE

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.88%. Comparing base (48634bd) to head (f092892).
Report is 3 commits behind head on main.

Files	Patch %	Lines
...cluster/metadata/MetadataIndexTemplateService.java	0.00%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #15080      +/-   ##
============================================
+ Coverage     71.82%   71.88%   +0.05%     
- Complexity    62778    62818      +40     
============================================
  Files          5169     5169              
  Lines        294646   294665      +19     
  Branches      42610    42616       +6     
============================================
+ Hits         211644   211834     +190     
+ Misses        65573    65419     -154     
+ Partials      17429    17412      -17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

reta approved these changes

View reviewed changes

reta merged commit a9d09aa into opensearch-project:main

32 of 34 checks passed

opensearch-trigger-bot bot pushed a commit that referenced this pull request


          Fix delete index template failed when the index template matches a da…

b2ca674

…ta stream but is unused (#15080)

* Fix delete not-using index template failed when the index pattern matches a data stream

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix version check

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a9d09aa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

opensearch-trigger-bot bot mentioned this pull request

[Backport 2.x] Fix delete index template failed when the index template matches a data stream but is unused #15098

Merged

reta added a commit that referenced this pull request


          [Backport 2.x] Fix delete index template failed when the index templa…

0df6e9e

…te matches a data stream but is unused (#15098)

* Fix delete index template failed when the index template matches a data stream but is unused (#15080)

* Fix delete not-using index template failed when the index pattern matches a data stream

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix version check

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a9d09aa)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* Update 10_basic.yml to for 2.17.0

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Andriy Redko <andriy.redko@aiven.io>

gaobinlong mentioned this pull request

Fix version check in yml test for the bug fix of delete index template failed #15101

Merged

jed326 mentioned this pull request

Add slice level operation listener methods #15153

Merged

1 task

harshavamsi pushed a commit to harshavamsi/OpenSearch that referenced this pull request


          Fix delete index template failed when the index template matches a da…

debd196

…ta stream but is unused (opensearch-project#15080)

* Fix delete not-using index template failed when the index pattern matches a data stream

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix version check

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

wdongyu pushed a commit to wdongyu/OpenSearch that referenced this pull request


          Fix delete index template failed when the index template matches a da…

…ta stream but is unused (opensearch-project#15080)

* Fix delete not-using index template failed when the index pattern matches a data stream

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix version check

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

opensearch-ci-bot mentioned this pull request

[AUTOCUT] Gradle Check Flaky Test Report for MasterServiceTests #15809

Open

akolarkunnu pushed a commit to akolarkunnu/OpenSearch that referenced this pull request


          Fix delete index template failed when the index template matches a da…

3a27921

…ta stream but is unused (opensearch-project#15080)

* Fix delete not-using index template failed when the index pattern matches a data stream

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* modify change log

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

* Fix version check

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

---------

Signed-off-by: Gao Binlong <gbinlong@amazon.com>

This was referenced Sep 11, 2024

[AUTOCUT] Gradle Check Flaky Test Report for MixedClusterClientYamlTestSuiteIT #14294

Open

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobStoreRepositoryTests #14291

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteStoreStatsIT #14310

Open

[AUTOCUT] Gradle Check Flaky Test Report for SmokeTestMultiNodeClientYamlTestSuiteIT #14408

Open

[AUTOCUT] Gradle Check Flaky Test Report for RemoteSegmentTransferTrackerTests #14325

Open

[AUTOCUT] Gradle Check Flaky Test Report for AzureBlobContainerRetriesTests #14318

Open

BrewTestBot mentioned this pull request

opensearch 2.17.0 Homebrew/homebrew-core#191052

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

reta reta approved these changes

anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

andrross Awaiting requested review from andrross andrross is a code owner

ashking94 Awaiting requested review from ashking94 ashking94 is a code owner

Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

dblock Awaiting requested review from dblock dblock is a code owner

dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

mch2 Awaiting requested review from mch2 mch2 is a code owner

msfroh Awaiting requested review from msfroh msfroh is a code owner

nknize Awaiting requested review from nknize nknize is a code owner

owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

sohami Awaiting requested review from sohami sohami is a code owner

VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Labels

backport 2.x bug :Feature/Datastream v2.17.0 v3.0.0