Fix flaky test in {yaml=ingest/70_bulk} #15172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
gaobinlong
requested review from
anasalkouz,
andrross,
ashking94,
Bukhtawar,
CEHENKLE,
dblock,
dbwiddis,
gbbafna,
kotwanikunal,
mch2,
msfroh,
nknize,
owaiskazi19,
reta,
Rishikesh1159,
sachinpkale,
saratvemulapalli,
shwetathareja,
sohami and
VachaShah
as code owners
|
❌ Gradle check result for 12b64b8: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
reta
approved these changes
Aug 8, 2024
|
Needs #15160 |
|
@gaobinlong could you rebase please? thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15172 +/- ##
============================================
+ Coverage 71.84% 71.88% +0.03%
+ Complexity 62953 62929 -24
============================================
Files 5178 5178
Lines 295204 295204
Branches 42682 42682
============================================
+ Hits 212099 212197 +98
+ Misses 65710 65592 -118
- Partials 17395 17415 +20 ☔ View full report in Codecov by Sentry. |
reta
approved these changes
Aug 9, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Aug 9, 2024
Signed-off-by: Gao Binlong <gbinlong@amazon.com> (cherry picked from commit 8f95735) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
reta
pushed a commit
that referenced
this pull request
Aug 9, 2024
(cherry picked from commit 8f95735) Signed-off-by: Gao Binlong <gbinlong@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
harshavamsi
pushed a commit
to harshavamsi/OpenSearch
that referenced
this pull request
Aug 20, 2024
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
wdongyu
pushed a commit
to wdongyu/OpenSearch
that referenced
this pull request
Aug 22, 2024
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
akolarkunnu
pushed a commit
to akolarkunnu/OpenSearch
that referenced
this pull request
Sep 10, 2024
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to #15162, there's also a flaky test
org.opensearch.ingest.common.IngestCommonClientYamlTestSuiteIT.test {yaml=ingest/70_bulk/Test bulk upsert honors default_pipeline and final_pipeline when the auto-created index matches with the index template}, we need to addallowed_warningsfor it.Related Issues
#15161
Check List
- [ ] Functionality includes testing.
- [ ] API changes companion pull request created, if applicable.
- [ ] Public documentation issue/PR created, if applicable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.