Remove Deprecated SimpleFS #1639
Conversation
nknize
added
v2.0.0
|
✅ Gradle Wrapper Validation success 7077f98aa387e5c66168699bfce2f44557ef9fdd |
|
Can one of the admins verify this patch? |
Lucene 9 removes support for SimpleFS File System format. This PR completely removes SimpleFS support which was deprecated in a previous PR. Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
nknize
force-pushed
the
remove/simpleFS
branch
from
7077f98
to
6f1d95e
Compare
|
✅ Gradle Wrapper Validation success 6f1d95e |
|
✅ Gradle Precommit success 7077f98aa387e5c66168699bfce2f44557ef9fdd |
Signed-off-by: Nicholas Walter Knize <nknize@apache.org>
|
✅ Gradle Wrapper Validation success 811ddc2 |
|
✅ Gradle Precommit success 6f1d95e |
|
✅ Gradle Precommit success 811ddc2 |
|
❌ Gradle Check failure 7077f98aa387e5c66168699bfce2f44557ef9fdd |
| @@ -104,15 +100,8 @@ protected Directory newFSDirectory(Path location, LockFactory lockFactory, Index | |||
| } | |||
| case MMAPFS: | |||
| return setPreload(new MMapDirectory(location, lockFactory), lockFactory, preLoadExtensions); | |||
| // simplefs was removed in Lucene 9; support for enum is maintained for bwc | |||
| case SIMPLEFS: | |||
There was a problem hiding this comment.
Should we throw the exception here that SIMPLEFS is not supported anymore? Or may be, to not break bwc, log a warning that SIMPLEFS is not supported, NIOFS will be used instead?
There was a problem hiding this comment.
Maybe add an assert instead as an invariant?
There was a problem hiding this comment.
It's not needed here since this is for bwc only.
There was a problem hiding this comment.
The deprecation logging is already handled in MetadataUpdateSettingsService
Lucene 9 removes support for SimpleFS File System format. This PR completely
removes SimpleFS support which was deprecated in a previous PR.