Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] [1.x] Attempt to fix o.o.transport.netty4.OpenSearchLoggingHandlerIT fails w/ stack overflow by hardening test expectation patterns in regex patterns #1906

Merged
merged 1 commit into from
Jan 14, 2022
Merged

[Backport] [1.x] Attempt to fix o.o.transport.netty4.OpenSearchLoggingHandlerIT fails w/ stack overflow by hardening test expectation patterns in regex patterns #1906

merged 1 commit into from
Jan 14, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Jan 14, 2022 •
edited
Loading

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Backport of #1900 to 1.x

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 24e6f283283e7616d299b114f90817e82fffc0f3
Log 1923

Reports 1923

@reta
Copy link
Collaborator Author

reta commented Jan 14, 2022 •
edited
Loading

x Gradle Check failure 24e6f28 Log 1923

Reports 1923

org.opensearch.gateway.QuorumGatewayIT > testQuorumRecovery FAILED
    java.lang.AssertionError: timed out waiting for green state
        at __randomizedtesting.SeedInfo.seed([5B60BE42A81D1B47:BE5F82910960CC5C]:0)
        at org.junit.Assert.fail(Assert.java:89)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureColor(OpenSearchIntegTestCase.java:1019)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:958)
        at org.opensearch.test.OpenSearchIntegTestCase.ensureGreen(OpenSearchIntegTestCase.java:947)
        at org.opensearch.gateway.QuorumGatewayIT.testQuorumRecovery(QuorumGatewayIT.java:111)

@reta
Fix o.o.transport.netty4.OpenSearchLoggingHandlerIT stack overflow te…
5d75a52 
…st failure (opensearch-project#1900)

Attempt to fix o.o.transport.netty4.OpenSearchLoggingHandlerIT fails w/ stack overflow by
hardening test expectation patterns in regex patterns

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta mentioned this pull request Jan 14, 2022
Closed
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 5d75a52
Log 1925

Reports 1925

@nknize nknize merged commit 0777672 into opensearch-project:1.x Jan 14, 2022
@reta reta mentioned this pull request Jan 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@reta @opensearch-ci-bot @dblock @nknize