Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Remove] Type mapping end-points from RestMultiSearchTemplateAction #2433

Merged
merged 1 commit into from
Mar 11, 2022

Conversation

dreamer-89
Copy link
Member

Signed-off-by: Suraj Singh surajrider@gmail.com

Description

Type mapping end-points from RestMultiSearchTemplateAction. This change escaped in #2263

Related to #1940

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@dreamer-89 dreamer-89 requested a review from a team as a code owner March 10, 2022 22:01
@opensearch-ci-bot
Copy link
Collaborator

Can one of the admins verify this patch?

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c5141ef5ea6e20f736fc8781b44e3bb44bd93315
Log 3234

Reports 3234

@dreamer-89
Copy link
Member Author

dreamer-89 commented Mar 10, 2022

The failure looks unrelated and cause seems to be a warning on settings index.translog.retention.age

REPRODUCE WITH: ./gradlew ':qa:full-cluster-restart:v1.4.0#oldClusterTest' --tests "org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard" -Dtests.seed=CFDACBBA3F54FD83 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=is -Dtests.timezone=Asia/Almaty -Druntime.java=17

org.opensearch.upgrades.FullClusterRestartIT > testEmptyShard FAILED
    org.opensearch.client.WarningFailureException: method [PUT], host [http://[::1]:33109], URI [/test_empty_shard], status line [HTTP/1.1 200 OK]
    Warnings: [Translog retention settings [index.translog.retention.age] and [index.translog.retention.size] are deprecated and effectively ignored. They will be removed in a future version.]
    {"acknowledged":true,"shards_acknowledged":true,"index":"test_empty_shard"}
        at __randomizedtesting.SeedInfo.seed([CFDACBBA3F54FD83:83A11C62C36DD216]:0)
        at app//org.opensearch.client.RestClient.convertResponse(RestClient.java:346)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:320)
        at app//org.opensearch.client.RestClient.performRequest(RestClient.java:295)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:973)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:956)
        at app//org.opensearch.test.rest.OpenSearchRestTestCase.createIndex(OpenSearchRestTestCase.java:952)
        at app//org.opensearch.upgrades.FullClusterRestartIT.testEmptyShard(FullClusterRestartIT.java:670)

@dreamer-89
Copy link
Member Author

dreamer-89 commented Mar 10, 2022

Spot checked gradle check failures. Few of them are failing for exact same reason as this. Created #2434

This issue already captured in #2359

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c5141ef5ea6e20f736fc8781b44e3bb44bd93315
Log 3237

Reports 3237

@dreamer-89
Copy link
Member Author

Gradle check failing due to same test case mentioned above.

@dreamer-89
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure c5141ef5ea6e20f736fc8781b44e3bb44bd93315
Log 3238

Reports 3238

@dreamer-89
Copy link
Member Author

6.x setting not supported in 2.x
#2359 (comment)

Signed-off-by: Suraj Singh <surajrider@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 06e6f97
Log 3255

Reports 3255

@dreamer-89 dreamer-89 merged commit 6f12fa1 into opensearch-project:main Mar 11, 2022
@dreamer-89 dreamer-89 added v2.0.0 Version 2.0.0 non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues >breaking Identifies a breaking change. Indexing & Search labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking Identifies a breaking change. Indexing & Search non-issue bugs / unexpected behaviors that end up non issues; audit trail simple changes that aren't issues v2.0.0 Version 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants