Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced "master" terminology in Log message #2575

Merged
merged 3 commits into from
Mar 25, 2022

Conversation

owaiskazi19
Copy link
Member

Description

Replace "master" terminology in Log messages.

Issues Resolved

#2539

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@owaiskazi19 owaiskazi19 requested a review from a team as a code owner March 23, 2022 19:27
@owaiskazi19 owaiskazi19 changed the title Replace "master" terminology in Log message Replaced "master" terminology in Log message Mar 23, 2022
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 90737c5
Log 3710

Reports 3710

@owaiskazi19
Copy link
Member Author

#1561

@owaiskazi19
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure 90737c5
Log 3711

Reports 3711

@owaiskazi19
Copy link
Member Author

#1703

@owaiskazi19
Copy link
Member Author

start gradle check

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 90737c5
Log 3714

Reports 3714

Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we skipping the comments as well? I'm seeing the use of master-eligible terminology in comments in AddVotingConfigExclusionsRequest.java, for example (line 57, 69, 78)

Maybe we can clean that here as well?

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 6e752ad
Log 3739

Reports 3739

@owaiskazi19 owaiskazi19 requested a review from nknize March 24, 2022 20:44
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nknize nknize merged commit cc0e66b into opensearch-project:main Mar 25, 2022
@nknize nknize added v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch enhancement Enhancement or improvement to existing feature or request labels Mar 25, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2022
Changed the log message to cluster-manager from master

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
(cherry picked from commit cc0e66b)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 25, 2022
Changed the log message to cluster-manager from master

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
(cherry picked from commit cc0e66b)
nknize pushed a commit that referenced this pull request Mar 25, 2022
Changed the log message to cluster-manager from master

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
(cherry picked from commit cc0e66b)
nknize pushed a commit that referenced this pull request Mar 25, 2022
Changed the log message to cluster-manager from master

Signed-off-by: Owais Kazi <owaiskazi19@gmail.com>
(cherry picked from commit cc0e66b)
@tlfeng tlfeng linked an issue Apr 1, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace "master" terminology in Log message
3 participants