Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make discovered_master field optional on the client to support compat… #2641

Merged
merged 1 commit into from
Mar 29, 2022
Merged

Make discovered_master field optional on the client to support compat… #2641

merged 1 commit into from
Mar 29, 2022

Conversation

mgodwan
Copy link
Member

@mgodwan mgodwan commented Mar 29, 2022

…ibility for opensearch client with odfe

Signed-off-by: Mohit Godwani mgodwan@amazon.com

Description

Make the discovered_master field in ClusterHealthResponse optional

Issues Resolved

#1965

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mgodwan
Make discovered_master field optional on the client to support compat…
a56019a 
…ibility for opensearch client with odfe

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
@mgodwan mgodwan requested a review from a team as a code owner March 29, 2022 13:06
@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success a56019a
Log 3846

Reports 3846

@mgodwan mgodwan mentioned this pull request Mar 29, 2022
Closed
dblock
dblock approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@dblock dblock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc: @tlfeng there might be some master/leader concerns here

@dblock dblock merged commit ec4fe70 into opensearch-project:main Mar 29, 2022
@dblock dblock added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Mar 29, 2022
@dblock
Copy link
Member

dblock commented Mar 29, 2022

Nice work @mgodwan, thank you.

opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 29, 2022
@mgodwan @github-actions
Make discovered_master field optional on the client to support compat…
bdcbd63 
…ibility for opensearch client with odfe (#2641)

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit ec4fe70)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 29, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Mar 29, 2022
@mgodwan @github-actions
Make discovered_master field optional on the client to support compat…
76871a6 
…ibility for opensearch client with odfe (#2641)

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit ec4fe70)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Mar 29, 2022
Merged
@tlfeng
Copy link
Collaborator

tlfeng commented Mar 29, 2022

cc: @tlfeng there might be some master/leader concerns here

@dblock Thanks for your reminding! I will change the variable names in PR #2519

tlfeng pushed a commit that referenced this pull request Apr 6, 2022
@mgodwan
Make discovered_master field optional on the client to support compat…
d61ec42 
…ibility for opensearch client with odfe (#2641)

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit ec4fe70)
Signed-off-by: Tianli Feng <ftianli@amazon.com>
tlfeng pushed a commit that referenced this pull request Apr 6, 2022
@mgodwan
Make discovered_master field optional on the client to support compat…
faafebd 
…ibility for opensearch client with odfe (#2641)

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit ec4fe70)
Signed-off-by: Mohit Godwani <81609427+mgodwan@users.noreply.github.com>
saratvemulapalli pushed a commit that referenced this pull request Apr 7, 2022
@opensearch-trigger-bot @mgodwan
Make discovered_master field optional on the client to support compat…
ce4e45b 
…ibility for opensearch client with odfe (#2641) (#2653)

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit ec4fe70)
Signed-off-by: Mohit Godwani <81609427+mgodwan@users.noreply.github.com>

Co-authored-by: Mohit Godwani <81609427+mgodwan@users.noreply.github.com>
tlfeng pushed a commit that referenced this pull request May 3, 2022
@opensearch-trigger-bot
Make discovered_master field optional on the client to support compat…
47bbe05 
…ibility for opensearch client with odfe (#2641) (#2652)

Signed-off-by: Mohit Godwani <mgodwan@amazon.com>
(cherry picked from commit ec4fe70)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

@kartg kartg kartg approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mgodwan @opensearch-ci-bot @dblock @tlfeng @kartg