Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ThirdPartyAuditTask to check for and list pointless exclusions. #2760

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Update ThirdPartyAuditTask to check for and list pointless exclusions. #2760

merged 1 commit into from
Apr 5, 2022

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Apr 4, 2022

Signed-off-by: Marc Handalian handalm@amazon.com

Description

This change swaps the order of the task to first check for no pointless exclusions.
If not caught first these will be thrown inside of the bogusExcludesCount block that logs a
useless error message.

This has caused a few dependabot PRs to linger with the error message:

"All excluded classes seem to have no issues. This is sometimes an indication that the check silently failed"

After this change it will properly list the pointless exclusions:

> Task :modules:ingest-geoip:thirdPartyAudit
Unnecessary exclusions, following classes are not missing:
   * org.apache.http.HttpEntity
  * org.apache.http.HttpResponse
  * org.apache.http.StatusLine
  * org.apache.http.client.config.RequestConfig
  * org.apache.http.client.config.RequestConfig$Builder
  * org.apache.http.client.methods.CloseableHttpResponse
  * org.apache.http.client.methods.HttpGet
  * org.apache.http.client.utils.URIBuilder
  * org.apache.http.impl.auth.BasicScheme
  * org.apache.http.impl.client.CloseableHttpClient
  * org.apache.http.impl.client.HttpClientBuilder
  * org.apache.http.util.EntityUtils

Issues Resolved

#2736
#2646

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@mch2
Update ThirdPartyAuditTask to check for and list pointless exclusions.
8a14b48 
This change swaps the order of the task to first check for no pointless exclusions.
If not caught first these will be thrown inside of the bogusExcludesCount block that logs a
useless error message.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@mch2 mch2 requested a review from a team as a code owner April 4, 2022 23:49
kartg
kartg approved these changes Apr 5, 2022
View reviewed changes
Copy link
Member

@kartg kartg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 8a14b48
Log 4167

Reports 4167

@nknize nknize added enhancement Enhancement or improvement to existing feature or request Build Libraries & Interfaces v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels Apr 5, 2022
nknize
nknize approved these changes Apr 5, 2022
View reviewed changes
Copy link
Collaborator

@nknize nknize left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

phew! such helpful!

@nknize nknize merged commit 21f9950 into opensearch-project:main Apr 5, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2022
@mch2 @github-actions
Update ThirdPartyAuditTask to check for and list pointless exclusions. (
3f9fd2f 
#2760)

This change swaps the order of the task to first check for no pointless exclusions.
If not caught first these will be thrown inside of the bogusExcludesCount block that logs a
useless error message.

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 21f9950)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 5, 2022
Merged
opensearch-trigger-bot bot pushed a commit that referenced this pull request Apr 5, 2022
@mch2 @github-actions
Update ThirdPartyAuditTask to check for and list pointless exclusions. (
42434c8 
#2760)

This change swaps the order of the task to first check for no pointless exclusions.
If not caught first these will be thrown inside of the bogusExcludesCount block that logs a
useless error message.

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 21f9950)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Apr 5, 2022
Merged
nknize pushed a commit that referenced this pull request Apr 5, 2022
@opensearch-trigger-bot
Update ThirdPartyAuditTask to check for and list pointless exclusions. (
55726d4 
#2760) (#2764)

This change swaps the order of the task to first check for no pointless exclusions.
If not caught first these will be thrown inside of the bogusExcludesCount block that logs a
useless error message.

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 21f9950)
nknize pushed a commit that referenced this pull request Apr 5, 2022
@opensearch-trigger-bot
Update ThirdPartyAuditTask to check for and list pointless exclusions. (
507eb97 
#2760) (#2765)

This change swaps the order of the task to first check for no pointless exclusions.
If not caught first these will be thrown inside of the bogusExcludesCount block that logs a
useless error message.

Signed-off-by: Marc Handalian <handalm@amazon.com>
(cherry picked from commit 21f9950)
@mch2 mch2 deleted the uselesserrormessage branch April 5, 2022 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nknize nknize nknize approved these changes

@kartg kartg kartg approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch Build Libraries & Interfaces enhancement Enhancement or improvement to existing feature or request v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mch2 @opensearch-ci-bot @nknize @kartg