Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing PublishTests tests (running against unclean build folders) #3253

Merged
merged 1 commit into from
May 9, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented May 9, 2022

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Fixing PublishTests tests when running against unclean build folders, which fails with:

org.opensearch.gradle.pluginzip.PublishTests > testZipPublish FAILED
    java.nio.file.FileAlreadyExistsException at PublishTests.java:57

To reproduce, just run 1-2 times:

./gradlew :build-tools:test --rerun-tasks

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta added backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch labels May 9, 2022
@reta reta requested a review from a team as a code owner May 9, 2022 16:05
@reta
Copy link
Collaborator Author

reta commented May 9, 2022

@dblock @prudhvigodithi another one please

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@opensearch-ci-bot
Copy link
Collaborator

❌   Gradle Check failure b36557e1377f0f6f549a170906114719eed1e351
Log 5163

Reports 5163

@opensearch-ci-bot
Copy link
Collaborator

✅   Gradle Check success 00b2c63
Log 5165

Reports 5165

@kartg kartg merged commit e615ac1 into opensearch-project:main May 9, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 9, 2022
)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit e615ac1)
opensearch-trigger-bot bot pushed a commit that referenced this pull request May 9, 2022
)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit e615ac1)
kartg pushed a commit that referenced this pull request May 9, 2022
) (#3256)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit e615ac1)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
kartg pushed a commit that referenced this pull request May 9, 2022
) (#3257)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit e615ac1)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x Backport to 2.x branch backport 2.0 Backport to 2.0 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants