Adding onNewCheckpoint to Start Replication on Replica Shard when Segment Replication is turned on #3540

Rishikesh1159 · 2022-06-08T17:00:56Z

Signed-off-by: Rishikesh1159 rishireddy1159@gmail.com

Description

This PR will allow us to start replication on replica shard when a new checkpoint is received. The logic of replaying new checkpoints and storing Latest received checkpoint which comes under same issue 3110, but will be implemented later in a different PR. Some changes like making SegmentReplicationTargetService class not final and Injecting SegmentReplicationTargetService needs discussion/opinion from other developers, please drop your thoughts on these changes also.

This is a part of the process of merging our feature branch - feature/segment-replication - back into main by re-PRing our changes from the feature branch.
The breakdown of the plan to merge to main is detailed here: #2355
For added context on segment replication - here's the design proposal #2229

Issues Resolved

#3110

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… latestcheckpoint and replaying logic is removed from this commit and will be added in a different PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-08T17:32:55Z

✅ Gradle Check success 8b288d8
Log 5859

Reports 5859

mch2 · 2022-06-09T02:04:59Z

server/src/main/java/org/opensearch/index/engine/Engine.java

@@ -173,7 +173,7 @@ public final EngineConfig config() {
     * Return the latest active SegmentInfos from the engine.
     * @return {@link SegmentInfos}
     */
-    protected abstract SegmentInfos getLatestSegmentInfos();
+    public abstract SegmentInfos getLatestSegmentInfos();


I don't think we need this additional method to fetch SegmentInfos, we already have getSegmentInfosSnapshot on engine. Engine provides a default implementation, so we'll need to override this in NRTReplicationEngine.

Edited - I was wrong here, we still need this function but I don't think it needs to be public - public access to the infos can be through the snapshot method.

mch2 · 2022-06-09T02:10:27Z

server/src/main/java/org/opensearch/indices/recovery/RecoverySettings.java

@@ -159,6 +160,7 @@ public class RecoverySettings {

    private volatile ByteSizeValue chunkSize = DEFAULT_CHUNK_SIZE;

+    @Inject


I don't think we need these Injects for SegmentReplicationTargetService, we can bind that class similar to PeerRecoverySourceService in Node.java. We can create a SegmentReplicationSourceFactory there too and avoid injecting it.

b.bind(SegmentReplicationTargetService.class) .toInstance(new SegmentReplicationTargetService(transportService, indicesService, recoverySettings, new SegmentReplicationSourceFactory(...)));

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

mch2 · 2022-06-09T02:16:35Z

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

+     */
+    private boolean shouldProcessCheckpoint(ReplicationCheckpoint requestCheckpoint, IndexShard indexshard) {
+        if (indexshard.getState().equals(IndexShardState.STARTED) == false) {
+            logger.debug("Ignore - shard is not started {}", indexshard.getState());


nit - Can we be a bit more descriptive in these logs "Ignoring new replication checkpoint - ..."
I think these can also be trace logs?

mch2 · 2022-06-09T02:18:56Z

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

+            return false;
+        }
+        ReplicationCheckpoint localCheckpoint = indexshard.getLatestReplicationCheckpoint();
+        logger.debug("Local Checkpoint {}", indexshard.getLatestReplicationCheckpoint());


nit - I don't think we need to log this here, you are already logging the localCheckpoint below if validation fails.

mch2 · 2022-06-09T02:22:55Z

server/src/main/java/org/opensearch/index/shard/IndexShard.java

     */
-    public ReplicationCheckpoint getLatestReplicationCheckpoint() {
-        return new ReplicationCheckpoint(shardId, 0, 0, 0, 0);
+    public IndexShardState getState() {


I think this method is unnecessary we already have indexShard.state()?

Got it. Will remove this in next commit

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-09T17:59:15Z

❌ Gradle Check failure 02c1be3
Log 5872

Reports 5872

opensearch-ci-bot · 2022-06-09T18:18:23Z

✅ Gradle Check success 45f8026
Log 5874

Reports 5874

Bukhtawar · 2022-06-13T14:28:07Z

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

+        logger.trace("Checkpoint received {}", () -> requestCheckpoint);
+        if (shouldProcessCheckpoint(requestCheckpoint, indexShard)) {
+            logger.trace("Processing new checkpoint {}", requestCheckpoint);
+            startReplication(requestCheckpoint, indexShard, new SegmentReplicationListener() {
+                @Override
+                public void onReplicationDone(SegmentReplicationState state) {
+                    logger.trace("Replication complete to {}", indexShard.getLatestReplicationCheckpoint());
+                }
+
+                @Override
+                public void onReplicationFailure(SegmentReplicationState state, OpenSearchException e, boolean sendShardFailure) {
+                    if (sendShardFailure == true) {
+                        indexShard.failShard("replication failure", e);
+                    }
+                }
+            });
+
+        }


Lets remove trace logging if thats not needed add error logging on shard failure?

Bukhtawar · 2022-06-13T14:29:40Z

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

+     * @return true if checkpoint should be processed
+     */
+    private boolean shouldProcessCheckpoint(ReplicationCheckpoint requestCheckpoint, IndexShard indexShard) {
+        if (indexShard.state().equals(IndexShardState.STARTED) == false) {


For my understanding what happens to a shard in RECOVERING state?

We will take care of RECOVERING state logic in our next PR. Shards in RECOVERING state will never receive these new checkpoints. We'll be updating the recovery process to first ping the primary to have the local shard tracked, and then force a replication event

Bukhtawar · 2022-06-13T14:51:20Z

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

+    private boolean shouldProcessCheckpoint(ReplicationCheckpoint requestCheckpoint, IndexShard indexShard) {
+        if (indexShard.state().equals(IndexShardState.STARTED) == false) {
+            logger.trace("Ignoring new replication checkpoint - shard is not started {}", indexShard.state());
+            return false;
+        }
+        ReplicationCheckpoint localCheckpoint = indexShard.getLatestReplicationCheckpoint();
+        if (onGoingReplications.isShardReplicating(indexShard.shardId())) {
+            logger.trace("Ignoring new replication checkpoint - shard is currently replicating to a checkpoint");
+            return false;
+        }
+        if (localCheckpoint.isAheadOf(requestCheckpoint)) {
+            logger.trace(
+                "Ignoring new replication checkpoint - Shard is already on checkpoint {} that is ahead of {}",
+                localCheckpoint,
+                requestCheckpoint
+            );
+            return false;
+        }
+        if (localCheckpoint.equals(requestCheckpoint)) {
+            logger.trace("Ignoring new replication checkpoint - Shard is already on checkpoint {}", requestCheckpoint);
+            return false;
+        }
+        return true;
+    }


Should this method be in IndexShard instead?

Yes, thanks for catching this. I have moved this to IndexShard in new commit

…ce logs Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-14T22:38:12Z

❌ Gradle Check failure 2052ff2
Log 6007

Reports 6007

opensearch-ci-bot · 2022-06-14T22:59:43Z

✅ Gradle Check success e9168e8
Log 6008

Reports 6008

opensearch-ci-bot · 2022-06-14T23:24:16Z

❌ Gradle Check failure c2d57b2
Log 6011

Reports 6011

Rishikesh1159 · 2022-06-14T23:58:12Z

start gradle check

opensearch-ci-bot · 2022-06-15T00:29:22Z

✅ Gradle Check success c2d57b2
Log 6014

Reports 6014

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

…1159/OpenSearch into seg-rep/new-checkpoint

opensearch-ci-bot · 2022-06-15T16:26:36Z

❌ Gradle Check failure 27173d6
Log 6028

Reports 6028

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-15T17:57:01Z

✅ Gradle Check success d585645
Log 6033

Reports 6033

mch2 · 2022-06-18T03:08:30Z

server/src/main/java/org/opensearch/index/shard/IndexShard.java

    /**
     * Returns the lastest Replication Checkpoint that shard received
     */
    public ReplicationCheckpoint getLatestReplicationCheckpoint() {
-        return new ReplicationCheckpoint(shardId, 0, 0, 0, 0);
+        final SegmentInfos latestSegmentInfos = getLatestSegmentInfos();
+        return new ReplicationCheckpoint(


For a NRTReplicationEngine that is starting up, it will not yet have anything returned from getLatestSegmentInfos until the first replication event completes. I think we need to null check here and return an "empty" ReplicationCheckpoint in that case, where gen and version could be SequenceNumbers.NO_OPS_PERFORMED.

mch2 · 2022-06-18T03:10:48Z

server/src/main/java/org/opensearch/index/shard/IndexShard.java

+     * @param requestCheckpoint       received checkpoint that is checked for processing
+     * @return true if checkpoint should be processed
+     */
+    public boolean shouldProcessCheckpoint(ReplicationCheckpoint requestCheckpoint) {


nit - this method can be final.

server/src/main/java/org/opensearch/index/shard/IndexShard.java

mch2 · 2022-06-18T03:15:36Z

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

+     * @param requestCheckpoint       received checkpoint that is checked for processing
+     * @param indexShard      replica shard on which checkpoint is received
+     */
+    public synchronized void onNewCheckpoint(final ReplicationCheckpoint requestCheckpoint, final IndexShard indexShard) {


If this class is no longer final, this method can be.

This is still not possible as shardOperationOnReplica() in PublishCheckpointAction still needs to assert onNewCheckpoint(). Possibly need to use mockito-inline for making this or entire class final

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

mch2 · 2022-06-18T03:19:46Z

server/src/main/java/org/opensearch/node/Node.java

@@ -932,6 +934,15 @@ protected Node(
                        .toInstance(new PeerRecoverySourceService(transportService, indicesService, recoverySettings));
                    b.bind(PeerRecoveryTargetService.class)
                        .toInstance(new PeerRecoveryTargetService(threadPool, transportService, recoverySettings, clusterService));
+                    b.bind(SegmentReplicationTargetService.class)


if you are binding here, you do not need @Inject on SegmentReplicationTargetService's constructor.

Shouldn't this binding also be gated by the feature flag, like SegmentReplicationSourceService below?

Yes removed @Inject SegmentReplicationTargetService's constructor. Yes this should also be gated by feature flag. But need some changes in binding SegmentReplicationCheckpointPublisher in IndicesModule, will add them in next commit.

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

mch2 · 2022-06-20T19:18:14Z

server/src/main/java/org/opensearch/index/shard/IndexShard.java

+     * Returns the lastest segmentInfos
+     */
+    public SegmentInfos getLatestSegmentInfos() {
+        return getEngine().getSegmentInfosSnapshot().get();


I missed this before - getSegmentInfosSnapshot returns a GatedCloseable, we should use try-with-resources.

try(final GatedCloseable<SegmentInfos> snapshot = getEngine().getSegmentInfosSnapshot()) { return snapshot.get(); }

there is also a getSegmentInfosSnapshot method in IndexShard, we don't have to fetch off the engine.

+1 to the note above. How is this different from the existing getSegmentInfosSnapshot ?

OpenSearch/server/src/main/java/org/opensearch/index/shard/IndexShard.java

Lines 4029 to 4031 in 04e43a7

public GatedCloseable<SegmentInfos> getSegmentInfosSnapshot() {

return getEngine().getSegmentInfosSnapshot();

}

It is same as getSegmentInfosSnapshot(). So we can call that directly

opensearch-ci-bot · 2022-06-21T00:04:15Z

❌ Gradle Check failure 2a1d718
Log 6160

Reports 6160

Rishikesh1159 · 2022-06-21T00:33:13Z

start gradle check

opensearch-ci-bot · 2022-06-21T01:11:09Z

❌ Gradle Check failure 2a1d718
Log 6163

Reports 6163

kartg · 2022-06-21T04:00:03Z

server/src/main/java/org/opensearch/index/shard/IndexShard.java

+     * Returns the lastest segmentInfos
+     */
+    public SegmentInfos getLatestSegmentInfos() {
+        return getEngine().getSegmentInfosSnapshot().get();


+1 to the note above. How is this different from the existing getSegmentInfosSnapshot ?

OpenSearch/server/src/main/java/org/opensearch/index/shard/IndexShard.java

Lines 4029 to 4031 in 04e43a7

public GatedCloseable<SegmentInfos> getSegmentInfosSnapshot() {

return getEngine().getSegmentInfosSnapshot();

}

server/src/main/java/org/opensearch/indices/replication/SegmentReplicationTargetService.java

kartg · 2022-06-21T04:37:26Z

server/src/main/java/org/opensearch/indices/replication/common/ReplicationCollection.java

+     * @return true if shard is currently replicating
+     */
+    public boolean isShardReplicating(ShardId shardId) {
+        return onGoingTargetEvents.values().stream().anyMatch(t -> t.indexShard.shardId().equals(shardId));


Nit-pick - this is a problem to be solved down the line:

isShardReplicating seems like a frequent check, and constantly flattening the map to a stream of values may end up being performance-intensive. We should consider if we could make the key of the map the shardId to speed up this check.

Yes we can do that. But we have to change it in multiple places, so thinking of doing that in different PR

kartg · 2022-06-21T04:40:16Z

server/src/main/java/org/opensearch/node/Node.java

@@ -932,6 +934,15 @@ protected Node(
                        .toInstance(new PeerRecoverySourceService(transportService, indicesService, recoverySettings));
                    b.bind(PeerRecoveryTargetService.class)
                        .toInstance(new PeerRecoveryTargetService(threadPool, transportService, recoverySettings, clusterService));
+                    b.bind(SegmentReplicationTargetService.class)


Shouldn't this binding also be gated by the feature flag, like SegmentReplicationSourceService below?

...r/src/test/java/org/opensearch/indices/replication/SegmentReplicationTargetServiceTests.java

...rc/test/java/org/opensearch/indices/replication/checkpoint/PublishCheckpointActionTests.java

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-22T00:54:25Z

✅ Gradle Check success 9aec215
Log 6198

Reports 6198

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-22T16:07:19Z

❌ Gradle Check failure f6686f1
Log 6221

Reports 6221

…ceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-22T21:00:01Z

❌ Gradle Check failure 8b22a66
Log 6229

Reports 6229

Rishikesh1159 · 2022-06-22T21:02:15Z

start gradle check

opensearch-ci-bot · 2022-06-22T21:32:06Z

✅ Gradle Check success 8b22a66
Log 6232

Reports 6232

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

kartg · 2022-06-22T21:48:19Z

server/src/main/java/org/opensearch/indices/IndicesModule.java

+     *
+     * @opensearch.internal
+     */
+    public final static class CheckpointPublisherProvider implements Provider<SegmentReplicationCheckpointPublisher> {


Nitpick - if we choose to keep this provider (see my comment above), then this class can be made private and static doesn't make sense here

kartg · 2022-06-22T22:20:05Z

server/src/main/java/org/opensearch/indices/IndicesModule.java

@@ -281,7 +284,30 @@ protected void configure() {
        bind(RetentionLeaseBackgroundSyncAction.class).asEagerSingleton();
        bind(RetentionLeaseSyncer.class).asEagerSingleton();
        if (FeatureFlags.isEnabled(FeatureFlags.REPLICATION_TYPE)) {
-            bind(SegmentReplicationCheckpointPublisher.class).asEagerSingleton();
+            bind(SegmentReplicationCheckpointPublisher.class).toProvider(CheckpointPublisherProvider.class).asEagerSingleton();


Since you have an else bind statement, you don't need really need a Provider here, and you can retain the @Inject constructor

opensearch-ci-bot · 2022-06-22T22:44:42Z

❌ Gradle Check failure 33564c3
Log 6235

Reports 6235

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

opensearch-ci-bot · 2022-06-22T23:26:03Z

✅ Gradle Check success 37bf71b
Log 6236

Reports 6236

mch2

LGTM, thanks @Rishikesh1159

* Bump reactor-netty-core from 1.0.16 to 1.0.19 in /plugins/repository-azure (#3360) * Bump reactor-netty-core in /plugins/repository-azure Bumps [reactor-netty-core](https://github.com/reactor/reactor-netty) from 1.0.16 to 1.0.19. - [Release notes](https://github.com/reactor/reactor-netty/releases) - [Commits](reactor/reactor-netty@v1.0.16...v1.0.19) --- updated-dependencies: - dependency-name: io.projectreactor.netty:reactor-netty-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * [Type removal] _type removal from mocked responses of scroll hit tests (#3377) Signed-off-by: Suraj Singh <surajrider@gmail.com> * [Type removal] Remove _type deprecation from script and conditional processor (#3239) * [Type removal] Remove _type deprecation from script and conditional processor Signed-off-by: Suraj Singh <surajrider@gmail.com> * Spotless check apply Signed-off-by: Suraj Singh <surajrider@gmail.com> * [Type removal] Remove _type from _bulk yaml test, scripts, unused constants (#3372) * [Type removal] Remove redundant _type deprecation checks in bulk request Signed-off-by: Suraj Singh <surajrider@gmail.com> * [Type removal] bulk yaml tests validating deprecation on _type and removal from scripts Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix Lucene-snapshots repo for jdk 17. (#3396) Signed-off-by: Marc Handalian <handalm@amazon.com> * Replace internal usages of 'master' term in 'server/src/internalClusterTest' directory (#2521) Signed-off-by: Tianli Feng <ftianli@amazon.com> * [REMOVE] Cleanup deprecated thread pool types (FIXED_AUTO_QUEUE_SIZE) (#3369) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * [Type removal] _type removal from tests of yaml tests (#3406) * [Type removal] _type removal from tests of yaml tests Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix spotless failures Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix assertion failures Signed-off-by: Suraj Singh <surajrider@gmail.com> * Fix assertion failures in DoSectionTests Signed-off-by: Suraj Singh <surajrider@gmail.com> * Add release notes for version 2.0.0 (#3410) Signed-off-by: Rabi Panda <adnapibar@gmail.com> * [Upgrade] Lucene-9.2.0-snapshot-ba8c3a8 (#3416) Upgrades to latest snapshot of lucene 9.2.0 in preparation for GA release. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> * Fix release notes for 2.0.0-rc1 version (#3418) This change removes some old commits from the 2.0.0-rc1 release notes. These commits were already released as part of 1.x releases. Add back some missing type removal commits to the 2.0.0 release notes Signed-off-by: Rabi Panda <adnapibar@gmail.com> * Bump version 2.1 to Lucene 9.2 after upgrade (#3424) Bumps Version.V_2_1_0 lucene version to 9.2 after backporting upgrage. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> * Bump com.gradle.enterprise from 3.10 to 3.10.1 (#3425) Bumps com.gradle.enterprise from 3.10 to 3.10.1. --- updated-dependencies: - dependency-name: com.gradle.enterprise dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump reactor-core from 3.4.17 to 3.4.18 in /plugins/repository-azure (#3427) Bumps [reactor-core](https://github.com/reactor/reactor-core) from 3.4.17 to 3.4.18. - [Release notes](https://github.com/reactor/reactor-core/releases) - [Commits](reactor/reactor-core@v3.4.17...v3.4.18) --- updated-dependencies: - dependency-name: io.projectreactor:reactor-core dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump gax-httpjson from 0.101.0 to 0.103.1 in /plugins/repository-gcs (#3426) Bumps [gax-httpjson](https://github.com/googleapis/gax-java) from 0.101.0 to 0.103.1. - [Release notes](https://github.com/googleapis/gax-java/releases) - [Changelog](https://github.com/googleapis/gax-java/blob/main/CHANGELOG.md) - [Commits](https://github.com/googleapis/gax-java/commits) --- updated-dependencies: - dependency-name: com.google.api:gax-httpjson dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * [segment replication]Introducing common Replication interfaces for segment replication and recovery code paths (#3234) * RecoveryState inherits from ReplicationState + RecoveryTarget inherits from ReplicationTarget Signed-off-by: Poojita Raj <poojiraj@amazon.com> * Refactoring: mixedClusterVersion error fix + move Stage to ReplicationState Signed-off-by: Poojita Raj <poojiraj@amazon.com> * pull ReplicationListener into a top level class + add javadocs + address review comments Signed-off-by: Poojita Raj <poojiraj@amazon.com> * fix javadoc Signed-off-by: Poojita Raj <poojiraj@amazon.com> * review changes Signed-off-by: Poojita Raj <poojiraj@amazon.com> * Refactoring the hierarchy relationship between repl and recovery Signed-off-by: Poojita Raj <poojiraj@amazon.com> * style fix Signed-off-by: Poojita Raj <poojiraj@amazon.com> * move package common under replication Signed-off-by: Poojita Raj <poojiraj@amazon.com> * rename to replication Signed-off-by: Poojita Raj <poojiraj@amazon.com> * rename and doc changes Signed-off-by: Poojita Raj <poojiraj@amazon.com> * [Type removal] Remove type from BulkRequestParser (#3423) * [Type removal] Remove type handling in bulk request parser Signed-off-by: Suraj Singh <surajrider@gmail.com> * [Type removal] Remove testTypesStillParsedForBulkMonitoring as it is no longer present in codebase Signed-off-by: Suraj Singh <surajrider@gmail.com> * Adding CheckpointRefreshListener to trigger when Segment replication is turned on and Primary shard refreshes (#3108) * Intial PR adding classes and tests related to checkpoint publishing Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Putting a Draft PR with all changes in classes. Testing is still not included in this commit. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Wiring up index shard to new engine, spotless apply and removing unnecessary tests and logs Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding Unit test for checkpointRefreshListener Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Applying spotless check Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fixing import statements * Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * removing unused constructor in index shard Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Addressing comments from last commit Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding package-info.java files for two new packages Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding test for null checkpoint publisher and addreesing PR comments Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add docs for indexshardtests and remove shard.refresh Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Add a new Engine implementation for replicas with segment replication enabled. (#3240) * Change fastForwardProcessedSeqNo method in LocalCheckpointTracker to persisted checkpoint. This change inverts fastForwardProcessedSeqNo to fastForwardPersistedSeqNo for use in Segment Replication. This is so that a Segrep Engine can match the logic of InternalEngine where the seqNo is incremented with each operation, but only persisted in the tracker on a flush. With Segment Replication we bump the processed number with each operation received index/delete/noOp, and invoke this method when we receive a new set of segments to bump the persisted seqNo. Signed-off-by: Marc Handalian <handalm@amazon.com> * Extract Translog specific engine methods into an abstract class. This change extracts translog specific methods to an abstract engine class so that other engine implementations can reuse translog logic. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add a separate Engine implementation for replicas with segment replication enabled. This change adds a new engine intended to be used on replicas with segment replication enabled. This engine does not wire up an IndexWriter, but still writes all operations to a translog. The engine uses a new ReaderManager that refreshes from an externally provided SegmentInfos. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix spotless checks. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix :server:compileInternalClusterTestJava compilation. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix failing test naming convention check. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR feedback. - Removed isReadOnlyReplica from overloaded constructor and added feature flag checks. - Updated log msg in NRTReplicationReaderManager - cleaned up store ref counting in NRTReplicationEngine. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix spotless check. Signed-off-by: Marc Handalian <handalm@amazon.com> * Remove TranslogAwareEngine and build translog in NRTReplicationEngine. Signed-off-by: Marc Handalian <handalm@amazon.com> * Fix formatting Signed-off-by: Marc Handalian <handalm@amazon.com> * Add missing translog methods to NRTEngine. Signed-off-by: Marc Handalian <handalm@amazon.com> * Remove persistent seqNo check from fastForwardProcessedSeqNo. Signed-off-by: Marc Handalian <handalm@amazon.com> * PR feedback. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add test specific to translog trimming. Signed-off-by: Marc Handalian <handalm@amazon.com> * Javadoc check. Signed-off-by: Marc Handalian <handalm@amazon.com> * Add failEngine calls to translog methods in NRTReplicationEngine. Roll xlog generation on replica when a new commit point is received. Signed-off-by: Marc Handalian <handalm@amazon.com> * Rename master to cluster_manager in the XContent Parser of ClusterHealthResponse (#3432) Signed-off-by: Tianli Feng <ftianli@amazon.com> * Bump hadoop-minicluster in /test/fixtures/hdfs-fixture (#3359) Bumps hadoop-minicluster from 3.3.2 to 3.3.3. --- updated-dependencies: - dependency-name: org.apache.hadoop:hadoop-minicluster dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump avro from 1.10.2 to 1.11.0 in /plugins/repository-hdfs (#3358) * Bump avro from 1.10.2 to 1.11.0 in /plugins/repository-hdfs Bumps avro from 1.10.2 to 1.11.0. --- updated-dependencies: - dependency-name: org.apache.avro:avro dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Fix testSetAdditionalRolesCanAddDeprecatedMasterRole() by removing the initial assertion (#3441) Signed-off-by: Tianli Feng <ftianli@amazon.com> * Replace internal usages of 'master' term in 'server/src/test' directory (#2520) * Replace the non-inclusive terminology "master" with "cluster manager" in code comments, internal variable/method/class names, in `server/src/test` directory. * Backwards compatibility is not impacted. * Add a new unit test `testDeprecatedMasterNodeFilter()` to validate using `master:true` or `master:false` can filter the node in [Cluster Stats](https://opensearch.org/docs/latest/opensearch/rest-api/cluster-stats/) API, after the `master` role is deprecated in PR #2424 Signed-off-by: Tianli Feng <ftianli@amazon.com> * Removing unused method from TransportSearchAction (#3437) * Removing unused method from TransportSearchAction Signed-off-by: Ankit Jain <jain.ankitk@gmail.com> * Set term vector flags to false for ._index_prefix field (#1901). (#3119) * Set term vector flags to false for ._index_prefix field (#1901). Signed-off-by: Vesa Pehkonen <vesa.pehkonen@intel.com> * Replaced the FieldType copy ctor with ctor for the prefix field and replaced setting the field type parameters with setIndexOptions(). (#1901) Signed-off-by: Vesa Pehkonen <vesa.pehkonen@intel.com> * Added tests for term vectors. (#1901) Signed-off-by: Vesa Pehkonen <vesa.pehkonen@intel.com> * Fixed code formatting error. Signed-off-by: Vesa Pehkonen <vesa.pehkonen@intel.com> Co-authored-by: sdp <sdp@9049fa06826d.jf.intel.com> * [BUG] Fixing org.opensearch.monitor.os.OsProbeTests > testLogWarnCpuMessageOnlyOnes when cgroups are available but cgroup stats is not (#3448) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * [Segment Replication] Add SegmentReplicationTargetService to orchestrate replication events. (#3439) * Add SegmentReplicationTargetService to orchestrate replication events. This change introduces boilerplate classes for Segment Replication and a target service to orchestrate replication events. It also includes two refactors of peer recovery components for reuse. 1. Rename RecoveryFileChunkRequest to FileChunkRequest and extract code to handle throttling into ReplicationTarget. 2. Extracts a component to execute retryable requests over the transport layer. Signed-off-by: Marc Handalian <handalm@amazon.com> * Code cleanup. Signed-off-by: Marc Handalian <handalm@amazon.com> * Make SegmentReplicationTargetService component final so that it can not be extended by plugins. Signed-off-by: Marc Handalian <handalm@amazon.com> * Bump azure-core-http-netty from 1.11.9 to 1.12.0 in /plugins/repository-azure (#3474) Bumps [azure-core-http-netty](https://github.com/Azure/azure-sdk-for-java) from 1.11.9 to 1.12.0. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-core-http-netty_1.11.9...azure-core_1.12.0) --- updated-dependencies: - dependency-name: com.azure:azure-core-http-netty dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Update to Apache Lucene 9.2 (#3477) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Bump protobuf-java from 3.20.1 to 3.21.1 in /plugins/repository-hdfs (#3472) Signed-off-by: dependabot[bot] <support@github.com> * [Upgrade] Lucene-9.3.0-snapshot-823df23 (#3478) Upgrades to latest snapshot of lucene 9.3.0. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> * Filter out invalid URI and HTTP method in the error message of no handler found for a REST request (#3459) Filter out invalid URI and HTTP method of a error message, which shown when there is no handler found for a REST request sent by user, so that HTML special characters <>&"' will not shown in the error message. The error message is return as mine-type `application/json`, which can't contain active (script) content, so it's not a vulnerability. Besides, no browsers are going to render as html when the mine-type is that. While the common security scanners will raise a false-positive alarm for having HTML tags in the response without escaping the HTML special characters, so the solution only aims to satisfy the code security scanners. Signed-off-by: Tianli Feng <ftianli@amazon.com> * Support use of IRSA for repository-s3 plugin credentials (#3475) * Support use of IRSA for repository-s3 plugin credentials Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Address code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Bump google-auth-library-oauth2-http from 0.20.0 to 1.7.0 in /plugins/repository-gcs (#3473) * Bump google-auth-library-oauth2-http in /plugins/repository-gcs Bumps google-auth-library-oauth2-http from 0.20.0 to 1.7.0. --- updated-dependencies: - dependency-name: com.google.auth:google-auth-library-oauth2-http dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Use variable to define the version of dependency google-auth-library-java Signed-off-by: Tianli Feng <ftianli@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Tianli Feng <ftianli@amazon.com> * [Segment Replication] Added source-side classes for orchestrating replication events (#3470) This change expands on the existing SegmentReplicationSource interface and its corresponding Factory class by introducing an implementation where the replication source is a primary shard (PrimaryShardReplicationSource). These code paths execute on the target. The primary shard implementation creates the requests to be send to the source/primary shard. Correspondingly, this change also defines two request classes for the GET_CHECKPOINT_INFO and GET_SEGMENT_FILES requests as well as an abstract superclass. A CopyState class has been introduced that captures point-in-time, file-level details from an IndexShard. This implementation mirrors Lucene's NRT CopyState implementation. Finally, a service class has been introduce for segment replication that runs on the source side (SegmentReplicationSourceService) which handles these two types of incoming requests. This includes private handler classes that house the logic to respond to these requests, with some functionality stubbed for now. The service class also uses a simple map to cache CopyState objects that would be needed by replication targets. Unit tests have been added/updated for all new functionality. Signed-off-by: Kartik Ganesh <gkart@amazon.com> * [Dependency upgrade] google-oauth-client to 1.33.3 (#3500) Signed-off-by: Suraj Singh <surajrider@gmail.com> * move bash flag to set statement (#3494) Passing bash with flags to the first argument of /usr/bin/env requires its own flag to interpret it correctly. Rather than use `env -S` to split the argument, have the script `set -e` to enable the same behavior explicitly in preinst and postinst scripts. Also set `-o pipefail` for consistency. Closes: #3492 Signed-off-by: Cole White <cwhite@wikimedia.org> * Support use of IRSA for repository-s3 plugin credentials: added YAML Rest test case (#3499) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Bump azure-storage-common from 12.15.0 to 12.16.0 in /plugins/repository-azure (#3517) * Bump azure-storage-common in /plugins/repository-azure Bumps [azure-storage-common](https://github.com/Azure/azure-sdk-for-java) from 12.15.0 to 12.16.0. - [Release notes](https://github.com/Azure/azure-sdk-for-java/releases) - [Commits](Azure/azure-sdk-for-java@azure-storage-blob_12.15.0...azure-storage-blob_12.16.0) --- updated-dependencies: - dependency-name: com.azure:azure-storage-common dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump google-oauth-client from 1.33.3 to 1.34.0 in /plugins/discovery-gce (#3516) * Bump google-oauth-client from 1.33.3 to 1.34.0 in /plugins/discovery-gce Bumps [google-oauth-client](https://github.com/googleapis/google-oauth-java-client) from 1.33.3 to 1.34.0. - [Release notes](https://github.com/googleapis/google-oauth-java-client/releases) - [Changelog](https://github.com/googleapis/google-oauth-java-client/blob/main/CHANGELOG.md) - [Commits](googleapis/google-oauth-java-client@v1.33.3...v1.34.0) --- updated-dependencies: - dependency-name: com.google.oauth-client:google-oauth-client dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Fix the support of RestClient Node Sniffer for version 2.x and update tests (#3487) Fix the support of RestClient Node Sniffer for OpenSearch 2.x, and update unit tests for OpenSearch. The current code contains the logic to be compatible with Elasticsearch 2.x version, which is conflict with OpenSearch 2.x, so removed that part of legacy code. * Update the script create_test_nodes_info.bash to dump the response of Nodes Info API GET _nodes/http for OpenSearch 1.0 and 2.0 version, which used for unit test. * Remove the support of Elasticsearch version 2.x for the Sniffer * Update unit test to validate the Sniffer compatible with OpenSearch 1.x and 2.x * Update the API response parser to meet the array notation (in ES 6.1 and above) for the node attributes setting. It will result the value of `node.attr` setting will not be parsed as array in the Sniffer, when using the Sniffer on cluster in Elasticsearch 6.0 and above. * Replace "master" node role with "cluster_manager" in unit test Signed-off-by: Tianli Feng <ftianli@amazon.com> * Bump com.diffplug.spotless from 6.6.1 to 6.7.0 (#3513) Bumps com.diffplug.spotless from 6.6.1 to 6.7.0. --- updated-dependencies: - dependency-name: com.diffplug.spotless dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump guava from 18.0 to 23.0 in /plugins/ingest-attachment (#3357) * Bump guava from 18.0 to 23.0 in /plugins/ingest-attachment Bumps [guava](https://github.com/google/guava) from 18.0 to 23.0. - [Release notes](https://github.com/google/guava/releases) - [Commits](google/guava@v18.0...v23.0) --- updated-dependencies: - dependency-name: com.google.guava:guava dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Add more ingorance of using internal java API sun.misc.Unsafe Signed-off-by: Tianli Feng <ftianli@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Tianli Feng <ftianli@amazon.com> * Added bwc version 2.0.1 (#3452) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com> * Add release notes for 1.3.3 (#3549) Signed-off-by: Xue Zhou <xuezhou@amazon.com> * [Upgrade] Lucene-9.3.0-snapshot-b7231bb (#3537) Upgrades to latest snapshot of lucene 9.3; including reducing maxFullFlushMergeWaitMillis in LuceneTest.testWrapLiveDocsNotExposeAbortedDocuments to 0 ms to ensure aborted docs are not merged away in the test with the new mergeOnRefresh default policy. Signed-off-by: Nicholas Walter Knize <nknize@apache.org> * [Remote Store] Upload segments to remote store post refresh (#3460) * Add RemoteDirectory interface to copy segment files to/from remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> * Add index level setting for remote store Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> * Add RemoteDirectoryFactory and use RemoteDirectory instance in RefreshListener Co-authored-by: Sachin Kale <kalsac@amazon.com> Signed-off-by: Sachin Kale <kalsac@amazon.com> * Upload segment to remote store post refresh Signed-off-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> * Fixing VerifyVersionConstantsIT test failure (#3574) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Bump jettison from 1.4.1 to 1.5.0 in /plugins/discovery-azure-classic (#3571) * Bump jettison from 1.4.1 to 1.5.0 in /plugins/discovery-azure-classic Bumps [jettison](https://github.com/jettison-json/jettison) from 1.4.1 to 1.5.0. - [Release notes](https://github.com/jettison-json/jettison/releases) - [Commits](jettison-json/jettison@jettison-1.4.1...jettison-1.5.0) --- updated-dependencies: - dependency-name: org.codehaus.jettison:jettison dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump google-api-services-storage from v1-rev20200814-1.30.10 to v1-rev20220608-1.32.1 in /plugins/repository-gcs (#3573) * Bump google-api-services-storage in /plugins/repository-gcs Bumps google-api-services-storage from v1-rev20200814-1.30.10 to v1-rev20220608-1.32.1. --- updated-dependencies: - dependency-name: com.google.apis:google-api-services-storage dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> * Upgrade Google HTTP Client to 1.42.0 Signed-off-by: Xue Zhou <xuezhou@amazon.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Xue Zhou <xuezhou@amazon.com> * Add flat_skew setting to node overload decider (#3563) * Add flat_skew setting to node overload decider Signed-off-by: Rishab Nahata <rnnahata@amazon.com> * Bump xmlbeans from 5.0.3 to 5.1.0 in /plugins/ingest-attachment (#3572) * Bump xmlbeans from 5.0.3 to 5.1.0 in /plugins/ingest-attachment Bumps xmlbeans from 5.0.3 to 5.1.0. --- updated-dependencies: - dependency-name: org.apache.xmlbeans:xmlbeans dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Bump google-oauth-client from 1.34.0 to 1.34.1 in /plugins/discovery-gce (#3570) * Bump google-oauth-client from 1.34.0 to 1.34.1 in /plugins/discovery-gce Bumps [google-oauth-client](https://github.com/googleapis/google-oauth-java-client) from 1.34.0 to 1.34.1. - [Release notes](https://github.com/googleapis/google-oauth-java-client/releases) - [Changelog](https://github.com/googleapis/google-oauth-java-client/blob/main/CHANGELOG.md) - [Commits](googleapis/google-oauth-java-client@v1.34.0...v1.34.1) --- updated-dependencies: - dependency-name: com.google.oauth-client:google-oauth-client dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Updating SHAs Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> * Fix for bug showing incorrect awareness attributes count in AwarenessAllocationDecider (#3428) * Fix for bug showing incorrect awareness attributes count in AwarenessAllocationDecider Signed-off-by: Anshu Agarwal <anshukag@amazon.com> * Added bwc version 1.3.4 (#3552) Signed-off-by: GitHub <noreply@github.com> Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com> * Support dynamic node role (#3436) * Support unknown node role Currently OpenSearch only supports several built-in nodes like data node role. If specify unknown node role, OpenSearch node will fail to start. This limit how to extend OpenSearch to support some extension function. For example, user may prefer to run ML tasks on some dedicated node which doesn't serve as any built-in node roles. So the ML tasks won't impact OpenSearch core function. This PR removed the limitation and user can specify any node role and OpenSearch will start node correctly with that unknown role. This opens the door for plugin developer to run specific tasks on dedicated nodes. Issue: #2877 Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix cat nodes rest API spec Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix mixed cluster IT failure Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add DynamicRole Signed-off-by: Yaliang Wu <ylwu@amazon.com> * change generator method name Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix failed docker test Signed-off-by: Yaliang Wu <ylwu@amazon.com> * transform role name to lower case to avoid confusion Signed-off-by: Yaliang Wu <ylwu@amazon.com> * transform the node role abbreviation to lower case Signed-off-by: Yaliang Wu <ylwu@amazon.com> * fix checkstyle Signed-off-by: Yaliang Wu <ylwu@amazon.com> * add test for case-insensitive role name change Signed-off-by: Yaliang Wu <ylwu@amazon.com> * Rename package 'o.o.action.support.master' to 'o.o.action.support.clustermanager' (#3556) * Rename package org.opensearch.action.support.master to org.opensearch.action.support.clustermanager Signed-off-by: Tianli Feng <ftianli@amazon.com> * Rename classes with master term in the package org.opensearch.action.support.master Signed-off-by: Tianli Feng <ftianli@amazon.com> * Deprecate classes in org.opensearch.action.support.master Signed-off-by: Tianli Feng <ftianli@amazon.com> * Remove pakcage o.o.action.support.master Signed-off-by: Tianli Feng <ftianli@amazon.com> * Move package-info back Signed-off-by: Tianli Feng <ftianli@amazon.com> * Move package-info to new folder Signed-off-by: Tianli Feng <ftianli@amazon.com> * Correct the package-info Signed-off-by: Tianli Feng <ftianli@amazon.com> * Fixing flakiness of ShuffleForcedMergePolicyTests (#3591) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Deprecate classes in org.opensearch.action.support.master (#3593) Signed-off-by: Tianli Feng <ftianli@amazon.com> * Add release notes for version 2.0.1 (#3595) Signed-off-by: Kunal Kotwani <kkotwani@amazon.com> * Fix NPE when minBound/maxBound is not set before being called. (#3605) Signed-off-by: George Apaaboah <george.apaaboah@gmail.com> * Added bwc version 2.0.2 (#3613) Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com> * Fix false positive query timeouts due to using cached time (#3454) * Fix false positive query timeouts due to using cached time Signed-off-by: Ahmad AbuKhalil <abukhali@amazon.com> * delegate nanoTime call to SearchContext Signed-off-by: Ahmad AbuKhalil <abukhali@amazon.com> * add override to SearchContext getRelativeTimeInMillis to force non cached time Signed-off-by: Ahmad AbuKhalil <abukhali@amazon.com> * Fix random gradle check failure issue 3584. (#3627) * [Segment Replication] Add components for segment replication to perform file copy. (#3525) * Add components for segment replication to perform file copy. This change adds the required components to SegmentReplicationSourceService to initiate copy and react to lifecycle events. Along with new components it refactors common file copy code from RecoverySourceHandler into reusable pieces. Signed-off-by: Marc Handalian <handalm@amazon.com> * Deprecate public methods and variables with master term in package 'org.opensearch.action.support.master' (#3617) Signed-off-by: Tianli Feng <ftianli@amazon.com> * Add replication orchestration for a single shard (#3533) * implement segment replication target Signed-off-by: Poojita Raj <poojiraj@amazon.com> * test added Signed-off-by: Poojita Raj <poojiraj@amazon.com> * changes to tests + finalizeReplication Signed-off-by: Poojita Raj <poojiraj@amazon.com> * fix style check Signed-off-by: Poojita Raj <poojiraj@amazon.com> * addressing comments + fix gradle check Signed-off-by: Poojita Raj <poojiraj@amazon.com> * added test + addressed review comments Signed-off-by: Poojita Raj <poojiraj@amazon.com> * [BUG] opensearch crashes on closed client connection before search reply (#3626) * [BUG] opensearch crashes on closed client connection before search reply Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Addressing code review comments Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Add all deprecated method in the package with new name 'org.opensearch.action.support.clustermanager' (#3644) Signed-off-by: Tianli Feng <ftianli@amazon.com> * Introduce TranslogManager implementations decoupled from the Engine (#3638) * Introduce decoupled translog manager interfaces Signed-off-by: Bukhtawar Khan <bukhtawa@amazon.com> * Adding onNewCheckpoint to Start Replication on Replica Shard when Segment Replication is turned on (#3540) * Adding onNewCheckpoint and it's test to start replication. SCheck for latestcheckpoint and replaying logic is removed from this commit and will be added in a different PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Changing binding/inject logic and addressing comments from PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Applying spotless check Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Moving shouldProcessCheckpoint() to IndexShard, and removing some trace logs Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * applying spotlessApply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding more info to log statement in targetservice class Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * applying spotlessApply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Addressing comments on PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding teardown() in SegmentReplicationTargetServiceTests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * fixing testShouldProcessCheckpoint() in SegmentReplicationTargetServiceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Removing CheckpointPublisherProvider in IndicesModule Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * spotless check apply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Remove class org.opensearch.action.support.master.AcknowledgedResponse (#3662) * Remove class org.opensearch.action.support.master.AcknowledgedResponse Signed-off-by: Tianli Feng <ftianli@amazon.com> * Remove class org.opensearch.action.support.master.AcknowledgedRequest RequestBuilder ShardsAcknowledgedResponse Signed-off-by: Tianli Feng <ftianli@amazon.com> * Restore AcknowledgedResponse and AcknowledgedRequest to package org.opensearch.action.support.master (#3669) Signed-off-by: Tianli Feng <ftianli@amazon.com> * [BUG] Custom POM configuration for ZIP publication produces duplicit tags (url, scm) (#3656) * [BUG] Custom POM configuration for ZIP publication produces duplicit tags (url, scm) Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Added test case for pluginZip with POM Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Support both Gradle 6.8.x and Gradle 7.4.x Signed-off-by: Andriy Redko <andriy.redko@aiven.io> * Adding 2.2.0 Bwc version to main (#3673) * Upgraded to t-digest 3.3. (#3634) * Revert renaming method onMaster() and offMaster() in interface LocalNodeMasterListener (#3686) Signed-off-by: Tianli Feng <ftianli@amazon.com> * Upgrading AWS SDK dependency for native plugins (#3694) * Merge branch 'feature/point_in_time' of https://github.com/opensearch-project/OpenSearch into fb Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: dependabot[bot] <dependabot[bot]@users.noreply.github.com> Co-authored-by: Suraj Singh <surajrider@gmail.com> Co-authored-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Tianli Feng <ftianli@amazon.com> Co-authored-by: Andriy Redko <andriy.redko@aiven.io> Co-authored-by: Rabi Panda <adnapibar@gmail.com> Co-authored-by: Nick Knize <nknize@apache.org> Co-authored-by: Poojita Raj <poojiraj@amazon.com> Co-authored-by: Rishikesh Pasham <62345295+Rishikesh1159@users.noreply.github.com> Co-authored-by: Ankit Jain <jain.ankitk@gmail.com> Co-authored-by: vpehkone <101240162+vpehkone@users.noreply.github.com> Co-authored-by: sdp <sdp@9049fa06826d.jf.intel.com> Co-authored-by: Kartik Ganesh <gkart@amazon.com> Co-authored-by: Cole White <42356806+shdubsh@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: opensearch-ci-bot <opensearch-ci-bot@users.noreply.github.com> Co-authored-by: Xue Zhou <85715413+xuezhou25@users.noreply.github.com> Co-authored-by: Sachin Kale <sachinpkale@gmail.com> Co-authored-by: Sachin Kale <kalsac@amazon.com> Co-authored-by: Xue Zhou <xuezhou@amazon.com> Co-authored-by: Rishab Nahata <rishabnahata07@gmail.com> Co-authored-by: Anshu Agarwal <anshuagarwal11@gmail.com> Co-authored-by: Yaliang Wu <ylwu@amazon.com> Co-authored-by: Kunal Kotwani <kkotwani@amazon.com> Co-authored-by: George Apaaboah <35894485+GeorgeAp@users.noreply.github.com> Co-authored-by: Ahmad AbuKhalil <105249973+aabukhalil@users.noreply.github.com> Co-authored-by: Bukhtawar Khan <bukhtawa@amazon.com> Co-authored-by: Sarat Vemulapalli <vemulapallisarat@gmail.com> Co-authored-by: Daniel (dB.) Doubrovkine <dblock@dblock.org>

…ment Replication is turned on (#3540) * Adding onNewCheckpoint and it's test to start replication. SCheck for latestcheckpoint and replaying logic is removed from this commit and will be added in a different PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Changing binding/inject logic and addressing comments from PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Applying spotless check Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Moving shouldProcessCheckpoint() to IndexShard, and removing some trace logs Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * applying spotlessApply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding more info to log statement in targetservice class Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * applying spotlessApply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Addressing comments on PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding teardown() in SegmentReplicationTargetServiceTests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * fixing testShouldProcessCheckpoint() in SegmentReplicationTargetServiceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Removing CheckpointPublisherProvider in IndicesModule Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * spotless check apply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

…ment Replication is turned on (opensearch-project#3540) * Adding onNewCheckpoint and it's test to start replication. SCheck for latestcheckpoint and replaying logic is removed from this commit and will be added in a different PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Changing binding/inject logic and addressing comments from PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Applying spotless check Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Moving shouldProcessCheckpoint() to IndexShard, and removing some trace logs Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * applying spotlessApply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding more info to log statement in targetservice class Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * applying spotlessApply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Addressing comments on PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding teardown() in SegmentReplicationTargetServiceTests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * fixing testShouldProcessCheckpoint() in SegmentReplicationTargetServiceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Removing CheckpointPublisherProvider in IndicesModule Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * spotless check apply Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

…#3943 #3963 From main branch (#4181) * Resolving import conflict in Node.java and mergining PR #3525. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Resolving conflicts and merging PR #3533. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Resolving conflicts and Merging PR #3540. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Applying spotlesscheck and fixing wildcard imports. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * [Segment Replication] Fixing flaky test failure happening for testShardAlreadyReplicating() (#3943) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Fix possible flaky test for testBeforeIndexShardClosed_CancelsOngoingReplications() (#3963) * Fixing flaky test failure happening for testShardAlreadyReplicating() Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Removing assert segrep() in getProcessedLocalCheckpoint() of Index.shard class. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> * Revert "Adding back assert statement and make index setting to segment replication in SegmentReplicationSourceHandlerTests and SegmentReplicationTargetServiceTests." Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> This reverts commit 8c5753b. Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com> Co-authored-by: Marc Handalian <handalm@amazon.com> Co-authored-by: Poojita Raj <poojiraj@amazon.com>

Adding onNewCheckpoint and it's test to start replication. SCheck for…

8b288d8

… latestcheckpoint and replaying logic is removed from this commit and will be added in a different PR Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Rishikesh1159 requested review from a team and reta as code owners June 8, 2022 17:00

Rishikesh1159 requested a review from mch2 June 8, 2022 17:26

mch2 reviewed Jun 9, 2022

View reviewed changes

Rishikesh1159 added 2 commits June 9, 2022 17:33

Changing binding/inject logic and addressing comments from PR

02c1be3

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Applying spotless check

45f8026

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Bukhtawar reviewed Jun 13, 2022

View reviewed changes

Rishikesh1159 added 2 commits June 14, 2022 22:15

Moving shouldProcessCheckpoint() to IndexShard, and removing some tra…

2052ff2

…ce logs Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

applying spotlessApply

e9168e8

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Merge branch 'opensearch-project:main' into seg-rep/new-checkpoint

c2d57b2

Rishikesh1159 added 2 commits June 15, 2022 16:02

Adding more info to log statement in targetservice class

3cda46c

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Merge branch 'seg-rep/new-checkpoint' of https://github.com/Rishikesh…

27173d6

…1159/OpenSearch into seg-rep/new-checkpoint

applying spotlessApply

d585645

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Rishikesh1159 requested a review from Bukhtawar June 15, 2022 17:27

mch2 mentioned this pull request Jun 17, 2022

[Segment Replication] Add components for segment replication to perform file copy. #3525

Merged

5 tasks

mch2 reviewed Jun 18, 2022

View reviewed changes

mch2 reviewed Jun 20, 2022

View reviewed changes

Merge branch 'main' into seg-rep/new-checkpoint

2a1d718

kartg reviewed Jun 21, 2022

View reviewed changes

Addressing comments on PR

9aec215

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Rishikesh1159 and others added 2 commits June 22, 2022 15:35

Adding teardown() in SegmentReplicationTargetServiceTests.

512ba04

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Merge branch 'main' into seg-rep/new-checkpoint

f6686f1

fixing testShouldProcessCheckpoint() in SegmentReplicationTargetServi…

8b22a66

…ceTests Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Removing CheckpointPublisherProvider in IndicesModule

33564c3

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

kartg approved these changes Jun 22, 2022

View reviewed changes

spotless check apply

37bf71b

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

mch2 approved these changes Jun 22, 2022

View reviewed changes

Rishikesh1159 merged commit 7005b9e into opensearch-project:main Jun 22, 2022

Rishikesh1159 mentioned this pull request Jul 19, 2022

[Segment Replication] Checkpoint Replay on Replica Shard #3658

Merged

5 tasks

Rishikesh1159 added a commit to Rishikesh1159/OpenSearch that referenced this pull request Aug 9, 2022

Resolving conflicts and Merging PR opensearch-project#3540.

9b83b52

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

Rishikesh1159 mentioned this pull request Aug 9, 2022

[Backport 2.x] [Segment Replication] Backport PR's : #3525 #3533 #3540 #3943 #3963 From main branch #4181

Merged

Rishikesh1159 added a commit to Rishikesh1159/OpenSearch that referenced this pull request Aug 10, 2022

Cherry-picking opensearch-project#3540.

d48a604

Signed-off-by: Rishikesh1159 <rishireddy1159@gmail.com>

		@@ -159,6 +160,7 @@ public class RecoverySettings {

		private volatile ByteSizeValue chunkSize = DEFAULT_CHUNK_SIZE;

		@Inject

	public GatedCloseable<SegmentInfos> getSegmentInfosSnapshot() {
	return getEngine().getSegmentInfosSnapshot();
	}

Adding onNewCheckpoint to Start Replication on Replica Shard when Segment Replication is turned on #3540

Adding onNewCheckpoint to Start Replication on Replica Shard when Segment Replication is turned on #3540

Conversation

Rishikesh1159 commented Jun 8, 2022 • edited Loading

Description

Issues Resolved

Check List

opensearch-ci-bot commented Jun 8, 2022

mch2 Jun 9, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-ci-bot commented Jun 9, 2022

opensearch-ci-bot commented Jun 9, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-ci-bot commented Jun 14, 2022

opensearch-ci-bot commented Jun 14, 2022

opensearch-ci-bot commented Jun 14, 2022

Rishikesh1159 commented Jun 14, 2022

opensearch-ci-bot commented Jun 15, 2022

opensearch-ci-bot commented Jun 15, 2022

opensearch-ci-bot commented Jun 15, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mch2 Jun 18, 2022 • edited by kartg Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mch2 Jun 20, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-ci-bot commented Jun 21, 2022

Rishikesh1159 commented Jun 21, 2022

opensearch-ci-bot commented Jun 21, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-ci-bot commented Jun 22, 2022

opensearch-ci-bot commented Jun 22, 2022

opensearch-ci-bot commented Jun 22, 2022

Rishikesh1159 commented Jun 22, 2022

opensearch-ci-bot commented Jun 22, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-ci-bot commented Jun 22, 2022

opensearch-ci-bot commented Jun 22, 2022

mch2 left a comment

Choose a reason for hiding this comment

Rishikesh1159 commented Jun 8, 2022 •

edited

Loading

mch2 Jun 9, 2022 •

edited

Loading

mch2 Jun 18, 2022 •

edited by kartg

Loading

mch2 Jun 20, 2022 •

edited

Loading