Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Netty to 4.1.78.Final #3776

Closed
wants to merge 1 commit into from
Closed

Conversation

mch2
Copy link
Member

@mch2 mch2 commented Jul 5, 2022

Signed-off-by: Marc Handalian handalm@amazon.com

Description

Bumping netty to latest final version. Resolves https://nvd.nist.gov/vuln/detail/CVE-2022-24823

Issues Resolved

https://nvd.nist.gov/vuln/detail/CVE-2022-24823

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Marc Handalian <handalm@amazon.com>
@cwperks
Copy link
Member

cwperks commented Jul 5, 2022

Hey @mch2, I created a PR for this earlier today here: #3772. We made a recent change on the security plug-in to use the version of Netty from core's version.properties and I made a follow-up PR to upgrade the Netty version to address the CVE in netty 4.1.73.Final. I'll close my PR since it bumps to 4.1.77.Final instead of the latest 4.1.78.Final.

FYI you will need to edit one of the Netty tests (See https://github.com/opensearch-project/OpenSearch/pull/3772/files#diff-b2be7b27e3f11bae28b487d564519a4860b6799752616e67957031dfbca6816c) for a change in verbiage in one of the error messages.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Gradle Check (Jenkins) Run Completed with:

@mch2
Copy link
Member Author

mch2 commented Jul 5, 2022

@cwperks Thanks for the heads up, lets close this one and work off of yours that is further ahead.

@mch2 mch2 closed this Jul 5, 2022
@mch2 mch2 deleted the netty branch January 11, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants