Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing flaky org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded test case #4012

Merged
merged 1 commit into from
Jul 26, 2022
Merged

Fixing flaky org.opensearch.cluster.routing.allocation.decider.DiskThresholdDeciderIT.testHighWatermarkNotExceeded test case #4012

merged 1 commit into from
Jul 26, 2022

Conversation

reta
Copy link
Collaborator

@reta reta commented Jul 26, 2022 •
edited
Loading

Signed-off-by: Andriy Redko andriy.redko@aiven.io

Description

Since #3561 got merged, we could fix the test and revert #3844

Issues Resolved

Closes #3579

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta
Fixing flaky org.opensearch.cluster.routing.allocation.decider.DiskTh…
ae3b886 
…resholdDeciderIT.testHighWatermarkNotExceeded test case

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
@reta reta requested a review from a team as a code owner July 26, 2022 14:02
@reta reta added v3.0.0 Issues and PRs related to version 3.0.0 backport 2.x Backport to 2.x branch v2.2.0 labels Jul 26, 2022
@github-actions
Copy link
Contributor

Gradle Check (Jenkins) Run Completed with:

dreamer-89
dreamer-89 approved these changes Jul 26, 2022
View reviewed changes
Copy link
Member

@dreamer-89 dreamer-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @reta for this critical change. These tests have been causing lot of gradle check failures.

@reta reta merged commit 7694a27 into opensearch-project:main Jul 26, 2022
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 26, 2022
@reta @github-actions
Fixing flaky org.opensearch.cluster.routing.allocation.decider.DiskTh…
f239176 
…resholdDeciderIT.testHighWatermarkNotExceeded test case (#4012)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 7694a27)
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jul 26, 2022
Merged
reta added a commit that referenced this pull request Jul 26, 2022
@opensearch-trigger-bot @reta
Fixing flaky org.opensearch.cluster.routing.allocation.decider.DiskTh…
4b7bf19 
…resholdDeciderIT.testHighWatermarkNotExceeded test case (#4012) (#4014)

Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
(cherry picked from commit 7694a27)

Co-authored-by: Andriy Redko <andriy.redko@aiven.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dreamer-89 dreamer-89 dreamer-89 approved these changes

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch v2.2.0 v3.0.0 Issues and PRs related to version 3.0.0
Projects
None yet
Milestone
No milestone
2 participants
@reta @dreamer-89