Mapping IllegalArgumentException to SettingsException extend OpenSearchException in AbstractScopedSettings class #4792

xuezhou25 · 2022-10-14T11:08:43Z

Description

Mapping IllegalArgumentException to SettingsException extend OpenSearchException in AbstractScopedSettings class so that the helpful error messages can be reported.

Issues Resolved

resolve #4745

Check List

New functionality includes testing.
- All tests pass
New functionality has been documented.
- New functionality has javadoc added
Commits are signed per the DCO using --signoff
Commit changes are listed out in CHANGELOG.md file (See: Changelog)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…penSearchException in AbstractScopedSettings class Signed-off-by: Xue Zhou <xuezhou@amazon.com>

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-10-14T17:21:45Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4712/
CommitID: 0b6b827

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-10-14T19:08:14Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4719/
CommitID: af93be0

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-10-14T22:41:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4724/
CommitID: d0d7465

andrross · 2022-10-14T23:17:06Z

server/src/main/java/org/opensearch/InvalidArgumentException.java

+ *
+ * @opensearch.internal
+ */
+public class InvalidArgumentException extends OpenSearchException {


Can the existing org.opensearch.common.settings.SettingsException class be used here and avoid creating a new one?

It is important that this case returns a BAD_REQUEST error code, so the following would need to be added to SettingsException to make that happen:

@Override public RestStatus status() { return RestStatus.BAD_REQUEST; }

That might be okay because it looks like the existing usages of SettingsException would probably be better as a BAD_REQUEST, but I'm not 100% sure about that.

…o SettingsException Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-10-19T18:05:27Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/4979/
CommitID: 6ec459b

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-10-20T05:04:49Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5019/
CommitID: 982e29f

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-10-20T06:19:47Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5024/
CommitID: a210be7

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-10-20T20:02:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/5104/
CommitID: c1daf24

dblock · 2022-10-20T21:23:18Z

CHANGELOG.md

@@ -85,6 +85,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 - Backport Apache Lucene version change for 2.4.0 ([#4677](https://github.com/opensearch-project/OpenSearch/pull/4677))
 - Refactor Base Action class javadocs to OpenSearch.API ([#4732](https://github.com/opensearch-project/OpenSearch/pull/4732))
 - Migrate client transports to Apache HttpClient / Core 5.x ([#4459](https://github.com/opensearch-project/OpenSearch/pull/4459))
+- Mapping IllegalArgumentException to InvalidArgumentException extend OpenSearchException in AbstractScopedSettings class ([#4792](https://github.com/opensearch-project/OpenSearch/pull/4792))


Describe what has changed for the caller instead?

github-actions · 2022-11-08T18:55:48Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6595/
CommitID: c1daf24

github-actions · 2022-11-09T19:15:02Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6705/
CommitID: c1daf24

…ception # Conflicts: # CHANGELOG.md

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-11-09T22:06:35Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6719/
CommitID: 1f47ec5
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2022-11-10T01:21:41Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/6730/
CommitID: d7af0d4
Please examine the workflow log, locate, and copy-paste the failure below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2023-01-11T07:08:15Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9282/
CommitID: 22adbd3
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

tlfeng · 2023-01-11T18:39:14Z

In build 9282:
The failed test is introduced in commit da94dbb on 12/22/2022

REPRODUCE WITH: ./gradlew ':server:test' --tests "org.opensearch.extensions.ExtensionsManagerTests.testHandleAddSettingsUpdateConsumerRequest" -Dtests.seed=EC17246CC904E1E0 -Dtests.security.manager=true -Dtests.jvm.argline="-XX:TieredStopAtLevel=1 -XX:ReservedCodeCacheSize=64m" -Dtests.locale=ar-BH -Dtests.timezone=America/Inuvik -Druntime.java=19

org.opensearch.extensions.ExtensionsManagerTests > testHandleAddSettingsUpdateConsumerRequest FAILED
    SettingsException[Setting is not registered for key [falseSetting]]
        at __randomizedtesting.SeedInfo.seed([EC17246CC904E1E0:4A8CBBFBDAADD80B]:0)
        at app//org.opensearch.common.settings.AbstractScopedSettings.addSettingsUpdateConsumer(AbstractScopedSettings.java:249)
        at app//org.opensearch.common.settings.AbstractScopedSettings.addSettingsUpdateConsumer(AbstractScopedSettings.java:476)
        at app//org.opensearch.extensions.AddSettingsUpdateConsumerRequestHandler.handleAddSettingsUpdateConsumerRequest(AddSettingsUpdateConsumerRequestHandler.java:73)
        at app//org.opensearch.extensions.ExtensionsManagerTests.testHandleAddSettingsUpdateConsumerRequest(ExtensionsManagerTests.java:738)

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2023-01-11T20:27:17Z

Gradle Check (Jenkins) Run Completed with:

RESULT: TIMEOUT ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9304/
CommitID: 22adbd3
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-11T20:48:51Z

Gradle Check (Jenkins) Run Completed with:

RESULT: TIMEOUT ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9307/
CommitID: 07f1f72
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-11T22:00:03Z

Gradle Check (Jenkins) Run Completed with:

RESULT: null ❌
URL: null
CommitID: 07f1f72
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-01-12T22:26:19Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9355/
CommitID: 07f1f72
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

tlfeng · 2023-01-12T23:37:08Z

In build 9355, the same failure as above #4792 (comment)

github-actions · 2023-01-17T20:12:20Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/9489/
CommitID: 07f1f72
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

kotwanikunal · 2023-01-18T23:44:55Z

@xuezhou25 Can you please rebase your branch with the latest commits?

…ception # Conflicts: # CHANGELOG.md

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2023-02-06T05:31:55Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/10668/
CommitID: a002e1b
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-02-06T05:32:45Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/10669/
CommitID: a6932d6
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

github-actions · 2023-02-06T06:59:30Z

Gradle Check (Jenkins) Run Completed with:

RESULT: FAILURE ❌
URL: https://build.ci.opensearch.org/job/gradle-check/10673/
CommitID: fb82354
Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green.
Is the failure a flaky test unrelated to your change?

github-actions · 2023-02-06T07:34:46Z

Gradle Check (Jenkins) Run Completed with:

RESULT: SUCCESS ✅
URL: https://build.ci.opensearch.org/job/gradle-check/10674/
CommitID: fb82354

xuezhou25 added 2 commits October 14, 2022 03:58

Mapping IllegalArgumentException to InvalidArgumentException extend O…

1785df1

…penSearchException in AbstractScopedSettings class Signed-off-by: Xue Zhou <xuezhou@amazon.com>

Modify changelog

8c9c280

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

xuezhou25 requested review from a team and reta as code owners October 14, 2022 11:08

Fix IT class

0b6b827

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

Fix IT class

af93be0

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

opensearch-project deleted a comment from github-actions bot Oct 14, 2022

Fix spotless issue

d0d7465

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

andrross reviewed Oct 14, 2022

View reviewed changes

delete InvalidArgumentException and change illegalArgumentException t…

6ec459b

…o SettingsException Signed-off-by: Xue Zhou <xuezhou@amazon.com>

fix test failure

982e29f

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

Fix spotless issue

a210be7

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

Fix test failure

c1daf24

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

dblock reviewed Oct 20, 2022

View reviewed changes

xuezhou25 added 2 commits November 9, 2022 13:38

Merge branch 'main' into map_IllegalArgumentException_to_OpenSearchEx…

a5a902f

…ception # Conflicts: # CHANGELOG.md

rebase and fix changelog conflicts

1f47ec5

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

fix test failure

d7af0d4

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

fix test failure

701bd17

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

xuezhou25 requested review from adnapibar, Rishikesh1159, ryanbogan, saratvemulapalli, shwetathareja, dreamer-89, tlfeng and VachaShah as code owners January 11, 2023 06:42

Modify changelog

07f1f72

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

xuezhou25 added 2 commits February 5, 2023 20:56

Merge branch 'main' into map_IllegalArgumentException_to_OpenSearchEx…

a002e1b

…ception # Conflicts: # CHANGELOG.md

Modify changelog

a6932d6

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

fix test failure

fb82354

Signed-off-by: Xue Zhou <xuezhou@amazon.com>

tlfeng approved these changes Feb 6, 2023

View reviewed changes

xuezhou25 merged commit ee8105b into opensearch-project:main Feb 6, 2023

xuezhou25 deleted the map_IllegalArgumentException_to_OpenSearchException branch February 6, 2023 18:23

Yury-Fridlyand mentioned this pull request Feb 7, 2023

Fix IT according to OpenSearch changes. opensearch-project/sql#1326

Merged

6 tasks

VachaShah mentioned this pull request Feb 21, 2023

[BUG] Integration tests failing against main branch of OpenSearch opensearch-project/opensearch-java#374

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mapping IllegalArgumentException to SettingsException extend OpenSearchException in AbstractScopedSettings class #4792

Mapping IllegalArgumentException to SettingsException extend OpenSearchException in AbstractScopedSettings class #4792

xuezhou25 commented Oct 14, 2022 •

edited

Loading

github-actions bot commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

github-actions bot commented Oct 14, 2022

andrross Oct 14, 2022

github-actions bot commented Oct 19, 2022

github-actions bot commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

dblock Oct 20, 2022

github-actions bot commented Nov 8, 2022

github-actions bot commented Nov 9, 2022

github-actions bot commented Nov 9, 2022

github-actions bot commented Nov 10, 2022

github-actions bot commented Jan 11, 2023

tlfeng commented Jan 11, 2023

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 11, 2023

github-actions bot commented Jan 12, 2023

tlfeng commented Jan 12, 2023

github-actions bot commented Jan 17, 2023

kotwanikunal commented Jan 18, 2023

github-actions bot commented Feb 6, 2023

github-actions bot commented Feb 6, 2023

github-actions bot commented Feb 6, 2023

github-actions bot commented Feb 6, 2023

Mapping IllegalArgumentException to SettingsException extend OpenSearchException in AbstractScopedSettings class #4792

Mapping IllegalArgumentException to SettingsException extend OpenSearchException in AbstractScopedSettings class #4792

Conversation

xuezhou25 commented Oct 14, 2022 • edited Loading

Description

Issues Resolved

Check List

github-actions bot commented Oct 14, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 14, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 14, 2022

Gradle Check (Jenkins) Run Completed with:

andrross Oct 14, 2022

Choose a reason for hiding this comment

github-actions bot commented Oct 19, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Oct 20, 2022

Gradle Check (Jenkins) Run Completed with:

dblock Oct 20, 2022

Choose a reason for hiding this comment

github-actions bot commented Nov 8, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 9, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 9, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Nov 10, 2022

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 11, 2023

Gradle Check (Jenkins) Run Completed with:

tlfeng commented Jan 11, 2023

github-actions bot commented Jan 11, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 11, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 11, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Jan 12, 2023

Gradle Check (Jenkins) Run Completed with:

tlfeng commented Jan 12, 2023

github-actions bot commented Jan 17, 2023

Gradle Check (Jenkins) Run Completed with:

kotwanikunal commented Jan 18, 2023

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

github-actions bot commented Feb 6, 2023

Gradle Check (Jenkins) Run Completed with:

xuezhou25 commented Oct 14, 2022 •

edited

Loading